Room deletion fails for version 12 rooms

[bones-was-here]

Background information

• Dendrite version or git SHA: 5dcf908
• SQLite3 or Postgres?: postgres
• Running in Docker?: no
• go version: 1.24
• Client used (if applicable): element web, curl

Description

• What is the problem: can't delete a room when its version is 12
• Who is affected: server admins
• How is this bug manifesting: HTTP 500, error from gomatrixserverlib
• When did this first appear: probably never worked

Steps to reproduce

• try to delete a v12 room, for example: curl -v --unix-socket /run/dendrite/listen.sock -H 'Authorization: Bearer <secrit_sauce>' -d '' 'http://127.0.0.1:8008/_dendrite/admin/purgeRoom/!cyyUHZjfdU__pEBVmfcJ0hzbaBKzoSEbNc6vdl92KW4'

The response body is

{"message":"gomatrixserverlib: invalid ID \"!cyyUHZjfdU__pEBVmfcJ0hzbaBKzoSEbNc6vdl92KW4\" missing ':'"}

so presumably the lib needs to be updated to no longer parse a domain out of the room ID, at least for v12 rooms.

Interestingly the evacuateRoom endpoint succeeds for the same v12 room.

[S7evinK]

Fixed with #3670

Thanks for testing! :)