Improve Rx sequence regarding listener

Author: bmarty

vector/src/main/java/im/vector/app/features/home/ShortcutsHandler.kt

@@ -54,17 +54,15 @@ class ShortcutsHandler @Inject constructor(
         hasPinCode = pinCodeStore.getEncodedPin() != null
 
         val session = activeSessionHolder.getSafeActiveSession() ?: return Disposables.empty()
-        pinCodeStore.addListener(this)
         return session.getRoomSummariesLive(
                 roomSummaryQueryParams {
                     memberships = listOf(Membership.JOIN)
                 },
                 sortOrder = RoomSortOrder.PRIORITY_AND_ACTIVITY
         )
                 .asObservable()
-                .doOnDispose {
-                    pinCodeStore.removeListener(this)
-                }
+                .doOnSubscribe { pinCodeStore.addListener(this) }
+                .doFinally { pinCodeStore.removeListener(this) }
                 .subscribe { rooms ->
                     // Remove dead shortcuts (i.e. deleted rooms)
                     removeDeadShortcut(rooms.map { it.roomId })