injecting the context directly to the handler

Author: ouchadam

vector/src/main/java/im/vector/app/features/attachments/ShareIntentHandler.kt

@@ -23,14 +23,15 @@ import javax.inject.Inject
 
 class ShareIntentHandler @Inject constructor(
         private val multiPickerIncomingFiles: MultiPickerIncomingFiles,
+        private val context: Context,
 ) {
 
     /**
      * This methods aims to handle incoming share intents.
      *
      * @return true if it can handle the intent data, false otherwise
      */
-    fun handleIncomingShareIntent(context: Context, intent: Intent, onFile: (List<ContentAttachmentData>) -> Unit, onPlainText: (String) -> Unit): Boolean {
+    fun handleIncomingShareIntent(intent: Intent, onFile: (List<ContentAttachmentData>) -> Unit, onPlainText: (String) -> Unit): Boolean {
         val type = intent.resolveType(context) ?: return false
         return when {
             type == "text/plain" -> handlePlainText(intent, onPlainText)

vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt

@@ -1619,7 +1619,7 @@ class TimelineFragment @Inject constructor(
 
     private fun sendUri(uri: Uri): Boolean {
         val shareIntent = Intent(Intent.ACTION_SEND, uri)
-        val isHandled = shareIntentHandler.handleIncomingShareIntent(requireContext(), shareIntent, ::onContentAttachmentsReady, onPlainText = {
+        val isHandled = shareIntentHandler.handleIncomingShareIntent(shareIntent, ::onContentAttachmentsReady, onPlainText = {
             fatalError("Should not happen as we're generating a File based share Intent", vectorPreferences.failFast())
         })
         if (!isHandled) {

vector/src/main/java/im/vector/app/features/share/IncomingShareFragment.kt

@@ -116,7 +116,6 @@ class IncomingShareFragment @Inject constructor(
     }
 
     private fun handleIncomingShareIntent(intent: Intent) = shareIntentHandler.handleIncomingShareIntent(
-            requireContext(),
             intent,
             onFile = {
                 val sharedData = SharedData.Attachments(it)

vector/src/test/java/im/vector/app/features/attachments/ShareIntentHandlerTest.kt

@@ -36,7 +36,7 @@ class ShareIntentHandlerTest {
     private val onFile = FakeFunction1<List<ContentAttachmentData>>()
     private val onPlainText = FakeFunction1<String>()
 
-    private val shareIntentHandler = ShareIntentHandler(fakeMultiPickerIncomingFiles.instance)
+    private val shareIntentHandler = ShareIntentHandler(fakeMultiPickerIncomingFiles.instance, A_CONTEXT)
 
     @Test
     fun `given an unhandled sharing intent type, when handling intent, then is not handled`() {
@@ -161,6 +161,6 @@ class ShareIntentHandlerTest {
     }
 
     private fun handleIncomingShareIntent(intent: FakeIntent): Boolean {
-        return shareIntentHandler.handleIncomingShareIntent(A_CONTEXT, intent.instance, onFile.capture, onPlainText.capture)
+        return shareIntentHandler.handleIncomingShareIntent(intent.instance, onFile.capture, onPlainText.capture)
     }
 }