Upgrade detekt and reduce detected issues (less impact on this old code).

Author: bmarty

build.gradle

@@ -43,7 +43,7 @@ plugins {
     // ktlint Plugin
     id "org.jlleitschuh.gradle.ktlint" version "11.3.2"
     // Detekt
-    id "io.gitlab.arturbosch.detekt" version "1.22.0"
+    id "io.gitlab.arturbosch.detekt" version "1.23.7"
     // Ksp
     id "com.google.devtools.ksp" version "1.9.24-1.0.20"
 

dependencies_groups.gradle

@@ -203,6 +203,7 @@ ext.groups = [
                         'org.jacoco',
                         'org.java-websocket',
                         'org.jcodec',
+                        'org.jcommander',
                         'org.jetbrains',
                         'org.jetbrains.dokka',
                         'org.jetbrains.intellij.deps',
@@ -229,6 +230,7 @@ ext.groups = [
                         'org.reactivestreams',
                         'org.robolectric',
                         'org.slf4j',
+                        'org.snakeyaml',
                         'org.sonatype.oss',
                         'org.testng',
                         'org.threeten',

tools/detekt/detekt.yml

@@ -25,6 +25,8 @@ style:
     active: false
   UseCheckOrError:
     active: false
+  UnusedPrivateProperty:
+    active: false
 
 empty-blocks:
   EmptyFunctionBlock:
@@ -75,6 +77,8 @@ naming:
 performance:
   SpreadOperator:
     active: false
+  ForEachOnRange:
+    active: false
 
 # Note: all rules for `comments` are disabled by default, but I put them here to be aware of their existence
 comments:
@@ -91,7 +95,7 @@ comments:
   EndOfSentenceFormat:
     active: true
   OutdatedDocumentation:
-    active: true
+    active: false
   UndocumentedPublicClass:
     active: false
   UndocumentedPublicFunction: