Skip to content

Commit 780f1ff

Browse files
Merge branch 'develop' into feature/aris/fix_account_deactivation_issue
# Conflicts: # vector/src/main/java/im/vector/app/features/settings/account/deactivation/DeactivateAccountViewModel.kt
2 parents ba99d5c + f5973fa commit 780f1ff

File tree

182 files changed

+729
-480
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

182 files changed

+729
-480
lines changed

.github/workflows/triage-labelled.yml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,3 +251,30 @@ jobs:
251251
env:
252252
PROJECT_ID: "PN_kwDOAM0swc4AArk0"
253253
GITHUB_TOKEN: ${{ secrets.ELEMENT_BOT_TOKEN }}
254+
255+
move_element_x_issues:
256+
name: ElementX issues to ElementX project board
257+
runs-on: ubuntu-latest
258+
# Skip in forks
259+
if: >
260+
github.repository == 'vector-im/element-android' &&
261+
(contains(github.event.issue.labels.*.name, 'Z-ElementX-Alpha') ||
262+
contains(github.event.issue.labels.*.name, 'Z-ElementX-Beta') ||
263+
contains(github.event.issue.labels.*.name, 'Z-ElementX'))
264+
steps:
265+
- uses: octokit/[email protected]
266+
with:
267+
headers: '{"GraphQL-Features": "projects_next_graphql"}'
268+
query: |
269+
mutation add_to_project($projectid:ID!,$contentid:ID!) {
270+
addProjectNextItem(input:{projectId:$projectid contentId:$contentid}) {
271+
projectNextItem {
272+
id
273+
}
274+
}
275+
}
276+
projectid: ${{ env.PROJECT_ID }}
277+
contentid: ${{ github.event.issue.node_id }}
278+
env:
279+
PROJECT_ID: "PN_kwDOAM0swc4ABTXY"
280+
GITHUB_TOKEN: ${{ secrets.ELEMENT_BOT_TOKEN }}

.github/workflows/update-gradle-wrapper.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ jobs:
1313

1414
- name: Update Gradle Wrapper
1515
uses: gradle-update/update-gradle-wrapper-action@v1
16+
# Skip in forks
17+
if: github.repository == 'vector-im/element-android'
1618
with:
1719
repo-token: ${{ secrets.GITHUB_TOKEN }}
1820
target-branch: develop

CHANGES.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
Changes in Element 1.4.13 (2022-04-26)
2+
======================================
3+
4+
Bugfixes 🐛
5+
----------
6+
- Fix UI freeze observed after each incremental sync ([#5835](https://github.com/vector-im/element-android/issues/5835))
7+
8+
19
Changes in Element v1.4.12 (2022-04-20)
210
=======================================
311

build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ buildscript {
2121
classpath 'org.sonarsource.scanner.gradle:sonarqube-gradle-plugin:3.3'
2222
classpath 'com.google.android.gms:oss-licenses-plugin:0.10.5'
2323
classpath "com.likethesalad.android:stem-plugin:2.0.0"
24-
classpath 'org.owasp:dependency-check-gradle:7.0.4.1'
25-
classpath "org.jetbrains.dokka:dokka-gradle-plugin:1.6.20"
24+
classpath 'org.owasp:dependency-check-gradle:7.1.0.1'
25+
classpath "org.jetbrains.dokka:dokka-gradle-plugin:1.6.21"
2626
// NOTE: Do not place your application dependencies here; they belong
2727
// in the individual module build.gradle files
2828
}

changelog.d/5816.sdk

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Some `Session` apis are now available by requesting the service first. For instance `Session.updateAvatar(...)` is now `Session.profileService().updateAvatar(...)`
2+
The shortcut `Room.search()` has been removed, you have to use `Session.searchService().search()`

changelog.d/5832.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Add a GH workflow to push ElementX issues to the global board.

changelog.d/5836.doc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Update the PR process doc with 2 reviewers and a new reviewer team.

changelog.d/5847.bugfix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixes missing call icons when threads are enabled

docs/pull_request.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,15 @@ Also, draft PR should not stay indefinitely in this state. It may be removed if
3232

3333
##### PR Review Assignment
3434

35-
We use automatic assignment for PR reviews. A PR is automatically routed by GitHub to a team member using the round robin algorithm. The process is the following:
35+
We use automatic assignment for PR reviews. A PR is automatically routed by GitHub to 2 team members using the round robin algorithm. The process is the following:
3636

37-
- The PR creator assigns the [element-android](https://github.com/orgs/vector-im/teams/element-android) team as a reviewer. They can skip this process and assign directly a specific member if they think they should take a look at it.
38-
- GitHub automatically assigns one reviewer. If the chosen reviewer is not available (holiday, etc.), remove them and set again the team, GitHub will select another reviewer.
39-
- The reviewer gets a notification to make the review: they review the code following the good practice (see the rest of this document).
37+
- The PR creator can assign specific people if they have another Android developer in their team or they think a specific reviewer should take a look at the PR.
38+
- If there are missing reviewers, the PR creator assigns the [element-android-reviewers](https://github.com/orgs/vector-im/teams/element-android-reviewers) team as a reviewer.
39+
- GitHub automatically assigns other reviewers. If one of the chosen reviewers is not available (holiday, etc.), remove them and set again the team, GitHub will select another reviewer.
40+
- Reviewers get a notification to make the review: they review the code following the good practice (see the rest of this document).
4041
- After making their own review, if they feel not confident enough, they can ask another person for a full review, or they can tag someone within a PR comment to check specific lines.
4142

42-
For PRs coming from the community, the issue wrangler can assign either the team [element-android](https://github.com/orgs/vector-im/teams/element-android) or any member directly.
43+
For PRs coming from the community, the issue wrangler can assign either the team [element-android-reviewers](https://github.com/orgs/vector-im/teams/element-android-reviewers) or any members directly.
4344

4445
##### PR review time
4546

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Main changes in this version: Allows users to appear offline and adds an audio player for audio attachments
2+
Full changelog: https://github.com/vector-im/element-android/releases

0 commit comments

Comments
 (0)