avoiding multiple list iterations via mapNotNull

ouchadam · ouchadam · commit b146501f2983 · 2021-10-26T20:03:10.000+01:00
diff --git a/vector/src/main/java/im/vector/app/features/notifications/ProcessedEvent.kt b/vector/src/main/java/im/vector/app/features/notifications/ProcessedEvent.kt
@@ -27,4 +27,6 @@ data class ProcessedEvent<T>(
     }
 }
 
-fun <T> List<ProcessedEvent<T>>.onlyKeptEvents() = filter { it.type == ProcessedEvent.Type.KEEP }.map { it.event }
+fun <T> List<ProcessedEvent<T>>.onlyKeptEvents() = mapNotNull { processedEvent ->
+    processedEvent.event.takeIf { processedEvent.type == ProcessedEvent.Type.KEEP }
+}

Original file line number	Diff line number	Diff line change
`@@ -27,4 +27,6 @@ data class ProcessedEvent<T>(`
`27`	`27`	`}`
`28`	`28`	`}`
`29`	`29`
`30`		`-fun <T> List<ProcessedEvent<T>>.onlyKeptEvents() = filter { it.type == ProcessedEvent.Type.KEEP }.map { it.event }`
	`30`	`+fun <T> List<ProcessedEvent<T>>.onlyKeptEvents() = mapNotNull { processedEvent ->`
	`31`	`+ processedEvent.event.takeIf { processedEvent.type == ProcessedEvent.Type.KEEP }`
	`32`	`+}`