Skip to content

Commit c77ecc6

Browse files
authored
Merge pull request #6288 from deepbluev7/nico/stable-aliases
Use stable endpoint for alias management
2 parents 58580f1 + 75a6986 commit c77ecc6

File tree

4 files changed

+3
-3
lines changed

4 files changed

+3
-3
lines changed

changelog.d/6288.bugfix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Use stable endpoint for alias management instead of MSC2432. Contributed by Nico.

matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/network/ApiPath.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ enum class ApiPath(val path: String, val method: String) {
162162
KICK_USER(NetworkConstants.URI_API_PREFIX_PATH_R0 + "rooms/{roomId}/kick", "POST"),
163163
REDACT_EVENT(NetworkConstants.URI_API_PREFIX_PATH_R0 + "rooms/{roomId}/redact/{eventId}/{txnId}", "PUT"),
164164
REPORT_CONTENT(NetworkConstants.URI_API_PREFIX_PATH_R0 + "rooms/{roomId}/report/{eventId}", "POST"),
165-
GET_ALIASES(NetworkConstants.URI_API_PREFIX_PATH_UNSTABLE + "org.matrix.msc2432/rooms/{roomId}/aliases", "GET"),
165+
GET_ALIASES(NetworkConstants.URI_API_PREFIX_PATH_R0 + "rooms/{roomId}/aliases", "GET"),
166166
SEND_TYPING_STATE(NetworkConstants.URI_API_PREFIX_PATH_R0 + "rooms/{roomId}/typing/{userId}", "PUT"),
167167
PUT_TAG(NetworkConstants.URI_API_PREFIX_PATH_R0 + "user/{userId}/rooms/{roomId}/tags/{tag}", "PUT"),
168168
DELETE_TAG(NetworkConstants.URI_API_PREFIX_PATH_R0 + "user/{userId}/rooms/{roomId}/tags/{tag}", "DELETE"),

matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/RoomAPI.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ internal interface RoomAPI {
377377
* Get a list of aliases maintained by the local server for the given room.
378378
* Ref: https://matrix.org/docs/spec/client_server/r0.6.1#get-matrix-client-r0-rooms-roomid-aliases
379379
*/
380-
@GET(NetworkConstants.URI_API_PREFIX_PATH_UNSTABLE + "org.matrix.msc2432/rooms/{roomId}/aliases")
380+
@GET(NetworkConstants.URI_API_PREFIX_PATH_R0 + "rooms/{roomId}/aliases")
381381
suspend fun getAliases(@Path("roomId") roomId: String): GetAliasesResponse
382382

383383
/**

matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/alias/GetRoomLocalAliasesTask.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ internal class DefaultGetRoomLocalAliasesTask @Inject constructor(
3434
) : GetRoomLocalAliasesTask {
3535

3636
override suspend fun execute(params: GetRoomLocalAliasesTask.Params): List<String> {
37-
// We do not check for "org.matrix.msc2432", so the API may be missing
3837
val response = executeRequest(globalErrorReceiver) {
3938
roomAPI.getAliases(roomId = params.roomId)
4039
}

0 commit comments

Comments
 (0)