Skip to content

Commit 0128f2f

Browse files
authored
Don't produce compressed assets at build time and instead do it as part of the nginx build (#2995)
The core vite build shouldn't be responsible for implementing optimisations that are specific to a particular distribution mechanism. e.g. static compressed files for nginx. This way the core build is "clean". Instead, the packager/distributor of the build should be responsible for it. e.g. the nginx docker distribution should do any optimisations that it chooses.
1 parent e23d882 commit 0128f2f

File tree

4 files changed

+11
-21
lines changed

4 files changed

+11
-21
lines changed

Dockerfile

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
1+
FROM alpine AS builder
2+
3+
COPY ./dist /dist
4+
5+
# Compress assets to work with nginx-gzip-static-module
6+
WORKDIR /dist/assets
7+
RUN gzip -k ../index.html *.js *.map *.css *.wasm *-app-*.json
8+
19
FROM nginxinc/nginx-unprivileged:alpine
210

3-
COPY ./dist /app
11+
COPY --from=builder ./dist /app
12+
413
COPY config/nginx.conf /etc/nginx/conf.d/default.conf

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@
113113
"unique-names-generator": "^4.6.0",
114114
"vaul": "^1.0.0",
115115
"vite": "^6.0.0",
116-
"vite-plugin-compression2": "^1.3.1",
117116
"vite-plugin-html-template": "^1.1.0",
118117
"vite-plugin-svgr": "^4.0.0",
119118
"vitest": "^3.0.0",

vite.config.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ Please see LICENSE in the repository root for full details.
66
*/
77

88
import { defineConfig, loadEnv } from "vite";
9-
import { compression } from "vite-plugin-compression2";
109
import svgrPlugin from "vite-plugin-svgr";
1110
import htmlTemplate from "vite-plugin-html-template";
1211
import { codecovVitePlugin } from "@codecov/vite-plugin";
@@ -39,10 +38,6 @@ export default defineConfig(({ mode }) => {
3938
bundleName: "element-call",
4039
uploadToken: process.env.CODECOV_TOKEN,
4140
}),
42-
43-
compression({
44-
exclude: [/config.json/],
45-
}),
4641
];
4742

4843
if (

yarn.lock

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2519,7 +2519,7 @@
25192519
"@react-spring/shared" "~9.7.5"
25202520
"@react-spring/types" "~9.7.5"
25212521

2522-
"@rollup/pluginutils@^5.1.0", "@rollup/pluginutils@^5.1.3":
2522+
"@rollup/pluginutils@^5.1.3":
25232523
version "5.1.3"
25242524
resolved "https://registry.yarnpkg.com/@rollup/pluginutils/-/pluginutils-5.1.3.tgz#3001bf1a03f3ad24457591f2c259c8e514e0dbdf"
25252525
integrity sha512-Pnsb6f32CD2W3uCaLZIzDmeFyQ2b8UWMFI7xtwUezpcGBDVDW6y9XgAWIlARiGAo6eNF5FK5aQTr0LFyNyqq5A==
@@ -8133,11 +8133,6 @@ tapable@^2.2.0:
81338133
resolved "https://registry.yarnpkg.com/tapable/-/tapable-2.2.1.tgz#1967a73ef4060a82f12ab96af86d52fdb76eeca0"
81348134
integrity sha512-GNzQvQTOIP6RyTfE2Qxb8ZVlNmw0n88vp1szwWRimP02mnTsx3Wtn5qRdqY9w2XduFNUgvOwhNnQsjwCp+kqaQ==
81358135

8136-
tar-mini@^0.2.0:
8137-
version "0.2.0"
8138-
resolved "https://registry.yarnpkg.com/tar-mini/-/tar-mini-0.2.0.tgz#2b2cdc215f5b83b0ab8ce363dc9ded22de51849b"
8139-
integrity sha512-+qfUHz700DWnRutdUsxRRVZ38G1Qr27OetwaMYTdg8hcPxf46U0S1Zf76dQMWRBmusOt2ZCK5kbIaiLkoGO7WQ==
8140-
81418136
teex@^1.0.1:
81428137
version "1.0.1"
81438138
resolved "https://registry.yarnpkg.com/teex/-/teex-1.0.1.tgz#b8fa7245ef8e8effa8078281946c85ab780a0b12"
@@ -8628,14 +8623,6 @@ [email protected]:
86288623
pathe "^2.0.2"
86298624
vite "^5.0.0 || ^6.0.0"
86308625

8631-
vite-plugin-compression2@^1.3.1:
8632-
version "1.3.3"
8633-
resolved "https://registry.yarnpkg.com/vite-plugin-compression2/-/vite-plugin-compression2-1.3.3.tgz#d33ddfb4000c914783f4760f81a44ba52fc21ed1"
8634-
integrity sha512-Mb+xi/C5b68awtF4fNwRBPtoZiyUHU3I0SaBOAGlerlR31kusq1si6qG31lsjJH8T7QNg/p3IJY2HY9O9SvsfQ==
8635-
dependencies:
8636-
"@rollup/pluginutils" "^5.1.0"
8637-
tar-mini "^0.2.0"
8638-
86398626
vite-plugin-html-template@^1.1.0:
86408627
version "1.2.2"
86418628
resolved "https://registry.yarnpkg.com/vite-plugin-html-template/-/vite-plugin-html-template-1.2.2.tgz#d263c18dcf5f5e54bc74894546fd0ed993191f2f"

0 commit comments

Comments
 (0)