Skip to content

Commit 0a286b4

Browse files
authored
Never skip lobby for huddles (#3508) (#3509)
* Never skip lobby for huddles --------- Signed-off-by: Timo K <[email protected]>
1 parent cb7fc44 commit 0a286b4

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/UrlParams.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ describe("UrlParams", () => {
272272
computeUrlParams(
273273
"?intent=start_call&widgetId=1234&parentUrl=parent.org",
274274
),
275-
).toMatchObject(startNewCallDefaults("desktop"));
275+
).toMatchObject({ ...startNewCallDefaults("desktop"), skipLobby: false });
276276
});
277277

278278
it("accepts start_call_dm mobile", () => {
@@ -320,12 +320,12 @@ describe("UrlParams", () => {
320320
expect(computeUrlParams("?intent=start_call").skipLobby).toBe(false);
321321
});
322322

323-
it("defaults to true if intent is start_call in widget mode", () => {
323+
it("defaults to false if intent is start_call in widget mode", () => {
324324
expect(
325325
computeUrlParams(
326326
"?intent=start_call&widgetId=12345&parentUrl=https%3A%2F%2Flocalhost%2Ffoo",
327327
).skipLobby,
328-
).toBe(true);
328+
).toBe(false);
329329
});
330330

331331
it("default to false if intent is join_existing", () => {

src/UrlParams.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ export const computeUrlParams = (search = "", hash = ""): UrlParams => {
394394
};
395395
switch (intent) {
396396
case UserIntent.StartNewCall:
397-
intentPreset.skipLobby = true;
397+
intentPreset.skipLobby = false;
398398
break;
399399
case UserIntent.JoinExistingCall:
400400
// On desktop this will be overridden based on which button was used to join the call

0 commit comments

Comments
 (0)