Merge pull request #6028 from vector-im/ismail/6023_crashes

Fix some crashes

Author: ismailgulek

Riot/Modules/MatrixKit/Models/Room/MXKRoomDataSource.m

@@ -2387,17 +2387,18 @@ - (void)didReceiveReceiptEvent:(MXEvent *)receiptEvent roomState:(MXRoomState *)
             {
                 NSMutableDictionary<NSString* /* eventId */, NSArray<MXReceiptData*> *> *updatedCellDataReadReceipts = [NSMutableDictionary dictionary];
 
-                for (NSString *eventId in cellData.readReceipts)
+                NSDictionary<NSString*, NSArray<MXReceiptData*>*> *readReceiptsCopy = [cellData.readReceipts mutableDeepCopy];
+                for (NSString *eventId in readReceiptsCopy)
                 {
-                    for (MXReceiptData *receiptData in cellData.readReceipts[eventId])
+                    for (MXReceiptData *receiptData in readReceiptsCopy[eventId])
                     {
                         for (NSString *senderId in readReceiptSenders)
                         {
                             if ([receiptData.userId isEqualToString:senderId])
                             {
                                 if (!updatedCellDataReadReceipts[eventId])
                                 {
-                                    updatedCellDataReadReceipts[eventId] = cellData.readReceipts[eventId];
+                                    updatedCellDataReadReceipts[eventId] = readReceiptsCopy[eventId];
                                 }
 
                                 NSPredicate *predicate = [NSPredicate predicateWithFormat:@"userId!=%@", receiptData.userId];

Riot/Modules/Room/RoomViewController.m

@@ -3647,7 +3647,7 @@ - (void)showAdditionalActionsMenuForEvent:(MXEvent*)selectedEvent inCell:(id<MXK
                     activityViewController = [self.delegate roomViewController:self locationShareActivityViewControllerForEvent:selectedEvent];
                 }
 
-                if (activityViewController == nil) {
+                if (activityViewController == nil && selectedComponent.textMessage) {
                     NSArray *activityItems = @[selectedComponent.textMessage];
                     activityViewController = [[UIActivityViewController alloc] initWithActivityItems:activityItems applicationActivities:nil];
                 }

Riot/Modules/Spaces/SpaceList/SpaceListItemViewData.swift

@@ -19,7 +19,7 @@ import Foundation
 /// SpaceListViewCell view data
 struct SpaceListItemViewData {
     let spaceId: String
-    let title: String
+    let title: String?
     let avatarViewData: AvatarViewDataProtocol
     let isInvite: Bool
     let notificationCount: UInt

changelog.d/6023.bugfix

@@ -0,0 +1 @@
+Element: Fix some crashes after 1.8.10.