Room preview on a long press should not update the read receipt (#6027)

- Done

Author: gileluard

Riot/Modules/Common/Recents/RecentsViewController.m

@@ -370,7 +370,7 @@ - (void)refreshRecentsTable
 
     if (!self.recentsUpdateEnabled)
     {
-        isRefreshNeeded = NO;
+        isRefreshNeeded = YES;
         return;
     }
 

Riot/Modules/ContextMenu/ContextMenuProviders/PublicRoomContextMenuProvider.swift

@@ -37,11 +37,18 @@ class PublicRoomContextMenuProvider: NSObject {
                     }
                     roomViewController.isContextPreview = true
 
-                    let roomDataSourceManager = MXKRoomDataSourceManager.sharedManager(forMatrixSession: session)
-                    roomDataSourceManager?.roomDataSource(forRoom: room.roomId, create: true, onComplete: { roomDataSource in
-                        roomViewController.displayRoom(roomDataSource)
-                    })
-                    
+                    RoomPreviewDataSource.load(withRoomId: room.roomId, andMatrixSession: session) { [weak roomViewController] roomDataSource in
+                        guard let dataSource = roomDataSource as? RoomPreviewDataSource else {
+                            return
+                        }
+                        
+                        dataSource.markTimelineInitialEvent = false
+                        roomViewController?.displayRoom(dataSource)
+                        
+                        // Give the data source ownership to the room view controller.
+                        roomViewController?.hasRoomDataSourceOwnership = true
+                    }
+
                     return roomViewController
                 } else {
                     let viewModel = RoomContextPreviewViewModel(room: room)

Riot/Modules/ContextMenu/ContextMenuProviders/RecentCellContextMenuProvider.swift

@@ -47,11 +47,18 @@ class RecentCellContextMenuProvider: NSObject {
                     }
                     roomViewController.isContextPreview = true
 
-                    let roomDataSourceManager = MXKRoomDataSourceManager.sharedManager(forMatrixSession: session)
-                    roomDataSourceManager?.roomDataSource(forRoom: room.roomId, create: true, onComplete: { roomDataSource in
-                        roomViewController.displayRoom(roomDataSource)
-                    })
-                    
+                    RoomPreviewDataSource.load(withRoomId: room.roomId, andMatrixSession: session) { [weak roomViewController] roomDataSource in
+                        guard let dataSource = roomDataSource as? RoomPreviewDataSource else {
+                            return
+                        }
+
+                        dataSource.markTimelineInitialEvent = false
+                        roomViewController?.displayRoom(dataSource)
+
+                        // Give the data source ownership to the room view controller.
+                        roomViewController?.hasRoomDataSourceOwnership = true
+                    }
+
                     return roomViewController
                 } else {
                     let viewModel = RoomContextPreviewViewModel(room: room)

Riot/Modules/Room/DataSources/RoomPreviewDataSource.swift

@@ -0,0 +1,46 @@
+// 
+// Copyright 2022 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import Foundation
+
+/// `RoomPreviewDataSource` is used for room context menu.
+@objcMembers
+public class RoomPreviewDataSource: RoomDataSource {
+    
+    public override func finalizeInitialization() {
+        super.finalizeInitialization()
+        showReadMarker = false
+        showBubbleReceipts = false
+        showTypingRow = false
+    }
+    
+    public override var showReadMarker: Bool {
+        get {
+            return false
+        } set {
+            _ = newValue
+        }
+    }
+    
+    public override var showBubbleReceipts: Bool {
+        get {
+            return false
+        } set {
+            _ = newValue
+        }
+    }
+    
+}

Riot/Modules/Room/MXKRoomViewController.h

@@ -206,6 +206,11 @@ typedef NS_ENUM(NSUInteger, MXKRoomViewControllerJoinRoomResult) {
  */
 @property (strong, nonatomic) UserIndicatorStore *userIndicatorStore;
 
+/**
+ YES if the instance is used as context menu preview.
+ */
+@property (nonatomic, getter=isContextPreview) BOOL contextPeview;
+
 /**
  This object is defined when the displayed room is left. It is added into the bubbles table header.
  This label is used to display the reason why the room has been left.

Riot/Modules/Room/MXKRoomViewController.m

@@ -2368,6 +2368,12 @@ - (BOOL)reloadBubblesTable:(BOOL)useBottomAnchor invalidateBubblesCellDataCache:
 
 - (void)updateCurrentEventIdAtTableBottom:(BOOL)acknowledge
 {
+    // Do not update events if the controller is used as context menu preview.
+    if (self.isContextPreview)
+    {
+        return;
+    }
+    
     // Update the identifier of the event displayed at the bottom of the table, except if a rotation or other size transition is in progress.
     if (!isSizeTransitionInProgress && !self.isBubbleTableViewDisplayInTransition)
     {

Riot/Modules/Room/RoomViewController.h

@@ -91,8 +91,6 @@ extern NSNotificationName const RoomGroupCallTileTappedNotification;
  */
 @property (nonatomic, nullable) NSString *parentSpaceId;
 
-@property (nonatomic, getter=isContextPreview) BOOL contextPeview;
-
 /// Handles all banners that should be displayed at the top of the timeline but that should not scroll with the timeline
 @property (weak, nonatomic, nullable) IBOutlet UIStackView *topBannersStackView;
 

Riot/Modules/Room/RoomViewController.m

@@ -5569,6 +5569,15 @@ - (void)goBackToLive
                 continueBlock(threadDataSource, YES);
             }];
         }
+        else if (self.isContextPreview)
+        {
+            [RoomPreviewDataSource loadRoomDataSourceWithRoomId:self.roomDataSource.roomId
+                                               andMatrixSession:self.mainSession
+                                                     onComplete:^(RoomPreviewDataSource *roomDataSource)
+             {
+                continueBlock(roomDataSource, YES);
+            }];
+        }
         else
         {
             // Switch back to the room live timeline managed by MXKRoomDataSourceManager

changelog.d/6008.change

@@ -0,0 +1 @@
+Context menu: Room preview do not update the read receipt any more