Fix multiple pinned messages flacky tests by waiting the message to be displayed in the banner when pinned. (#28655)

florianduros · web-flow · commit 5686666ad255 · 2024-12-05T15:31:16.000Z
diff --git a/playwright/e2e/pinned-messages/index.ts b/playwright/e2e/pinned-messages/index.ts
@@ -129,6 +129,7 @@ export class Helpers {
         const timelineMessage = this.page.locator(".mx_MTextBody", { hasText: message });
         await timelineMessage.click({ button: "right" });
         await this.page.getByRole("menuitem", { name: "Pin", exact: true }).click();
+        await this.assertMessageInBanner(message);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -129,6 +129,7 @@ export class Helpers {`
`129`	`129`	`const timelineMessage = this.page.locator(".mx_MTextBody", { hasText: message });`
`130`	`130`	`await timelineMessage.click({ button: "right" });`
`131`	`131`	`await this.page.getByRole("menuitem", { name: "Pin", exact: true }).click();`
	`132`	`+ await this.assertMessageInBanner(message);`
`132`	`133`	`}`
`133`	`134`
`134`	`135`	`/**`