Skip to content

New threads are not properly shown in the Main Timeline (room) #19395

@Palid

Description

@Palid

Steps to reproduce

  1. Login with two different accounts and join the same room (Alice and Bob)
  2. Write a message from any of those account (Bob)
  3. Create a thread with the same account (Bob)
  4. Expect that on the second account (Alice) you will have the message with a thread

Outcome

What did you expect?

A threaded message, as the Bob account created

What happened instead?

The thread was not created

Problems analysis:

  1. EventTile.tsx is not properly listening for thread events updated, see: Fix threads not rendering properly in main timeline matrix-org/matrix-react-sdk#6929 (this pull request on itself does not fix the problem, as model is broken)
  2. matrix-js-sdk/src/models/thread.ts:77 - the root is always overriden when getting a new thread with the first reply event, instead of the actual thread's root.
  3. The proper root event (which in this case would be event.replyEventId, matrix-js-sdk/src/models/thread.ts:77) has not been added to the Thread's timeline, which means that event.rootEvent never exists and threads can't render

Operating system

No response

Browser information

No response

URL for webapp

No response

Homeserver

No response

Will you send logs?

No

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-ThreadsO-FrequentAffects or can be seen by most users regularly or impacts most users' first experienceS-MinorImpairs non-critical functionality or suitable workarounds existT-Defect

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions