-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Closed
Labels
A-ThreadsO-FrequentAffects or can be seen by most users regularly or impacts most users' first experienceAffects or can be seen by most users regularly or impacts most users' first experienceS-MinorImpairs non-critical functionality or suitable workarounds existImpairs non-critical functionality or suitable workarounds existT-Defect
Description
Steps to reproduce
- Login with two different accounts and join the same room (Alice and Bob)
- Write a message from any of those account (Bob)
- Create a thread with the same account (Bob)
- Expect that on the second account (Alice) you will have the message with a thread
Outcome
What did you expect?
A threaded message, as the Bob account created
What happened instead?
The thread was not created
Problems analysis:
- EventTile.tsx is not properly listening for thread events updated, see: Fix threads not rendering properly in main timeline matrix-org/matrix-react-sdk#6929 (this pull request on itself does not fix the problem, as model is broken)
matrix-js-sdk/src/models/thread.ts:77- therootis always overriden when getting a new thread with the first reply event, instead of the actual thread's root.- The proper root event (which in this case would be
event.replyEventId,matrix-js-sdk/src/models/thread.ts:77) has not been added to the Thread's timeline, which means thatevent.rootEventnever exists and threads can't render
Operating system
No response
Browser information
No response
URL for webapp
No response
Homeserver
No response
Will you send logs?
No
Metadata
Metadata
Assignees
Labels
A-ThreadsO-FrequentAffects or can be seen by most users regularly or impacts most users' first experienceAffects or can be seen by most users regularly or impacts most users' first experienceS-MinorImpairs non-critical functionality or suitable workarounds existImpairs non-critical functionality or suitable workarounds existT-Defect