Fix branch matching on CI

[germain-gg]

This project is split across 4 layers (element-desktop, element-web, matrix-react-sdk, matrix-js-sdk). Sometimes changes are dependant on each other, meaning that a pull request on the React layer might require an update on the JS SDK. In order to not delay things artificially and wait for stuff to land on develop, branch matching has been introduced.

This process is driven by scripts/fetchdep.sh

If I open a PR on element-web with a base branch called my-branch-1.

• The CI should check whether there's a branch called my-branch-1 on the React layer, if not fall back to using develop
• The CI should check whether there's a branch called my-branch-1 on the JS SDK layer, if not fall back to using develop

Cases to take into consideration

• Works when CI runs on BuildKite
• Works when CI runs on GitHub Actions
• Works when the base branch is on a fork

[SimonBrandner]

What makes you think this is broken? It worked fine for me the last time

[germain-gg]

I have many of my branches recently that had failed tests
A recent example of that would be matrix-org/matrix-react-sdk#6949

[SimonBrandner]

I have many of my branches recently that had failed tests A recent example of that would be matrix-org/matrix-react-sdk#6949

Ah, thanks. From a quick look, the issue seems to be with BuildKite, it looks like GA are cloning the correct branch

[SimonBrandner]

I can't remember any changes in the area that could cause this 🤔 Am I missing something?

[germain-gg]

I don't think it has changed recently, but it could also be the case that it's been broken for a little while and we have not tracked the issue down

[SimonBrandner]

but it could also be the case that it's been broken for a little while and we have not tracked the issue down

It worked for me last week though that was a fork 🤷‍♂️

[SimonBrandner]

@gsouquet, is this still relevant since it seems to work with GHA and we're looking to get rid of BuildKite, afaik?