-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Use context provided RoomViewStore within the RoomView component hierarchy #31060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
langleyd
wants to merge
31
commits into
develop
Choose a base branch
from
langleyd/use-context-provided-room-view-store
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+289
−123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eyd/context-provided-room-view-store
Base automatically changed from
langleyd/context-provided-room-view-store
to
develop
October 23, 2025 09:19
b7539c3
to
7354e76
Compare
…eyd/use-context-provided-room-view-store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #30980
What's in this PR?
This PR builds upon #30980 updating usages of RoomViewStore within the RoomView sub components to use the instance provided by the context rather than the singleton.
Checklist
public
/exported
symbols have accurate TSDoc documentation.