Ensure that room / space avatar always have a contentDescription.

Author: bmarty

features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsView.kt

@@ -404,7 +404,7 @@ private fun RoomHeaderSection(
                 }.toImmutableList(),
                 isTombstoned = isTombstoned,
             ),
-            contentDescription = avatarUrl?.let { stringResource(CommonStrings.a11y_room_avatar) },
+            contentDescription = stringResource(CommonStrings.a11y_room_avatar),
             modifier = Modifier
                 .clickable(
                     enabled = avatarUrl != null,

features/space/impl/src/main/kotlin/io/element/android/features/space/impl/settings/SpaceSettingsView.kt

@@ -115,7 +115,7 @@ private fun SpaceInfoSection(
         Avatar(
             avatarData = AvatarData(roomId.value, name, avatarUrl, AvatarSize.SpaceListItem),
             avatarType = AvatarType.Space(),
-            contentDescription = avatarUrl?.let { stringResource(CommonStrings.a11y_avatar) },
+            contentDescription = stringResource(CommonStrings.a11y_avatar),
         )
         Spacer(Modifier.width(16.dp))
         Column {

features/userprofile/shared/src/main/kotlin/io/element/android/features/userprofile/shared/UserProfileHeaderSection.kt

@@ -66,7 +66,7 @@ fun UserProfileHeaderSection(
         Avatar(
             avatarData = AvatarData(userId.value, userName, avatarUrl, AvatarSize.UserHeader),
             avatarType = AvatarType.User,
-            contentDescription = avatarUrl?.let { stringResource(CommonStrings.a11y_user_avatar) },
+            contentDescription = stringResource(CommonStrings.a11y_user_avatar),
             modifier = Modifier
                 .clip(CircleShape)
                 .clickable(

libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/avatar/DmAvatars.kt

@@ -59,7 +59,7 @@ fun DmAvatars(
         Avatar(
             avatarData = userAvatarData,
             avatarType = AvatarType.User,
-            contentDescription = userAvatarData.url?.let { stringResource(CommonStrings.a11y_your_avatar) },
+            contentDescription = stringResource(CommonStrings.a11y_your_avatar),
             modifier = Modifier
                 .align(Alignment.BottomStart)
                 .graphicsLayer {
@@ -94,7 +94,7 @@ fun DmAvatars(
         Avatar(
             avatarData = otherUserAvatarData,
             avatarType = AvatarType.User,
-            contentDescription = otherUserAvatarData.url?.let { stringResource(CommonStrings.a11y_other_user_avatar) },
+            contentDescription = stringResource(CommonStrings.a11y_other_user_avatar),
             modifier = Modifier
                 .align(Alignment.TopEnd)
                 .clip(CircleShape)