Rename Developer -> ViewSource

bmarty · bmarty · commit 0424192834d7 · 2023-09-14T19:48:20.000+02:00
diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesPresenter.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesPresenter.kt
@@ -213,7 +213,7 @@ class MessagesPresenter @AssistedInject constructor(
             TimelineItemAction.Edit -> handleActionEdit(targetEvent, composerState, enableTextFormatting)
             TimelineItemAction.Reply,
             TimelineItemAction.ReplyInThread -> handleActionReply(targetEvent, composerState)
-            TimelineItemAction.Developer -> handleShowDebugInfoAction(targetEvent)
+            TimelineItemAction.ViewSource -> handleShowDebugInfoAction(targetEvent)
             TimelineItemAction.Forward -> handleForwardAction(targetEvent)
             TimelineItemAction.ReportContent -> handleReportAction(targetEvent)
             TimelineItemAction.EndPoll -> handleEndPollAction(targetEvent)
diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListPresenter.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListPresenter.kt
@@ -86,7 +86,7 @@ class ActionListPresenter @Inject constructor(
             when (timelineItem.content) {
                 is TimelineItemRedactedContent -> {
                     if (buildMeta.isDebuggable) {
-                        listOf(TimelineItemAction.Developer)
+                        listOf(TimelineItemAction.ViewSource)
                     } else {
                         emptyList()
                     }
@@ -95,7 +95,7 @@ class ActionListPresenter @Inject constructor(
                     buildList {
                         add(TimelineItemAction.Copy)
                         if (buildMeta.isDebuggable) {
-                            add(TimelineItemAction.Developer)
+                            add(TimelineItemAction.ViewSource)
                         }
                     }
                 }
@@ -116,7 +116,7 @@ class ActionListPresenter @Inject constructor(
                             add(TimelineItemAction.Copy)
                         }
                         if (buildMeta.isDebuggable) {
-                            add(TimelineItemAction.Developer)
+                            add(TimelineItemAction.ViewSource)
                         }
                         if (!timelineItem.isMine) {
                             add(TimelineItemAction.ReportContent)
@@ -145,7 +145,7 @@ class ActionListPresenter @Inject constructor(
                         add(TimelineItemAction.Copy)
                     }
                     if (buildMeta.isDebuggable) {
-                        add(TimelineItemAction.Developer)
+                        add(TimelineItemAction.ViewSource)
                     }
                     if (!timelineItem.isMine) {
                         add(TimelineItemAction.ReportContent)
diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListStateProvider.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListStateProvider.kt
@@ -111,15 +111,15 @@ fun aTimelineItemActionList(): ImmutableList<TimelineItemAction> {
         TimelineItemAction.Edit,
         TimelineItemAction.Redact,
         TimelineItemAction.ReportContent,
-        TimelineItemAction.Developer,
+        TimelineItemAction.ViewSource,
     )
 }
 fun aTimelineItemPollActionList(): ImmutableList<TimelineItemAction> {
     return persistentListOf(
         TimelineItemAction.EndPoll,
         TimelineItemAction.Reply,
         TimelineItemAction.Copy,
-        TimelineItemAction.Developer,
+        TimelineItemAction.ViewSource,
         TimelineItemAction.ReportContent,
         TimelineItemAction.Redact,
     )
diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/model/TimelineItemAction.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/model/TimelineItemAction.kt
@@ -34,7 +34,7 @@ sealed class TimelineItemAction(
     data object Reply : TimelineItemAction(CommonStrings.action_reply, VectorIcons.Reply)
     data object ReplyInThread : TimelineItemAction(CommonStrings.action_reply_in_thread, VectorIcons.Reply)
     data object Edit : TimelineItemAction(CommonStrings.action_edit, VectorIcons.Edit)
-    data object Developer : TimelineItemAction(CommonStrings.action_view_source, VectorIcons.DeveloperMode)
+    data object ViewSource : TimelineItemAction(CommonStrings.action_view_source, VectorIcons.DeveloperMode)
     data object ReportContent : TimelineItemAction(CommonStrings.action_report_content, VectorIcons.ReportContent, destructive = true)
     data object EndPoll : TimelineItemAction(CommonStrings.action_end_poll, VectorIcons.PollEnd)
 }
diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/MessagesPresenterTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/MessagesPresenterTest.kt
@@ -365,7 +365,7 @@ class MessagesPresenterTest {
             presenter.present()
         }.test {
             val initialState = awaitItem()
-            initialState.eventSink.invoke(MessagesEvents.HandleAction(TimelineItemAction.Developer, aMessageEvent()))
+            initialState.eventSink.invoke(MessagesEvents.HandleAction(TimelineItemAction.ViewSource, aMessageEvent()))
             assertThat(awaitItem().actionListState.target).isEqualTo(ActionListState.Target.None)
             assertThat(navigator.onShowEventDebugInfoClickedCount).isEqualTo(1)
         }
diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/actionlist/ActionListPresenterTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/actionlist/ActionListPresenterTest.kt
@@ -71,7 +71,7 @@ class ActionListPresenterTest {
                 ActionListState.Target.Success(
                     messageEvent,
                     persistentListOf(
-                        TimelineItemAction.Developer,
+                        TimelineItemAction.ViewSource,
                     )
                 )
             )
@@ -96,7 +96,7 @@ class ActionListPresenterTest {
                 ActionListState.Target.Success(
                     messageEvent,
                     persistentListOf(
-                        TimelineItemAction.Developer,
+                        TimelineItemAction.ViewSource,
                     )
                 )
             )
@@ -127,7 +127,7 @@ class ActionListPresenterTest {
                         TimelineItemAction.Reply,
                         TimelineItemAction.Forward,
                         TimelineItemAction.Copy,
-                        TimelineItemAction.Developer,
+                        TimelineItemAction.ViewSource,
                         TimelineItemAction.ReportContent,
                     )
                 )
@@ -158,7 +158,7 @@ class ActionListPresenterTest {
                     persistentListOf(
                         TimelineItemAction.Forward,
                         TimelineItemAction.Copy,
-                        TimelineItemAction.Developer,
+                        TimelineItemAction.ViewSource,
                         TimelineItemAction.ReportContent,
                     )
                 )
@@ -188,7 +188,7 @@ class ActionListPresenterTest {
                         TimelineItemAction.Reply,
                         TimelineItemAction.Forward,
                         TimelineItemAction.Copy,
-                        TimelineItemAction.Developer,
+                        TimelineItemAction.ViewSource,
                         TimelineItemAction.ReportContent,
                         TimelineItemAction.Redact,
                     )
@@ -222,7 +222,7 @@ class ActionListPresenterTest {
                         TimelineItemAction.Forward,
                         TimelineItemAction.Edit,
                         TimelineItemAction.Copy,
-                        TimelineItemAction.Developer,
+                        TimelineItemAction.ViewSource,
                         TimelineItemAction.Redact,
                     )
                 )
@@ -253,7 +253,7 @@ class ActionListPresenterTest {
                     persistentListOf(
                         TimelineItemAction.Reply,
                         TimelineItemAction.Forward,
-                        TimelineItemAction.Developer,
+                        TimelineItemAction.ViewSource,
                         TimelineItemAction.Redact,
                     )
                 )
@@ -283,7 +283,7 @@ class ActionListPresenterTest {
                     stateEvent,
                     persistentListOf(
                         TimelineItemAction.Copy,
-                        TimelineItemAction.Developer,
+                        TimelineItemAction.ViewSource,
                     )
                 )
             )

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ class ActionListPresenter @Inject constructor(`
`86`	`86`	`when (timelineItem.content) {`
`87`	`87`	`is TimelineItemRedactedContent -> {`
`88`	`88`	`if (buildMeta.isDebuggable) {`
`89`		`- listOf(TimelineItemAction.Developer)`
	`89`	`+ listOf(TimelineItemAction.ViewSource)`
`90`	`90`	`} else {`
`91`	`91`	`emptyList()`
`92`	`92`	`}`
`@@ -95,7 +95,7 @@ class ActionListPresenter @Inject constructor(`
`95`	`95`	`buildList {`
`96`	`96`	`add(TimelineItemAction.Copy)`
`97`	`97`	`if (buildMeta.isDebuggable) {`
`98`		`- add(TimelineItemAction.Developer)`
	`98`	`+ add(TimelineItemAction.ViewSource)`
`99`	`99`	`}`
`100`	`100`	`}`
`101`	`101`	`}`
`@@ -116,7 +116,7 @@ class ActionListPresenter @Inject constructor(`
`116`	`116`	`add(TimelineItemAction.Copy)`
`117`	`117`	`}`
`118`	`118`	`if (buildMeta.isDebuggable) {`
`119`		`- add(TimelineItemAction.Developer)`
	`119`	`+ add(TimelineItemAction.ViewSource)`
`120`	`120`	`}`
`121`	`121`	`if (!timelineItem.isMine) {`
`122`	`122`	`add(TimelineItemAction.ReportContent)`
`@@ -145,7 +145,7 @@ class ActionListPresenter @Inject constructor(`
`145`	`145`	`add(TimelineItemAction.Copy)`
`146`	`146`	`}`
`147`	`147`	`if (buildMeta.isDebuggable) {`
`148`		`- add(TimelineItemAction.Developer)`
	`148`	`+ add(TimelineItemAction.ViewSource)`
`149`	`149`	`}`
`150`	`150`	`if (!timelineItem.isMine) {`
`151`	`151`	`add(TimelineItemAction.ReportContent)`
Original file line number	Diff line number	Diff line change
`@@ -111,15 +111,15 @@ fun aTimelineItemActionList(): ImmutableList<TimelineItemAction> {`
`111`	`111`	`TimelineItemAction.Edit,`
`112`	`112`	`TimelineItemAction.Redact,`
`113`	`113`	`TimelineItemAction.ReportContent,`
`114`		`- TimelineItemAction.Developer,`
	`114`	`+ TimelineItemAction.ViewSource,`
`115`	`115`	`)`
`116`	`116`	`}`
`117`	`117`	`fun aTimelineItemPollActionList(): ImmutableList<TimelineItemAction> {`
`118`	`118`	`return persistentListOf(`
`119`	`119`	`TimelineItemAction.EndPoll,`
`120`	`120`	`TimelineItemAction.Reply,`
`121`	`121`	`TimelineItemAction.Copy,`
`122`		`- TimelineItemAction.Developer,`
	`122`	`+ TimelineItemAction.ViewSource,`
`123`	`123`	`TimelineItemAction.ReportContent,`
`124`	`124`	`TimelineItemAction.Redact,`
`125`	`125`	`)`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ sealed class TimelineItemAction(`
`34`	`34`	`data object Reply : TimelineItemAction(CommonStrings.action_reply, VectorIcons.Reply)`
`35`	`35`	`data object ReplyInThread : TimelineItemAction(CommonStrings.action_reply_in_thread, VectorIcons.Reply)`
`36`	`36`	`data object Edit : TimelineItemAction(CommonStrings.action_edit, VectorIcons.Edit)`
`37`		`- data object Developer : TimelineItemAction(CommonStrings.action_view_source, VectorIcons.DeveloperMode)`
	`37`	`+ data object ViewSource : TimelineItemAction(CommonStrings.action_view_source, VectorIcons.DeveloperMode)`
`38`	`38`	`data object ReportContent : TimelineItemAction(CommonStrings.action_report_content, VectorIcons.ReportContent, destructive = true)`
`39`	`39`	`data object EndPoll : TimelineItemAction(CommonStrings.action_end_poll, VectorIcons.PollEnd)`
`40`	`40`	`}`
Original file line number	Diff line number	Diff line change
`@@ -365,7 +365,7 @@ class MessagesPresenterTest {`
`365`	`365`	`presenter.present()`
`366`	`366`	`}.test {`
`367`	`367`	`val initialState = awaitItem()`
`368`		`- initialState.eventSink.invoke(MessagesEvents.HandleAction(TimelineItemAction.Developer, aMessageEvent()))`
	`368`	`+ initialState.eventSink.invoke(MessagesEvents.HandleAction(TimelineItemAction.ViewSource, aMessageEvent()))`
`369`	`369`	`assertThat(awaitItem().actionListState.target).isEqualTo(ActionListState.Target.None)`
`370`	`370`	`assertThat(navigator.onShowEventDebugInfoClickedCount).isEqualTo(1)`
`371`	`371`	`}`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ class ActionListPresenterTest {`
`71`	`71`	`ActionListState.Target.Success(`
`72`	`72`	`messageEvent,`
`73`	`73`	`persistentListOf(`
`74`		`- TimelineItemAction.Developer,`
	`74`	`+ TimelineItemAction.ViewSource,`
`75`	`75`	`)`
`76`	`76`	`)`
`77`	`77`	`)`
`@@ -96,7 +96,7 @@ class ActionListPresenterTest {`
`96`	`96`	`ActionListState.Target.Success(`
`97`	`97`	`messageEvent,`
`98`	`98`	`persistentListOf(`
`99`		`- TimelineItemAction.Developer,`
	`99`	`+ TimelineItemAction.ViewSource,`
`100`	`100`	`)`
`101`	`101`	`)`
`102`	`102`	`)`
`@@ -127,7 +127,7 @@ class ActionListPresenterTest {`
`127`	`127`	`TimelineItemAction.Reply,`
`128`	`128`	`TimelineItemAction.Forward,`
`129`	`129`	`TimelineItemAction.Copy,`
`130`		`- TimelineItemAction.Developer,`
	`130`	`+ TimelineItemAction.ViewSource,`
`131`	`131`	`TimelineItemAction.ReportContent,`
`132`	`132`	`)`
`133`	`133`	`)`
`@@ -158,7 +158,7 @@ class ActionListPresenterTest {`
`158`	`158`	`persistentListOf(`
`159`	`159`	`TimelineItemAction.Forward,`
`160`	`160`	`TimelineItemAction.Copy,`
`161`		`- TimelineItemAction.Developer,`
	`161`	`+ TimelineItemAction.ViewSource,`
`162`	`162`	`TimelineItemAction.ReportContent,`
`163`	`163`	`)`
`164`	`164`	`)`
`@@ -188,7 +188,7 @@ class ActionListPresenterTest {`
`188`	`188`	`TimelineItemAction.Reply,`
`189`	`189`	`TimelineItemAction.Forward,`
`190`	`190`	`TimelineItemAction.Copy,`
`191`		`- TimelineItemAction.Developer,`
	`191`	`+ TimelineItemAction.ViewSource,`
`192`	`192`	`TimelineItemAction.ReportContent,`
`193`	`193`	`TimelineItemAction.Redact,`
`194`	`194`	`)`
`@@ -222,7 +222,7 @@ class ActionListPresenterTest {`
`222`	`222`	`TimelineItemAction.Forward,`
`223`	`223`	`TimelineItemAction.Edit,`
`224`	`224`	`TimelineItemAction.Copy,`
`225`		`- TimelineItemAction.Developer,`
	`225`	`+ TimelineItemAction.ViewSource,`
`226`	`226`	`TimelineItemAction.Redact,`
`227`	`227`	`)`
`228`	`228`	`)`
`@@ -253,7 +253,7 @@ class ActionListPresenterTest {`
`253`	`253`	`persistentListOf(`
`254`	`254`	`TimelineItemAction.Reply,`
`255`	`255`	`TimelineItemAction.Forward,`
`256`		`- TimelineItemAction.Developer,`
	`256`	`+ TimelineItemAction.ViewSource,`
`257`	`257`	`TimelineItemAction.Redact,`
`258`	`258`	`)`
`259`	`259`	`)`
`@@ -283,7 +283,7 @@ class ActionListPresenterTest {`
`283`	`283`	`stateEvent,`
`284`	`284`	`persistentListOf(`
`285`	`285`	`TimelineItemAction.Copy,`
`286`		`- TimelineItemAction.Developer,`
	`286`	`+ TimelineItemAction.ViewSource,`
`287`	`287`	`)`
`288`	`288`	`)`
`289`	`289`	`)`