Skip to content

Commit 05a6a3b

Browse files
authored
Merge pull request #3604 from element-hq/feature/bma/fixBuildWithLocalSdk
Fix building the app using a local SDK.
2 parents 8021261 + 1e91e8b commit 05a6a3b

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

app/build.gradle.kts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,8 +275,6 @@ dependencies {
275275
implementation(libs.serialization.json)
276276

277277
implementation(libs.matrix.emojibase.bindings)
278-
// Needed for UtdTracker
279-
implementation(libs.matrix.sdk)
280278

281279
testImplementation(libs.test.junit)
282280
testImplementation(libs.test.robolectric)

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/RustMatrixClientFactory.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import io.element.android.libraries.matrix.impl.util.anonymizedTokens
2121
import io.element.android.libraries.network.useragent.UserAgentProvider
2222
import io.element.android.libraries.sessionstorage.api.SessionData
2323
import io.element.android.libraries.sessionstorage.api.SessionStore
24+
import io.element.android.services.analytics.api.AnalyticsService
2425
import io.element.android.services.toolbox.api.systemclock.SystemClock
2526
import kotlinx.coroutines.CoroutineScope
2627
import kotlinx.coroutines.withContext
@@ -44,7 +45,7 @@ class RustMatrixClientFactory @Inject constructor(
4445
private val userCertificatesProvider: UserCertificatesProvider,
4546
private val proxyProvider: ProxyProvider,
4647
private val clock: SystemClock,
47-
private val utdTracker: UtdTracker,
48+
private val analyticsService: AnalyticsService,
4849
private val featureFlagService: FeatureFlagService,
4950
private val timelineEventTypeFilterFactory: TimelineEventTypeFilterFactory,
5051
private val clientBuilderProvider: ClientBuilderProvider,
@@ -64,7 +65,7 @@ class RustMatrixClientFactory @Inject constructor(
6465
client.restoreSession(sessionData.toSession())
6566

6667
val syncService = client.syncService()
67-
.withUtdHook(utdTracker)
68+
.withUtdHook(UtdTracker(analyticsService))
6869
.finish()
6970

7071
val (anonymizedAccessToken, anonymizedRefreshToken) = sessionData.anonymizedTokens()

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/analytics/UtdTracker.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,8 @@ import org.matrix.rustcomponents.sdk.UnableToDecryptDelegate
1313
import org.matrix.rustcomponents.sdk.UnableToDecryptInfo
1414
import timber.log.Timber
1515
import uniffi.matrix_sdk_crypto.UtdCause
16-
import javax.inject.Inject
1716

18-
class UtdTracker @Inject constructor(
17+
class UtdTracker(
1918
private val analyticsService: AnalyticsService,
2019
) : UnableToDecryptDelegate {
2120
override fun onUtd(info: UnableToDecryptInfo) {

samples/minimal/src/main/kotlin/io/element/android/samples/minimal/MainActivity.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import io.element.android.compound.theme.ElementTheme
2121
import io.element.android.libraries.matrix.api.auth.MatrixAuthenticationService
2222
import io.element.android.libraries.matrix.impl.RustClientBuilderProvider
2323
import io.element.android.libraries.matrix.impl.RustMatrixClientFactory
24-
import io.element.android.libraries.matrix.impl.analytics.UtdTracker
2524
import io.element.android.libraries.matrix.impl.auth.OidcConfigurationProvider
2625
import io.element.android.libraries.matrix.impl.auth.RustMatrixAuthenticationService
2726
import io.element.android.libraries.matrix.impl.paths.SessionPathsFactory
@@ -56,7 +55,7 @@ class MainActivity : ComponentActivity() {
5655
userCertificatesProvider = userCertificatesProvider,
5756
proxyProvider = proxyProvider,
5857
clock = DefaultSystemClock(),
59-
utdTracker = UtdTracker(NoopAnalyticsService()),
58+
analyticsService = NoopAnalyticsService(),
6059
featureFlagService = AlwaysEnabledFeatureFlagService(),
6160
timelineEventTypeFilterFactory = RustTimelineEventTypeFilterFactory(),
6261
clientBuilderProvider = RustClientBuilderProvider(),

0 commit comments

Comments
 (0)