Update voice message recording button behaviour (#1784)

Changes recording button behaviour so that
- tapping the record button starts a recording and displays the stop button
- tapping the stop button stops the recording
- tapping the delete button cancels the recording
- 'hold to record' tooltip is removed


---------

Co-authored-by: ElementBot <[email protected]>

Author: jonnyandrew

changelog.d/1784.feature

@@ -0,0 +1 @@
+Update voice message recording behaviour. Instead of holding the record button, users can now tap the record button to start recording and tap again to stop recording.

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/MessageComposerView.kt

@@ -32,7 +32,7 @@ import io.element.android.libraries.designsystem.preview.ElementPreview
 import io.element.android.libraries.designsystem.preview.PreviewsDayNight
 import io.element.android.libraries.textcomposer.TextComposer
 import io.element.android.libraries.textcomposer.model.Message
-import io.element.android.libraries.textcomposer.model.PressEvent
+import io.element.android.libraries.textcomposer.model.VoiceMessageRecorderEvent
 import io.element.android.libraries.textcomposer.model.Suggestion
 import io.element.android.libraries.textcomposer.model.VoiceMessagePlayerEvent
 import kotlinx.coroutines.launch
@@ -77,8 +77,8 @@ internal fun MessageComposerView(
         }
     }
 
-    val onVoiceRecordButtonEvent = { press: PressEvent ->
-        voiceMessageState.eventSink(VoiceMessageComposerEvents.RecordButtonEvent(press))
+    val onVoiceRecorderEvent = { press: VoiceMessageRecorderEvent ->
+        voiceMessageState.eventSink(VoiceMessageComposerEvents.RecorderEvent(press))
     }
 
     val onSendVoiceMessage = {
@@ -107,7 +107,7 @@ internal fun MessageComposerView(
         onDismissTextFormatting = ::onDismissTextFormatting,
         enableTextFormatting = enableTextFormatting,
         enableVoiceMessages = enableVoiceMessages,
-        onVoiceRecordButtonEvent = onVoiceRecordButtonEvent,
+        onVoiceRecorderEvent = onVoiceRecorderEvent,
         onVoicePlayerEvent = onVoicePlayerEvent,
         onSendVoiceMessage = onSendVoiceMessage,
         onDeleteVoiceMessage = onDeleteVoiceMessage,

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/voicemessages/composer/VoiceMessageComposerEvents.kt

@@ -17,12 +17,12 @@
 package io.element.android.features.messages.impl.voicemessages.composer
 
 import androidx.lifecycle.Lifecycle
-import io.element.android.libraries.textcomposer.model.PressEvent
+import io.element.android.libraries.textcomposer.model.VoiceMessageRecorderEvent
 import io.element.android.libraries.textcomposer.model.VoiceMessagePlayerEvent
 
 sealed interface VoiceMessageComposerEvents {
-    data class RecordButtonEvent(
-        val pressEvent: PressEvent
+    data class RecorderEvent(
+        val recorderEvent: VoiceMessageRecorderEvent
     ): VoiceMessageComposerEvents
     data class PlayerEvent(
         val playerEvent: VoiceMessagePlayerEvent,

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/voicemessages/composer/VoiceMessageComposerPresenter.kt

@@ -37,7 +37,7 @@ import io.element.android.libraries.di.SingleIn
 import io.element.android.libraries.mediaupload.api.MediaSender
 import io.element.android.libraries.permissions.api.PermissionsEvents
 import io.element.android.libraries.permissions.api.PermissionsPresenter
-import io.element.android.libraries.textcomposer.model.PressEvent
+import io.element.android.libraries.textcomposer.model.VoiceMessageRecorderEvent
 import io.element.android.libraries.textcomposer.model.VoiceMessagePlayerEvent
 import io.element.android.libraries.textcomposer.model.VoiceMessageState
 import io.element.android.libraries.voicerecorder.api.VoiceRecorder
@@ -95,10 +95,10 @@ class VoiceMessageComposerPresenter @Inject constructor(
             }
         }
 
-        val onRecordButtonPress = { event: VoiceMessageComposerEvents.RecordButtonEvent ->
+        val onVoiceMessageRecorderEvent = { event: VoiceMessageComposerEvents.RecorderEvent ->
             val permissionGranted = permissionState.permissionGranted
-            when (event.pressEvent) {
-                PressEvent.PressStart -> {
+            when (event.recorderEvent) {
+                VoiceMessageRecorderEvent.Start -> {
                     Timber.v("Voice message record button pressed")
                     when {
                         permissionGranted -> {
@@ -110,12 +110,12 @@ class VoiceMessageComposerPresenter @Inject constructor(
                         }
                     }
                 }
-                PressEvent.LongPressEnd -> {
-                    Timber.v("Voice message record button released")
+                VoiceMessageRecorderEvent.Stop -> {
+                    Timber.v("Voice message stop button pressed")
                     localCoroutineScope.finishRecording()
                 }
-                PressEvent.Tapped -> {
-                    Timber.v("Voice message record button tapped")
+                VoiceMessageRecorderEvent.Cancel -> {
+                    Timber.v("Voice message cancel button tapped")
                     localCoroutineScope.cancelRecording()
                 }
             }
@@ -163,7 +163,7 @@ class VoiceMessageComposerPresenter @Inject constructor(
 
         val handleEvents: (VoiceMessageComposerEvents) -> Unit = { event ->
             when (event) {
-                is VoiceMessageComposerEvents.RecordButtonEvent -> onRecordButtonPress(event)
+                is VoiceMessageComposerEvents.RecorderEvent -> onVoiceMessageRecorderEvent(event)
                 is VoiceMessageComposerEvents.PlayerEvent -> onPlayerEvent(event.playerEvent)
                 is VoiceMessageComposerEvents.SendVoiceMessage -> localCoroutineScope.launch {
                     onSendButtonPress()