Make sure any JoinedRustRoom is destroyed after use (#4678)

Author: jmartinesp

features/call/impl/src/main/kotlin/io/element/android/features/call/impl/ui/CallScreenPresenter.kt

@@ -241,7 +241,7 @@ class CallScreenPresenter @AssistedInject constructor(
 
     private suspend fun MatrixClient.notifyCallStartIfNeeded(roomId: RoomId) {
         if (!notifiedCallStart) {
-            getJoinedRoom(roomId)?.sendCallNotificationIfNeeded()
+            getJoinedRoom(roomId)?.use { it.sendCallNotificationIfNeeded() }
                 ?.onSuccess { notifiedCallStart = true }
         }
     }

features/call/impl/src/main/kotlin/io/element/android/features/call/impl/utils/DefaultCallWidgetProvider.kt

@@ -47,8 +47,11 @@ class DefaultCallWidgetProvider @Inject constructor(
             theme = theme,
         ).getOrThrow()
 
+        val driver = room.getWidgetDriver(widgetSettings).getOrThrow()
+        room.destroy()
+
         CallWidgetProvider.GetWidgetResult(
-            driver = room.getWidgetDriver(widgetSettings).getOrThrow(),
+            driver = driver,
             url = callUrl,
         )
     }

features/share/impl/src/main/kotlin/io/element/android/features/share/impl/SharePresenter.kt

@@ -86,6 +86,7 @@ class SharePresenter @AssistedInject constructor(
                                         ).isSuccess
                                     }
                                     .all { it }
+                                    .also { room.destroy() }
                             }
                             .all { it }
                     }

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/JoinedRustRoom.kt

@@ -639,9 +639,11 @@ class JoinedRustRoom(
         }
     }
 
+    override fun close() = destroy()
+
     override fun destroy() {
         baseRoom.destroy()
-        liveInnerTimeline.close()
+        liveInnerTimeline.destroy()
         roomCoroutineScope.cancel()
     }
 

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustBaseRoom.kt

@@ -94,6 +94,8 @@ class RustBaseRoom(
         }
     }
 
+    override fun close() = destroy()
+
     override fun destroy() {
         innerRoom.destroy()
     }