Code quality

Author: bmarty

appnav/src/main/kotlin/io/element/android/appnav/RootFlowNode.kt

@@ -293,7 +293,7 @@ class RootFlowNode(
             }
             is NavTarget.AccountSelect -> {
                 val callback: AccountSelectEntryPoint.Callback = object : AccountSelectEntryPoint.Callback {
-                    override fun onAccountSelected(sessionId: SessionId) {
+                    override fun onSelectAccount(sessionId: SessionId) {
                         lifecycleScope.launch {
                             if (sessionId == navTarget.currentSessionId) {
                                 // Ensure that the account selection Node is removed from the backstack

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/root/PreferencesRootView.kt

@@ -359,4 +359,3 @@ internal fun MultiAccountSectionPreview() = ElementPreview {
         )
     }
 }
-

features/signedout/impl/src/main/kotlin/io/element/android/features/signedout/impl/SignedOutStateProvider.kt

@@ -10,7 +10,6 @@ package io.element.android.features.signedout.impl
 import androidx.compose.ui.tooling.preview.PreviewParameterProvider
 import io.element.android.libraries.sessionstorage.api.LoginType
 import io.element.android.libraries.sessionstorage.api.SessionData
-import java.util.Date
 
 open class SignedOutStateProvider : PreviewParameterProvider<SignedOutState> {
     override val values: Sequence<SignedOutState>

libraries/accountselect/api/src/main/kotlin/io/element/android/libraries/accountselect/api/AccountSelectEntryPoint.kt

@@ -22,7 +22,7 @@ interface AccountSelectEntryPoint : FeatureEntryPoint {
     }
 
     interface Callback : Plugin {
-        fun onAccountSelected(sessionId: SessionId)
+        fun onSelectAccount(sessionId: SessionId)
         fun onCancel()
     }
 }

libraries/accountselect/impl/src/main/kotlin/io/element/android/libraries/accountselect/impl/AccountSelectNode.kt

@@ -31,8 +31,8 @@ class AccountSelectNode @AssistedInject constructor(
         callbacks.forEach { it.onCancel() }
     }
 
-    private fun onAccountSelected(sessionId: SessionId) {
-        callbacks.forEach { it.onAccountSelected(sessionId) }
+    private fun onSelectAccount(sessionId: SessionId) {
+        callbacks.forEach { it.onSelectAccount(sessionId) }
     }
 
     @Composable
@@ -41,7 +41,7 @@ class AccountSelectNode @AssistedInject constructor(
         AccountSelectView(
             state = state,
             onDismiss = ::onDismiss,
-            onAccountSelected = ::onAccountSelected,
+            onSelectAccount = ::onSelectAccount,
             modifier = modifier,
         )
     }

libraries/accountselect/impl/src/main/kotlin/io/element/android/libraries/accountselect/impl/AccountSelectView.kt

@@ -34,7 +34,7 @@ import io.element.android.libraries.matrix.ui.components.MatrixUserRow
 @Composable
 fun AccountSelectView(
     state: AccountSelectState,
-    onAccountSelected: (SessionId) -> Unit,
+    onSelectAccount: (SessionId) -> Unit,
     onDismiss: () -> Unit,
     modifier: Modifier = Modifier,
 ) {
@@ -63,7 +63,7 @@ fun AccountSelectView(
                             modifier = Modifier
                                 .fillMaxWidth()
                                 .clickable {
-                                    onAccountSelected(matrixUser.userId)
+                                    onSelectAccount(matrixUser.userId)
                                 }
                                 .padding(vertical = 8.dp),
                             matrixUser = matrixUser,
@@ -81,7 +81,7 @@ fun AccountSelectView(
 internal fun AccountSelectViewPreview(@PreviewParameter(AccountSelectStateProvider::class) state: AccountSelectState) = ElementPreview {
     AccountSelectView(
         state = state,
-        onAccountSelected = {},
+        onSelectAccount = {},
         onDismiss = {},
     )
 }

libraries/session-storage/api/src/main/kotlin/io/element/android/libraries/sessionstorage/api/SessionData.kt

@@ -39,7 +39,7 @@ data class SessionData(
     val sessionPath: String,
     /** The path to the cache data stored for the session in the filesystem. */
     val cachePath: String,
-    /** The position, to be able to order account */
+    /** The position, to be able to order account. */
     val position: Long,
     /** The index of the last date of session usage. */
     val lastUsageIndex: Long,

libraries/session-storage/impl/src/main/kotlin/io/element/android/libraries/sessionstorage/impl/DatabaseSessionStore.kt

@@ -133,7 +133,8 @@ class DatabaseSessionStore(
     private fun getLastUsageIndex(): Long {
         return database.sessionDataQueries.selectLatest()
             .executeAsOneOrNull()
-            ?.lastUsageIndex ?: 0L
+            ?.lastUsageIndex
+            ?: 0L
     }
 
     override suspend fun getLatestSession(): SessionData? {

libraries/troubleshoot/impl/src/main/kotlin/io/element/android/libraries/troubleshoot/impl/history/PushHistoryEvents.kt

@@ -14,6 +14,6 @@ import io.element.android.libraries.matrix.api.core.SessionId
 sealed interface PushHistoryEvents {
     data class SetShowOnlyErrors(val showOnlyErrors: Boolean) : PushHistoryEvents
     data class Reset(val requiresConfirmation: Boolean) : PushHistoryEvents
-    data class NavigateTo(val sessionId: SessionId, val roomId: RoomId, val eventId: EventId): PushHistoryEvents
+    data class NavigateTo(val sessionId: SessionId, val roomId: RoomId, val eventId: EventId) : PushHistoryEvents
     data object ClearDialog : PushHistoryEvents
 }

libraries/troubleshoot/impl/src/main/kotlin/io/element/android/libraries/troubleshoot/impl/history/PushHistoryPresenter.kt

@@ -59,7 +59,7 @@ class PushHistoryPresenter(
             }
         }.collectAsState(emptyList())
         var resetAction: AsyncAction<Unit> by remember { mutableStateOf(AsyncAction.Uninitialized) }
-        var showNotSameAccountError  by remember { mutableStateOf(false) }
+        var showNotSameAccountError by remember { mutableStateOf(false) }
 
         fun handleEvents(event: PushHistoryEvents) {
             when (event) {