Skip to content

Commit 29a97fc

Browse files
committed
Fix lint issues and restore commented out code
1 parent b76a71e commit 29a97fc

File tree

505 files changed

+865
-907
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

505 files changed

+865
-907
lines changed

app/src/main/kotlin/io/element/android/x/ElementXApplication.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ package io.element.android.x
1010
import android.app.Application
1111
import androidx.startup.AppInitializer
1212
import dev.zacsweers.metro.asContribution
13-
import dev.zacsweers.metro.createGraphFactory
1413
import io.element.android.features.cachecleaner.api.CacheCleanerInitializer
1514
import io.element.android.libraries.di.DaggerComponentOwner
1615
import io.element.android.x.di.AppComponent

app/src/main/kotlin/io/element/android/x/MainNode.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ import com.bumble.appyx.core.node.ParentNode
2121
import com.bumble.appyx.core.plugin.Plugin
2222
import io.element.android.appnav.RootFlowNode
2323
import io.element.android.libraries.architecture.createNode
24-
import io.element.android.libraries.di.annotations.ApplicationContext
2524
import io.element.android.libraries.di.DaggerComponentOwner
25+
import io.element.android.libraries.di.annotations.ApplicationContext
2626
import kotlinx.coroutines.launch
2727
import kotlinx.parcelize.Parcelize
2828

app/src/main/kotlin/io/element/android/x/di/AppBindings.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
package io.element.android.x.di
99

10+
import dev.zacsweers.metro.AppScope
1011
import dev.zacsweers.metro.ContributesTo
1112
import io.element.android.features.api.MigrationEntryPoint
1213
import io.element.android.features.enterprise.api.EnterpriseService
@@ -15,7 +16,6 @@ import io.element.android.features.lockscreen.api.LockScreenService
1516
import io.element.android.features.rageshake.api.reporter.BugReporter
1617
import io.element.android.libraries.core.meta.BuildMeta
1718
import io.element.android.libraries.designsystem.utils.snackbar.SnackbarDispatcher
18-
import dev.zacsweers.metro.AppScope
1919
import io.element.android.libraries.featureflag.api.FeatureFlagService
2020
import io.element.android.libraries.matrix.api.platform.InitPlatformService
2121
import io.element.android.libraries.matrix.api.tracing.TracingService

app/src/main/kotlin/io/element/android/x/di/AppComponent.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
package io.element.android.x.di
99

1010
import android.content.Context
11+
import dev.zacsweers.metro.AppScope
1112
import dev.zacsweers.metro.ContributesTo
1213
import dev.zacsweers.metro.GraphExtension
1314
import dev.zacsweers.metro.Provides
1415
import io.element.android.libraries.architecture.NodeFactoriesBindings
15-
import dev.zacsweers.metro.AppScope
1616
import io.element.android.libraries.di.annotations.ApplicationContext
1717

1818
@GraphExtension(AppScope::class)

app/src/main/kotlin/io/element/android/x/di/AppModule.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,11 @@ import android.content.Context
1111
import android.content.SharedPreferences
1212
import android.content.res.Resources
1313
import androidx.preference.PreferenceManager
14+
import dev.zacsweers.metro.AppScope
1415
import dev.zacsweers.metro.BindingContainer
1516
import dev.zacsweers.metro.ContributesTo
16-
import dev.zacsweers.metro.Named
1717
import dev.zacsweers.metro.Provides
18+
import dev.zacsweers.metro.SingleIn
1819
import io.element.android.appconfig.ApplicationConfig
1920
import io.element.android.features.enterprise.api.EnterpriseService
2021
import io.element.android.features.messages.impl.timeline.components.customreaction.DefaultEmojibaseProvider
@@ -24,11 +25,10 @@ import io.element.android.libraries.core.coroutine.CoroutineDispatchers
2425
import io.element.android.libraries.core.meta.BuildMeta
2526
import io.element.android.libraries.core.meta.BuildType
2627
import io.element.android.libraries.designsystem.utils.snackbar.SnackbarDispatcher
27-
import dev.zacsweers.metro.AppScope
28-
import io.element.android.libraries.di.annotations.ApplicationContext
28+
import io.element.android.libraries.di.BaseDirectory
2929
import io.element.android.libraries.di.CacheDirectory
30-
import dev.zacsweers.metro.SingleIn
3130
import io.element.android.libraries.di.annotations.AppCoroutineScope
31+
import io.element.android.libraries.di.annotations.ApplicationContext
3232
import io.element.android.x.BuildConfig
3333
import io.element.android.x.R
3434
import kotlinx.coroutines.CoroutineName
@@ -42,13 +42,13 @@ import java.io.File
4242
@ContributesTo(AppScope::class)
4343
object AppModule {
4444
@Provides
45-
@Named("baseDirectory")
45+
@BaseDirectory
4646
fun providesBaseDirectory(@ApplicationContext context: Context): File {
4747
return File(context.filesDir, "sessions")
4848
}
4949

5050
@Provides
51-
@Named("cacheDirectory")
51+
@CacheDirectory
5252
fun providesCacheDirectory(@ApplicationContext context: Context): File {
5353
return context.cacheDir
5454
}

app/src/main/kotlin/io/element/android/x/di/DefaultRoomComponentFactory.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88
package io.element.android.x.di
99

1010
import dev.zacsweers.metro.ContributesBinding
11+
import dev.zacsweers.metro.Inject
1112
import io.element.android.appnav.di.RoomComponentFactory
1213
import io.element.android.libraries.di.SessionScope
1314
import io.element.android.libraries.matrix.api.room.JoinedRoom
14-
import dev.zacsweers.metro.Inject
1515

1616
@ContributesBinding(SessionScope::class)
1717
@Inject

app/src/main/kotlin/io/element/android/x/di/RoomComponent.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import dev.zacsweers.metro.ContributesTo
1111
import dev.zacsweers.metro.GraphExtension
1212
import dev.zacsweers.metro.Provides
1313
import io.element.android.libraries.architecture.NodeFactoriesBindings
14-
import dev.zacsweers.metro.SingleIn
1514
import io.element.android.libraries.di.RoomScope
1615
import io.element.android.libraries.di.SessionScope
1716
import io.element.android.libraries.matrix.api.room.BaseRoom

app/src/main/kotlin/io/element/android/x/oidc/DefaultOidcRedirectUrlProvider.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77

88
package io.element.android.x.oidc
99

10-
import dev.zacsweers.metro.ContributesBinding
1110
import dev.zacsweers.metro.AppScope
11+
import dev.zacsweers.metro.ContributesBinding
12+
import dev.zacsweers.metro.Inject
1213
import io.element.android.libraries.matrix.api.auth.OidcRedirectUrlProvider
1314
import io.element.android.services.toolbox.api.strings.StringProvider
1415
import io.element.android.x.R
15-
import dev.zacsweers.metro.Inject
1616

1717
@ContributesBinding(AppScope::class)
1818
@Inject

appnav/src/main/kotlin/io/element/android/appnav/LoggedInAppScopeFlowNode.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,14 @@ import com.bumble.appyx.core.node.Node
2222
import com.bumble.appyx.core.node.ParentNode
2323
import com.bumble.appyx.core.plugin.Plugin
2424
import com.bumble.appyx.core.plugin.plugins
25+
import dev.zacsweers.metro.AppScope
2526
import dev.zacsweers.metro.Assisted
2627
import dev.zacsweers.metro.Inject
2728
import io.element.android.anvilannotations.ContributesNode
2829
import io.element.android.appnav.di.SessionComponentFactory
2930
import io.element.android.libraries.architecture.NodeInputs
3031
import io.element.android.libraries.architecture.createNode
3132
import io.element.android.libraries.architecture.inputs
32-
import dev.zacsweers.metro.AppScope
3333
import io.element.android.libraries.di.DaggerComponentOwner
3434
import io.element.android.libraries.matrix.api.MatrixClient
3535
import io.element.android.libraries.matrix.ui.media.ImageLoaderHolder

appnav/src/main/kotlin/io/element/android/appnav/LoggedInEventProcessor.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
package io.element.android.appnav
99

10+
import dev.zacsweers.metro.Inject
1011
import io.element.android.libraries.designsystem.utils.snackbar.SnackbarDispatcher
1112
import io.element.android.libraries.designsystem.utils.snackbar.SnackbarMessage
1213
import io.element.android.libraries.matrix.api.room.RoomMembershipObserver
@@ -18,7 +19,6 @@ import kotlinx.coroutines.flow.distinctUntilChanged
1819
import kotlinx.coroutines.flow.filter
1920
import kotlinx.coroutines.flow.launchIn
2021
import kotlinx.coroutines.flow.onEach
21-
import dev.zacsweers.metro.Inject
2222

2323
@Inject
2424
class LoggedInEventProcessor(

0 commit comments

Comments
 (0)