Skip to content

Commit 2f00a35

Browse files
authored
Merge pull request #837 from vector-im/feature/bma/rageshakeMxid
Add userId to rageshake summary
2 parents d34a780 + cc43f8a commit 2f00a35

File tree

2 files changed

+9
-13
lines changed

2 files changed

+9
-13
lines changed

features/rageshake/impl/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ dependencies {
3838
implementation(projects.libraries.architecture)
3939
implementation(projects.libraries.designsystem)
4040
implementation(projects.libraries.uiStrings)
41+
implementation(projects.libraries.sessionStorage.api)
4142
api(libs.squareup.seismic)
4243
api(projects.features.rageshake.api)
4344
implementation(libs.androidx.datastore.preferences)

features/rageshake/impl/src/main/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporter.kt

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,12 @@ import io.element.android.libraries.androidutils.file.compressFile
3232
import io.element.android.libraries.androidutils.file.safeDelete
3333
import io.element.android.libraries.core.coroutine.CoroutineDispatchers
3434
import io.element.android.libraries.core.extensions.toOnOff
35+
import io.element.android.libraries.core.meta.BuildMeta
3536
import io.element.android.libraries.core.mimetype.MimeTypes
3637
import io.element.android.libraries.di.AppScope
3738
import io.element.android.libraries.di.ApplicationContext
3839
import io.element.android.libraries.network.useragent.UserAgentProvider
40+
import io.element.android.libraries.sessionstorage.api.SessionStore
3941
import kotlinx.coroutines.flow.first
4042
import kotlinx.coroutines.withContext
4143
import okhttp3.Call
@@ -66,14 +68,14 @@ class DefaultBugReporter @Inject constructor(
6668
private val coroutineDispatchers: CoroutineDispatchers,
6769
private val okHttpClient: Provider<OkHttpClient>,
6870
private val userAgentProvider: UserAgentProvider,
71+
private val sessionStore: SessionStore,
72+
private val buildMeta: BuildMeta,
6973
/*
70-
private val activeSessionHolder: ActiveSessionHolder,
7174
private val versionProvider: VersionProvider,
7275
private val vectorPreferences: VectorPreferences,
7376
private val vectorFileLogger: VectorFileLogger,
7477
private val systemLocaleProvider: SystemLocaleProvider,
7578
private val matrix: Matrix,
76-
private val buildMeta: BuildMeta,
7779
private val processInfo: ProcessInfo,
7880
private val sdkIntProvider: BuildVersionSdkIntProvider,
7981
private val vectorLocale: VectorLocaleProvider,
@@ -198,18 +200,11 @@ class DefaultBugReporter @Inject constructor(
198200
?.let { gzippedFiles.add(it) }
199201
*/
200202

201-
var deviceId = "undefined"
202-
var userId = "undefined"
203+
val sessionData = sessionStore.getLatestSession()
204+
val deviceId = sessionData?.deviceId ?: "undefined"
205+
val userId = sessionData?.userId ?: "undefined"
203206
var olmVersion = "undefined"
204207

205-
/*
206-
activeSessionHolder.getSafeActiveSession()?.let { session ->
207-
userId = session.myUserId
208-
deviceId = session.sessionParams.deviceId ?: "undefined"
209-
olmVersion = session.cryptoService().getCryptoVersion(context, true)
210-
}
211-
*/
212-
213208
if (!mIsCancelled) {
214209
val text = when (reportType) {
215210
ReportType.BUG_REPORT -> bugDescription
@@ -274,7 +269,7 @@ class DefaultBugReporter @Inject constructor(
274269
}
275270

276271
// add some github labels
277-
// builder.addFormDataPart("label", buildMeta.versionName)
272+
builder.addFormDataPart("label", buildMeta.versionName)
278273
// builder.addFormDataPart("label", buildMeta.flavorDescription)
279274
// builder.addFormDataPart("label", buildMeta.gitBranchName)
280275

0 commit comments

Comments
 (0)