Skip to content

Commit 3001efb

Browse files
renovate[bot]jmartinespbmarty
authored
Update dependency org.matrix.rustcomponents:sdk-android to v0.2.50 (#3565)
* Adapt to changes in the SDK * Update dependency org.matrix.rustcomponents:sdk-android to v0.2.50 * Use lambda instead of overriding the `EventDebugInfoProvider` interface * Fix test proposal. We may find a better way to compare data class instance if we need to do more comparison in the future... --------- Co-authored-by: Jorge Martín <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Benoit Marty <[email protected]>
1 parent 249104b commit 3001efb

File tree

26 files changed

+216
-175
lines changed

26 files changed

+216
-175
lines changed

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/TimelineStateProvider.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ internal fun aTimelineItemEvent(
162162
groupPosition = groupPosition,
163163
localSendState = sendState,
164164
inReplyTo = inReplyTo,
165-
debugInfo = debugInfo,
165+
debugInfoProvider = { debugInfo },
166166
isThreaded = isThreaded,
167167
origin = null,
168168
messageShield = messageShield,

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/factories/event/TimelineItemEventFactory.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,9 @@ class TimelineItemEventFactory @AssistedInject constructor(
8585
localSendState = currentTimelineItem.event.localSendState,
8686
inReplyTo = currentTimelineItem.event.inReplyTo()?.map(permalinkParser = permalinkParser),
8787
isThreaded = currentTimelineItem.event.isThreaded(),
88-
debugInfo = currentTimelineItem.event.debugInfo,
88+
debugInfoProvider = currentTimelineItem.event.debugInfoProvider,
8989
origin = currentTimelineItem.event.origin,
90-
messageShield = currentTimelineItem.event.messageShield,
90+
messageShield = currentTimelineItem.event.messageShieldProvider.getShield(strict = false)
9191
)
9292
}
9393

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/model/TimelineItem.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import io.element.android.libraries.matrix.api.core.EventId
1717
import io.element.android.libraries.matrix.api.core.TransactionId
1818
import io.element.android.libraries.matrix.api.core.UniqueId
1919
import io.element.android.libraries.matrix.api.core.UserId
20-
import io.element.android.libraries.matrix.api.timeline.item.TimelineItemDebugInfo
20+
import io.element.android.libraries.matrix.api.timeline.item.event.EventDebugInfoProvider
2121
import io.element.android.libraries.matrix.api.timeline.item.event.LocalEventSendState
2222
import io.element.android.libraries.matrix.api.timeline.item.event.MessageShield
2323
import io.element.android.libraries.matrix.api.timeline.item.event.ProfileTimelineDetails
@@ -74,7 +74,7 @@ sealed interface TimelineItem {
7474
val localSendState: LocalEventSendState?,
7575
val inReplyTo: InReplyToDetails?,
7676
val isThreaded: Boolean,
77-
val debugInfo: TimelineItemDebugInfo,
77+
val debugInfoProvider: EventDebugInfoProvider,
7878
val origin: TimelineItemEventOrigin?,
7979
val messageShield: MessageShield?,
8080
) : TimelineItem {
@@ -89,6 +89,8 @@ sealed interface TimelineItem {
8989
val isSticker: Boolean = content is TimelineItemStickerContent
9090

9191
val isRemote = eventId != null
92+
93+
val debugInfo = debugInfoProvider.get()
9294
}
9395

9496
@Immutable

features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,7 @@ class MessagesPresenterTest {
493493
canUserPinUnpinResult = { Result.success(true) },
494494
)
495495

496-
val redactEventLambda = lambdaRecorder { _: EventId?, _: TransactionId?, _: String? -> Result.success(true) }
496+
val redactEventLambda = lambdaRecorder { _: EventId?, _: TransactionId?, _: String? -> Result.success(Unit) }
497497
liveTimeline.redactEventLambda = redactEventLambda
498498

499499
val presenter = createMessagesPresenter(matrixRoom = matrixRoom, coroutineDispatchers = coroutineDispatchers)

features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/fixtures/MessageEventFixtures.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ internal fun aMessageEvent(
5858
readReceiptState = TimelineItemReadReceipts(emptyList<ReadReceiptData>().toImmutableList()),
5959
localSendState = sendState,
6060
inReplyTo = inReplyTo,
61-
debugInfo = debugInfo,
61+
debugInfoProvider = { debugInfo },
6262
isThreaded = isThreaded,
6363
origin = null,
6464
messageShield = messageShield,

features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/timeline/groups/TimelineItemGrouperTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class TimelineItemGrouperTest {
4141
canBeRepliedTo = false,
4242
inReplyTo = null,
4343
isThreaded = false,
44-
debugInfo = aTimelineItemDebugInfo(),
44+
debugInfoProvider = { aTimelineItemDebugInfo() },
4545
origin = null,
4646
messageShield = null,
4747
)

features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/voicemessages/timeline/RedactedVoiceMessageManagerTest.kt

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,13 +88,15 @@ fun aRedactedMatrixTimeline(eventId: EventId) = listOf<MatrixTimelineItem>(
8888
senderProfile = ProfileTimelineDetails.Unavailable,
8989
timestamp = 9442,
9090
content = RedactedContent,
91-
debugInfo = TimelineItemDebugInfo(
92-
model = "enim",
93-
originalJson = null,
94-
latestEditedJson = null
95-
),
91+
debugInfoProvider = {
92+
TimelineItemDebugInfo(
93+
model = "enim",
94+
originalJson = null,
95+
latestEditedJson = null
96+
)
97+
},
9698
origin = null,
97-
messageShield = null,
99+
messageShieldProvider = { null },
98100
),
99101
)
100102
)

features/poll/impl/src/main/kotlin/io/element/android/features/poll/impl/data/PollRepository.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class PollRepository @Inject constructor(
5959

6060
suspend fun deletePoll(
6161
pollStartId: EventId,
62-
): Result<Boolean> =
62+
): Result<Unit> =
6363
timelineProvider
6464
.getActiveTimeline()
6565
.redactEvent(

features/poll/impl/src/test/kotlin/io/element/android/features/poll/impl/create/CreatePollPresenterTest.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ class CreatePollPresenterTest {
466466
@Test
467467
fun `delete confirms`() = runTest {
468468
val presenter = createCreatePollPresenter(mode = CreatePollMode.EditPoll(pollEventId))
469-
val redactEventLambda = lambdaRecorder { _: EventId?, _: TransactionId?, _: String? -> Result.success(true) }
469+
val redactEventLambda = lambdaRecorder { _: EventId?, _: TransactionId?, _: String? -> Result.success(Unit) }
470470
timeline.redactEventLambda = redactEventLambda
471471
moleculeFlow(RecompositionMode.Immediate) {
472472
presenter.present()
@@ -481,7 +481,7 @@ class CreatePollPresenterTest {
481481
@Test
482482
fun `delete can be cancelled`() = runTest {
483483
val presenter = createCreatePollPresenter(mode = CreatePollMode.EditPoll(pollEventId))
484-
val redactEventLambda = lambdaRecorder { _: EventId?, _: TransactionId?, _: String? -> Result.success(true) }
484+
val redactEventLambda = lambdaRecorder { _: EventId?, _: TransactionId?, _: String? -> Result.success(Unit) }
485485
timeline.redactEventLambda = redactEventLambda
486486
moleculeFlow(RecompositionMode.Immediate) {
487487
presenter.present()
@@ -499,7 +499,7 @@ class CreatePollPresenterTest {
499499
@Test
500500
fun `delete can be confirmed`() = runTest {
501501
val presenter = createCreatePollPresenter(mode = CreatePollMode.EditPoll(pollEventId))
502-
val redactEventLambda = lambdaRecorder { _: EventId?, _: TransactionId?, _: String? -> Result.success(true) }
502+
val redactEventLambda = lambdaRecorder { _: EventId?, _: TransactionId?, _: String? -> Result.success(Unit) }
503503
timeline.redactEventLambda = redactEventLambda
504504
moleculeFlow(RecompositionMode.Immediate) {
505505
presenter.present()

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ jsoup = "org.jsoup:jsoup:1.18.1"
163163
appyx_core = { module = "com.bumble.appyx:core", version.ref = "appyx" }
164164
molecule-runtime = "app.cash.molecule:molecule-runtime:2.0.0"
165165
timber = "com.jakewharton.timber:timber:5.0.1"
166-
matrix_sdk = "org.matrix.rustcomponents:sdk-android:0.2.49"
166+
matrix_sdk = "org.matrix.rustcomponents:sdk-android:0.2.50"
167167
matrix_richtexteditor = { module = "io.element.android:wysiwyg", version.ref = "wysiwyg" }
168168
matrix_richtexteditor_compose = { module = "io.element.android:wysiwyg-compose", version.ref = "wysiwyg" }
169169
sqldelight-driver-android = { module = "app.cash.sqldelight:android-driver", version.ref = "sqldelight" }

0 commit comments

Comments
 (0)