Merge pull request #4918 from element-hq/renovate/kotlin

Update kotlin

Author: bmarty

.idea/kotlinc.xml

@@ -98,6 +98,10 @@ allprojects {
 
             // Uncomment to suppress Compose Kotlin compiler compatibility warning
 //            freeCompilerArgs.addAll(listOf("-P", "plugin:androidx.compose.compiler.plugins.kotlin:suppressKotlinVersionCompatibilityCheck=true"))
+
+            // Fix compilation warning for annotations
+            // See https://youtrack.jetbrains.com/issue/KT-73255/Change-defaulting-rule-for-annotations for more details
+            freeCompilerArgs.add("-Xannotation-default-target=first-only")
         }
     }
 }

build.gradle.kts

@@ -391,7 +391,7 @@ private fun MessagesViewContent(
 
         Box {
             val scrollBehavior = PinnedMessagesBannerViewDefaults.rememberScrollBehavior(
-                pinnedMessagesCount = state.pinnedMessagesBannerState.pinnedMessagesCount(),
+                pinnedMessagesCount = (state.pinnedMessagesBannerState as? PinnedMessagesBannerState.Visible)?.pinnedMessagesCount() ?: 0,
             )
             TimelineView(
                 state = state.timelineState,

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesView.kt

@@ -10,38 +10,36 @@ package io.element.android.features.messages.impl.pinned.banner
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.Immutable
 import androidx.compose.ui.res.stringResource
-import androidx.compose.ui.text.AnnotatedString
 import io.element.android.libraries.designsystem.text.toAnnotatedString
 import io.element.android.libraries.ui.strings.CommonStrings
 
 @Immutable
 sealed interface PinnedMessagesBannerState {
     data object Hidden : PinnedMessagesBannerState
-    sealed interface Visible : PinnedMessagesBannerState
+    @Immutable
+    sealed interface Visible : PinnedMessagesBannerState {
+        fun pinnedMessagesCount() = when (this) {
+            is Loading -> expectedPinnedMessagesCount
+            is Loaded -> loadedPinnedMessagesCount
+        }
+
+        fun currentPinnedMessageIndex() = when (this) {
+            is Loading -> expectedPinnedMessagesCount - 1
+            is Loaded -> currentPinnedMessageIndex
+        }
+
+        @Composable
+        fun formattedMessage() = when (this) {
+            is Loading -> stringResource(id = CommonStrings.screen_room_pinned_banner_loading_description).toAnnotatedString()
+            is Loaded -> currentPinnedMessage.formatted
+        }
+    }
+
     data class Loading(val expectedPinnedMessagesCount: Int) : Visible
     data class Loaded(
         val currentPinnedMessage: PinnedMessagesBannerItem,
         val currentPinnedMessageIndex: Int,
         val loadedPinnedMessagesCount: Int,
         val eventSink: (PinnedMessagesBannerEvents) -> Unit
     ) : Visible
-
-    fun pinnedMessagesCount() = when (this) {
-        is Hidden -> 0
-        is Loading -> expectedPinnedMessagesCount
-        is Loaded -> loadedPinnedMessagesCount
-    }
-
-    fun currentPinnedMessageIndex() = when (this) {
-        is Hidden -> 0
-        is Loading -> expectedPinnedMessagesCount - 1
-        is Loaded -> currentPinnedMessageIndex
-    }
-
-    @Composable
-    fun formattedMessage() = when (this) {
-        is Hidden -> AnnotatedString("")
-        is Loading -> stringResource(id = CommonStrings.screen_room_pinned_banner_loading_description).toAnnotatedString()
-        is Loaded -> currentPinnedMessage.formatted
-    }
 }

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/pinned/banner/PinnedMessagesBannerState.kt

@@ -78,7 +78,7 @@ fun PinnedMessagesBannerView(
 
 @Composable
 private fun PinnedMessagesBannerRow(
-    state: PinnedMessagesBannerState,
+    state: PinnedMessagesBannerState.Visible,
     onClick: (EventId) -> Unit,
     onViewAllClick: () -> Unit,
     modifier: Modifier = Modifier,

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/pinned/banner/PinnedMessagesBannerView.kt

@@ -0,0 +1,26 @@
+/*
+ * Copyright 2025 New Vector Ltd.
+ *
+ * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
+ * Please see LICENSE files in the repository root for full details.
+ */
+
+package io.element.android.features.messages.impl.attachments
+
+import com.google.common.truth.Truth.assertThat
+import io.element.android.features.messages.impl.attachments.preview.SendActionState
+import io.element.android.features.messages.impl.attachments.preview.aMediaUploadInfo
+import io.element.android.libraries.mediaupload.api.MediaUploadInfo
+import org.junit.Test
+
+class SendActionStateTest {
+    @Test
+    fun `mediaUploadInfo() should return the value from Uploading class`() {
+        val mediaUploadInfo: MediaUploadInfo = aMediaUploadInfo()
+        val state: SendActionState = SendActionState.Sending.Uploading(
+            progress = 0.5f,
+            mediaUploadInfo = aMediaUploadInfo()
+        )
+        assertThat(state.mediaUploadInfo()).isEqualTo(mediaUploadInfo)
+    }
+}

features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/attachments/SendActionStateTest.kt

@@ -62,7 +62,7 @@ class PinnedMessagesBannerPresenterTest {
         val presenter = createPinnedMessagesBannerPresenter(room = room)
         presenter.test {
             skipItems(2)
-            val loadingState = awaitItem()
+            val loadingState = awaitItem() as PinnedMessagesBannerState.Loading
             assertThat(loadingState).isEqualTo(PinnedMessagesBannerState.Loading(1))
             assertThat(loadingState.pinnedMessagesCount()).isEqualTo(1)
             assertThat(loadingState.currentPinnedMessageIndex()).isEqualTo(0)
@@ -167,7 +167,8 @@ class PinnedMessagesBannerPresenterTest {
         val presenter = createPinnedMessagesBannerPresenter(room = room)
         presenter.test {
             skipItems(2)
-            awaitItem().also { loadingState ->
+            awaitItem().also { state ->
+                val loadingState = state as PinnedMessagesBannerState.Loading
                 assertThat(loadingState).isEqualTo(PinnedMessagesBannerState.Loading(1))
                 assertThat(loadingState.pinnedMessagesCount()).isEqualTo(1)
                 assertThat(loadingState.currentPinnedMessageIndex()).isEqualTo(0)

features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/pinned/banner/PinnedMessagesBannerPresenterTest.kt

@@ -40,7 +40,7 @@ signing.element.nightly.keyPassword=Secret
 
 # Customise the Lint version to use a more recent version than the one bundled with AGP
 # https://googlesamples.github.io/android-custom-lint-rules/usage/newer-lint.md.html
-android.experimental.lint.version=8.11.0
+android.experimental.lint.version=8.12.0-alpha07
 
 # Enable test fixture for all modules by default
 android.experimental.enableTestFixtures=true

gradle.properties

@@ -4,9 +4,9 @@
 [versions]
 # Project
 android_gradle_plugin = "8.11.0"
-kotlin = "2.1.21"
+kotlin = "2.2.0"
 kotlinpoet = "2.2.0"
-ksp = "2.1.21-2.0.2"
+ksp = "2.2.0-2.0.2"
 firebaseAppDistribution = "5.1.1"
 
 # AndroidX
@@ -33,8 +33,8 @@ accompanist = "0.37.3"
 test_core = "1.6.1"
 
 # Jetbrain
-datetime = "0.6.2"
-serialization_json = "1.8.1"
+datetime = "0.7.0"
+serialization_json = "1.9.0"
 
 #other
 detekt = "1.23.8"

gradle/libs.versions.toml

@@ -22,6 +22,14 @@ android {
         }
     }
 
+    kotlin {
+        compilerOptions {
+            optIn = listOf(
+                "kotlin.time.ExperimentalTime"
+            )
+        }
+    }
+
     dependencies {
         implementation(libs.dagger)
         implementation(projects.libraries.core)