Allow entering Pip mode when controls.canEnterPip() cannot be evaluated.

bmarty · bmarty · commit 368db3feb48c · 2024-08-23T16:28:13.000+02:00
diff --git a/features/call/impl/src/main/kotlin/io/element/android/features/call/impl/utils/WebViewWebPipApi.kt b/features/call/impl/src/main/kotlin/io/element/android/features/call/impl/utils/WebViewWebPipApi.kt
@@ -26,7 +26,8 @@ class WebViewWebPipApi(
     override suspend fun canEnterPip(): Boolean {
         return suspendCoroutine { continuation ->
             webView.evaluateJavascript("controls.canEnterPip()") { result ->
-                continuation.resume(result == "true")
+                // Note if the method is not available, it will return "null"
+                continuation.resume(result == "true" || result == "null")
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,8 @@ class WebViewWebPipApi(`
`26`	`26`	`override suspend fun canEnterPip(): Boolean {`
`27`	`27`	`return suspendCoroutine { continuation ->`
`28`	`28`	`webView.evaluateJavascript("controls.canEnterPip()") { result ->`
`29`		`- continuation.resume(result == "true")`
	`29`	`+ // Note if the method is not available, it will return "null"`
	`30`	`+ continuation.resume(result == "true" \|\| result == "null")`
`30`	`31`	`}`
`31`	`32`	`}`
`32`	`33`	`}`