Skip to content

Commit 4e0d00d

Browse files
authored
Ensure that pinning an event makes the pinned messages banner appear (#4606)
1 parent 566457a commit 4e0d00d

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesView.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,9 @@ private fun MessagesViewContent(
363363
},
364364
content = { paddingValues ->
365365
Box(modifier = Modifier.padding(paddingValues)) {
366-
val scrollBehavior = PinnedMessagesBannerViewDefaults.rememberExitOnScrollBehavior()
366+
val scrollBehavior = PinnedMessagesBannerViewDefaults.rememberScrollBehavior(
367+
pinnedMessagesCount = state.pinnedMessagesBannerState.pinnedMessagesCount(),
368+
)
367369
TimelineView(
368370
state = state.timelineState,
369371
timelineProtectionState = state.timelineProtectionState,

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/pinned/banner/PinnedMessagesBannerView.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ internal interface PinnedMessagesBannerViewScrollBehavior {
265265

266266
internal object PinnedMessagesBannerViewDefaults {
267267
@Composable
268-
fun rememberExitOnScrollBehavior(): PinnedMessagesBannerViewScrollBehavior = remember {
268+
fun rememberScrollBehavior(pinnedMessagesCount: Int): PinnedMessagesBannerViewScrollBehavior = remember(pinnedMessagesCount) {
269269
ExitOnScrollBehavior()
270270
}
271271
}

0 commit comments

Comments
 (0)