Fix tests and lint issues.

Fixing the tests required addressing some underlying issues in `SearchBar`

Author: jmartinesp

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/customreaction/picker/EmojiPickerPresenter.kt

@@ -13,6 +13,7 @@ import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
 import androidx.compose.runtime.setValue
+import androidx.compose.ui.platform.LocalInspectionMode
 import io.element.android.emojibasebindings.Emoji
 import io.element.android.emojibasebindings.EmojibaseStore
 import io.element.android.libraries.architecture.Presenter
@@ -57,9 +58,13 @@ class EmojiPickerPresenter(
             }
         }
 
+        val isInPreview = LocalInspectionMode.current
         fun handleEvents(event: EmojiPickerEvents) {
             when (event) {
-                is EmojiPickerEvents.ToggleSearchActive -> isSearchActive = event.isActive
+                // For some reason, in preview mode the SearchBar emits this event with an `isActive = true` value automatically
+                is EmojiPickerEvents.ToggleSearchActive -> if (!isInPreview) {
+                    isSearchActive = event.isActive
+                }
                 is EmojiPickerEvents.UpdateSearchQuery -> searchQuery = event.query
             }
         }
@@ -73,4 +78,3 @@ class EmojiPickerPresenter(
         )
     }
 }
-

libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/components/SearchBar.kt

@@ -23,7 +23,10 @@ import androidx.compose.material3.TextFieldColors
 import androidx.compose.material3.TextFieldDefaults
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.Immutable
+import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.getValue
 import androidx.compose.runtime.remember
+import androidx.compose.runtime.rememberUpdatedState
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.graphics.Shape
@@ -67,16 +70,19 @@ fun <T> SearchBar(
 ) {
     val focusManager = LocalFocusManager.current
 
-    if (!active) {
-        onQueryChange("")
-        focusManager.clearFocus()
+    val updatedOnQueryChange by rememberUpdatedState(onQueryChange)
+    LaunchedEffect(active) {
+        if (!active) {
+            updatedOnQueryChange("")
+            focusManager.clearFocus()
+        }
     }
 
     SearchBar(
         inputField = {
             SearchBarDefaults.InputField(
                 query = query,
-                onQueryChange = onQueryChange,
+                onQueryChange = updatedOnQueryChange,
                 onSearch = { focusManager.clearFocus() },
                 expanded = active,
                 onExpandedChange = onActiveChange,