Skip to content

Commit 555beb1

Browse files
committed
Improve code.
1 parent d7f39c3 commit 555beb1

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

appnav/src/main/kotlin/io/element/android/appnav/RootFlowNode.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -174,9 +174,6 @@ class RootFlowNode(
174174
state = state,
175175
modifier = modifier,
176176
onOpenBugReport = this::onOpenBugReport,
177-
announcementRenderer = { announcementModifier ->
178-
announcementService.Render(announcementModifier)
179-
}
180177
) {
181178
val backstackSlider = rememberBackstackSlider<NavTarget>(
182179
transitionSpec = { spring(stiffness = Spring.StiffnessMediumLow) },
@@ -192,6 +189,7 @@ class RootFlowNode(
192189
}
193190
}
194191
BackstackView(transitionHandler = transitionHandler)
192+
announcementService.Render(Modifier)
195193
}
196194
}
197195

appnav/src/main/kotlin/io/element/android/appnav/root/RootView.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import io.element.android.services.apperror.impl.AppErrorView
2727
fun RootView(
2828
state: RootState,
2929
onOpenBugReport: () -> Unit,
30-
announcementRenderer: @Composable (Modifier) -> Unit,
3130
modifier: Modifier = Modifier,
3231
children: @Composable BoxScope.() -> Unit,
3332
) {
@@ -44,8 +43,6 @@ fun RootView(
4443
onOpenBugReport.invoke()
4544
}
4645

47-
announcementRenderer(Modifier)
48-
4946
RageshakeDetectionView(
5047
state = state.rageshakeDetectionState,
5148
onOpenBugReport = ::onOpenBugReport,
@@ -66,7 +63,6 @@ internal fun RootViewPreview(@PreviewParameter(RootStateProvider::class) rootSta
6663
RootView(
6764
state = rootState,
6865
onOpenBugReport = {},
69-
announcementRenderer = { },
7066
) {
7167
Text("Children")
7268
}

0 commit comments

Comments
 (0)