Skip to content

Commit 5f071da

Browse files
committed
Fix non-scrollable screens.
1 parent 3ed8b0d commit 5f071da

File tree

1 file changed

+30
-23
lines changed
  • features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/rolesandpermissions/permissions

1 file changed

+30
-23
lines changed

features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/rolesandpermissions/permissions/ChangeRoomPermissionsView.kt

Lines changed: 30 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,9 @@
1717
package io.element.android.features.roomdetails.impl.rolesandpermissions.permissions
1818

1919
import androidx.activity.compose.BackHandler
20-
import androidx.compose.foundation.layout.Column
20+
import androidx.compose.foundation.layout.fillMaxSize
2121
import androidx.compose.foundation.layout.padding
22+
import androidx.compose.foundation.lazy.LazyColumn
2223
import androidx.compose.material3.ExperimentalMaterial3Api
2324
import androidx.compose.runtime.Composable
2425
import androidx.compose.ui.Modifier
@@ -80,29 +81,35 @@ fun ChangeRoomPermissionsView(
8081
)
8182
}
8283
) { padding ->
83-
Column(modifier = Modifier.padding(padding)) {
84+
LazyColumn(
85+
modifier = Modifier
86+
.padding(padding)
87+
.fillMaxSize()
88+
) {
8489
for ((index, permissionItem) in state.items.withIndex()) {
85-
ListSectionHeader(titleForSection(item = permissionItem), hasDivider = index > 0)
86-
SelectRoleItem(
87-
permissionsItem = permissionItem,
88-
role = RoomMember.Role.ADMIN,
89-
currentPermissions = state.currentPermissions
90-
) { item, role ->
91-
state.eventSink(ChangeRoomPermissionsEvent.ChangeMinimumRoleForAction(item, role))
92-
}
93-
SelectRoleItem(
94-
permissionsItem = permissionItem,
95-
role = RoomMember.Role.MODERATOR,
96-
currentPermissions = state.currentPermissions
97-
) { item, role ->
98-
state.eventSink(ChangeRoomPermissionsEvent.ChangeMinimumRoleForAction(item, role))
99-
}
100-
SelectRoleItem(
101-
permissionsItem = permissionItem,
102-
role = RoomMember.Role.USER,
103-
currentPermissions = state.currentPermissions
104-
) { item, role ->
105-
state.eventSink(ChangeRoomPermissionsEvent.ChangeMinimumRoleForAction(item, role))
90+
item {
91+
ListSectionHeader(titleForSection(item = permissionItem), hasDivider = index > 0)
92+
SelectRoleItem(
93+
permissionsItem = permissionItem,
94+
role = RoomMember.Role.ADMIN,
95+
currentPermissions = state.currentPermissions
96+
) { item, role ->
97+
state.eventSink(ChangeRoomPermissionsEvent.ChangeMinimumRoleForAction(item, role))
98+
}
99+
SelectRoleItem(
100+
permissionsItem = permissionItem,
101+
role = RoomMember.Role.MODERATOR,
102+
currentPermissions = state.currentPermissions
103+
) { item, role ->
104+
state.eventSink(ChangeRoomPermissionsEvent.ChangeMinimumRoleForAction(item, role))
105+
}
106+
SelectRoleItem(
107+
permissionsItem = permissionItem,
108+
role = RoomMember.Role.USER,
109+
currentPermissions = state.currentPermissions
110+
) { item, role ->
111+
state.eventSink(ChangeRoomPermissionsEvent.ChangeMinimumRoleForAction(item, role))
112+
}
106113
}
107114
}
108115
}

0 commit comments

Comments
 (0)