Skip to content

Commit 602b891

Browse files
ganfraganfra
committed
knock requests : rename fixture aKnockRequestPresentable
1 parent 189cc5c commit 602b891

File tree

5 files changed

+34
-34
lines changed

5 files changed

+34
-34
lines changed

‎features/knockrequests/impl/src/main/kotlin/io/element/android/features/knockrequests/impl/banner/KnockRequestsBannerStateProvider.kt‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ package io.element.android.features.knockrequests.impl.banner
99

1010
import androidx.compose.ui.tooling.preview.PreviewParameterProvider
1111
import io.element.android.features.knockrequests.impl.data.KnockRequestPresentable
12-
import io.element.android.features.knockrequests.impl.data.aKnockRequest
12+
import io.element.android.features.knockrequests.impl.data.aKnockRequestPresentable
1313
import kotlinx.collections.immutable.toImmutableList
1414

1515
class KnockRequestsBannerStateProvider : PreviewParameterProvider<KnockRequestsBannerState> {
@@ -18,7 +18,7 @@ class KnockRequestsBannerStateProvider : PreviewParameterProvider<KnockRequestsB
1818
aKnockRequestsBannerState(),
1919
aKnockRequestsBannerState(
2020
knockRequests = listOf(
21-
aKnockRequest(
21+
aKnockRequestPresentable(
2222
reason = "A very long reason that should probably be truncated, " +
2323
"but could be also expanded so you can see it over the lines, wow," +
2424
"very amazing reason, I know, right, I'm so good at writing reasons."
@@ -27,16 +27,16 @@ class KnockRequestsBannerStateProvider : PreviewParameterProvider<KnockRequestsB
2727
),
2828
aKnockRequestsBannerState(
2929
knockRequests = listOf(
30-
aKnockRequest(),
31-
aKnockRequest(displayName = "Alice")
30+
aKnockRequestPresentable(),
31+
aKnockRequestPresentable(displayName = "Alice")
3232
)
3333
),
3434
aKnockRequestsBannerState(
3535
knockRequests = listOf(
36-
aKnockRequest(),
37-
aKnockRequest(displayName = "Alice"),
38-
aKnockRequest(displayName = "Bob"),
39-
aKnockRequest(displayName = "Charlie")
36+
aKnockRequestPresentable(),
37+
aKnockRequestPresentable(displayName = "Alice"),
38+
aKnockRequestPresentable(displayName = "Bob"),
39+
aKnockRequestPresentable(displayName = "Charlie")
4040
)
4141
),
4242
aKnockRequestsBannerState(
@@ -47,7 +47,7 @@ class KnockRequestsBannerStateProvider : PreviewParameterProvider<KnockRequestsB
4747
),
4848
aKnockRequestsBannerState(
4949
knockRequests = listOf(
50-
aKnockRequest(
50+
aKnockRequestPresentable(
5151
displayName = "A_very_long_display_name_so_that_the_text_can_be_displayed_on_multiple_lines"
5252
)
5353
)
@@ -56,7 +56,7 @@ class KnockRequestsBannerStateProvider : PreviewParameterProvider<KnockRequestsB
5656
}
5757

5858
fun aKnockRequestsBannerState(
59-
knockRequests: List<KnockRequestPresentable> = listOf(aKnockRequest()),
59+
knockRequests: List<KnockRequestPresentable> = listOf(aKnockRequestPresentable()),
6060
displayAcceptError: Boolean = false,
6161
canAccept: Boolean = true,
6262
isVisible: Boolean = true,

‎features/knockrequests/impl/src/main/kotlin/io/element/android/features/knockrequests/impl/data/KnockRequestFixture.kt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ package io.element.android.features.knockrequests.impl.data
1010
import io.element.android.libraries.matrix.api.core.EventId
1111
import io.element.android.libraries.matrix.api.core.UserId
1212

13-
fun aKnockRequest(
13+
fun aKnockRequestPresentable(
1414
eventId: EventId = EventId("\$eventId"),
1515
userId: UserId = UserId("@jacob_ross:example.com"),
1616
displayName: String? = "Jacob Ross",

‎features/knockrequests/impl/src/main/kotlin/io/element/android/features/knockrequests/impl/list/KnockRequestsListStateProvider.kt‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ package io.element.android.features.knockrequests.impl.list
1010
import androidx.compose.ui.tooling.preview.PreviewParameterProvider
1111
import io.element.android.features.knockrequests.impl.data.KnockRequestPermissions
1212
import io.element.android.features.knockrequests.impl.data.KnockRequestPresentable
13-
import io.element.android.features.knockrequests.impl.data.aKnockRequest
13+
import io.element.android.features.knockrequests.impl.data.aKnockRequestPresentable
1414
import io.element.android.libraries.architecture.AsyncAction
1515
import io.element.android.libraries.architecture.AsyncData
1616
import io.element.android.libraries.matrix.api.core.UserId
@@ -31,14 +31,14 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
3131
aKnockRequestsListState(
3232
knockRequests = AsyncData.Success(
3333
persistentListOf(
34-
aKnockRequest()
34+
aKnockRequestPresentable()
3535
)
3636
),
3737
),
3838
aKnockRequestsListState(
3939
knockRequests = AsyncData.Success(
4040
persistentListOf(
41-
aKnockRequest(
41+
aKnockRequestPresentable(
4242
reason = "A very long reason that should probably be truncated, " +
4343
"but could be also expanded so you can see it over the lines, wow," +
4444
"very amazing reason, I know, right, I'm so good at writing reasons."
@@ -49,8 +49,8 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
4949
aKnockRequestsListState(
5050
knockRequests = AsyncData.Success(
5151
persistentListOf(
52-
aKnockRequest(),
53-
aKnockRequest(
52+
aKnockRequestPresentable(),
53+
aKnockRequestPresentable(
5454
userId = UserId("@user:example.com"),
5555
displayName = null,
5656
avatarUrl = null,
@@ -62,7 +62,7 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
6262
aKnockRequestsListState(
6363
knockRequests = AsyncData.Success(
6464
persistentListOf(
65-
aKnockRequest()
65+
aKnockRequestPresentable()
6666
)
6767
),
6868
actionTarget = KnockRequestsActionTarget.AcceptAll,
@@ -71,7 +71,7 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
7171
aKnockRequestsListState(
7272
knockRequests = AsyncData.Success(
7373
persistentListOf(
74-
aKnockRequest()
74+
aKnockRequestPresentable()
7575
)
7676
),
7777
actionTarget = KnockRequestsActionTarget.AcceptAll,
@@ -80,7 +80,7 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
8080
aKnockRequestsListState(
8181
knockRequests = AsyncData.Success(
8282
persistentListOf(
83-
aKnockRequest()
83+
aKnockRequestPresentable()
8484
)
8585
),
8686
permissions = KnockRequestPermissions(
@@ -94,7 +94,7 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
9494
aKnockRequestsListState(
9595
knockRequests = AsyncData.Success(
9696
persistentListOf(
97-
aKnockRequest()
97+
aKnockRequestPresentable()
9898
)
9999
),
100100
permissions = KnockRequestPermissions(
@@ -106,7 +106,7 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
106106
aKnockRequestsListState(
107107
knockRequests = AsyncData.Success(
108108
persistentListOf(
109-
aKnockRequest()
109+
aKnockRequestPresentable()
110110
)
111111
),
112112
permissions = KnockRequestPermissions(
@@ -118,7 +118,7 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
118118
aKnockRequestsListState(
119119
knockRequests = AsyncData.Success(
120120
persistentListOf(
121-
aKnockRequest()
121+
aKnockRequestPresentable()
122122
)
123123
),
124124
permissions = KnockRequestPermissions(

‎features/knockrequests/impl/src/test/kotlin/io/element/android/features/knockrequests/impl/banner/KnockRequestsBannerViewTest.kt‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import androidx.compose.ui.test.onNodeWithContentDescription
1414
import androidx.compose.ui.test.performClick
1515
import androidx.test.ext.junit.runners.AndroidJUnit4
1616
import io.element.android.features.knockrequests.impl.R
17-
import io.element.android.features.knockrequests.impl.data.aKnockRequest
17+
import io.element.android.features.knockrequests.impl.data.aKnockRequestPresentable
1818
import io.element.android.libraries.ui.strings.CommonStrings
1919
import io.element.android.tests.testutils.EnsureNeverCalled
2020
import io.element.android.tests.testutils.EventsRecorder
@@ -51,9 +51,9 @@ class KnockRequestsBannerViewTest {
5151
rule.setKnockRequestsBannerView(
5252
state = aKnockRequestsBannerState(
5353
knockRequests = listOf(
54-
aKnockRequest(displayName = "Alice"),
55-
aKnockRequest(displayName = "Bob"),
56-
aKnockRequest(displayName = "Charlie")
54+
aKnockRequestPresentable(displayName = "Alice"),
55+
aKnockRequestPresentable(displayName = "Bob"),
56+
aKnockRequestPresentable(displayName = "Charlie")
5757
),
5858
eventSink = eventsRecorder,
5959
),

‎features/knockrequests/impl/src/test/kotlin/io/element/android/features/knockrequests/impl/list/KnockRequestsListViewTest.kt‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import androidx.compose.ui.test.junit4.AndroidComposeTestRule
1212
import androidx.compose.ui.test.junit4.createAndroidComposeRule
1313
import androidx.test.ext.junit.runners.AndroidJUnit4
1414
import io.element.android.features.knockrequests.impl.R
15-
import io.element.android.features.knockrequests.impl.data.aKnockRequest
15+
import io.element.android.features.knockrequests.impl.data.aKnockRequestPresentable
1616
import io.element.android.libraries.architecture.AsyncAction
1717
import io.element.android.libraries.architecture.AsyncData
1818
import io.element.android.libraries.ui.strings.CommonStrings
@@ -48,7 +48,7 @@ class KnockRequestsListViewTest {
4848
@Test
4949
fun `clicking on accept emit the expected event`() {
5050
val eventsRecorder = EventsRecorder<KnockRequestsListEvents>()
51-
val knockRequest = aKnockRequest()
51+
val knockRequest = aKnockRequestPresentable()
5252
rule.setKnockRequestsListView(
5353
aKnockRequestsListState(
5454
knockRequests = AsyncData.Success(persistentListOf(knockRequest)),
@@ -62,7 +62,7 @@ class KnockRequestsListViewTest {
6262
@Test
6363
fun `clicking on decline emit the expected event`() {
6464
val eventsRecorder = EventsRecorder<KnockRequestsListEvents>()
65-
val knockRequest = aKnockRequest()
65+
val knockRequest = aKnockRequestPresentable()
6666
rule.setKnockRequestsListView(
6767
aKnockRequestsListState(
6868
knockRequests = AsyncData.Success(persistentListOf(knockRequest)),
@@ -76,7 +76,7 @@ class KnockRequestsListViewTest {
7676
@Test
7777
fun `clicking on decline and ban emit the expected event`() {
7878
val eventsRecorder = EventsRecorder<KnockRequestsListEvents>()
79-
val knockRequest = aKnockRequest()
79+
val knockRequest = aKnockRequestPresentable()
8080
rule.setKnockRequestsListView(
8181
aKnockRequestsListState(
8282
knockRequests = AsyncData.Success(persistentListOf(knockRequest)),
@@ -90,7 +90,7 @@ class KnockRequestsListViewTest {
9090
@Test
9191
fun `clicking on accept all emit the expected event`() {
9292
val eventsRecorder = EventsRecorder<KnockRequestsListEvents>()
93-
val knockRequests = persistentListOf(aKnockRequest(), aKnockRequest())
93+
val knockRequests = persistentListOf(aKnockRequestPresentable(), aKnockRequestPresentable())
9494
rule.setKnockRequestsListView(
9595
aKnockRequestsListState(
9696
knockRequests = AsyncData.Success(knockRequests),
@@ -104,7 +104,7 @@ class KnockRequestsListViewTest {
104104
@Test
105105
fun `retry on async view retry emit the expected event`() {
106106
val eventsRecorder = EventsRecorder<KnockRequestsListEvents>()
107-
val knockRequests = persistentListOf(aKnockRequest(), aKnockRequest())
107+
val knockRequests = persistentListOf(aKnockRequestPresentable(), aKnockRequestPresentable())
108108
rule.setKnockRequestsListView(
109109
aKnockRequestsListState(
110110
knockRequests = AsyncData.Success(knockRequests),
@@ -120,7 +120,7 @@ class KnockRequestsListViewTest {
120120
@Test
121121
fun `canceling async view emit the expected event`() {
122122
val eventsRecorder = EventsRecorder<KnockRequestsListEvents>()
123-
val knockRequests = persistentListOf(aKnockRequest(), aKnockRequest())
123+
val knockRequests = persistentListOf(aKnockRequestPresentable(), aKnockRequestPresentable())
124124
rule.setKnockRequestsListView(
125125
aKnockRequestsListState(
126126
knockRequests = AsyncData.Success(knockRequests),
@@ -136,7 +136,7 @@ class KnockRequestsListViewTest {
136136
@Test
137137
fun `confirming async view emit the expected event`() {
138138
val eventsRecorder = EventsRecorder<KnockRequestsListEvents>()
139-
val knockRequests = persistentListOf(aKnockRequest(), aKnockRequest())
139+
val knockRequests = persistentListOf(aKnockRequestPresentable(), aKnockRequestPresentable())
140140
rule.setKnockRequestsListView(
141141
aKnockRequestsListState(
142142
knockRequests = AsyncData.Success(knockRequests),

0 commit comments

Comments
 (0)