Display members section when there are members in the room, not admins (#2679)

jmartinesp · ElementBot · web-flow · commit 63f7defb0704 · 2024-04-09T13:08:40.000Z
* Display members section when there are members in the room, not admins

* Update screenshots

---------

Co-authored-by: ElementBot &lt;benoitm+elementbot@element.io&gt;
diff --git a/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/rolesandpermissions/changeroles/ChangeRolesView.kt b/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/rolesandpermissions/changeroles/ChangeRolesView.kt
@@ -284,7 +284,7 @@ private fun SearchResultsList(
                 )
             }
         }
-        if (searchResults.admins.isNotEmpty()) {
+        if (searchResults.members.isNotEmpty()) {
             stickyHeader { ListSectionHeader(text = stringResource(R.string.screen_room_member_list_mode_members)) }
             items(searchResults.members, key = { it.userId }) { roomMember ->
                 ListMemberItem(
diff --git a/tests/uitests/src/test/snapshots/images/ui_S_t[f.roomdetails.impl.rolesandpermissions.changeroles_ChangeRolesView_null_ChangeRolesView-Day-9_10_null_5,NEXUS_5,1.0,en].png b/tests/uitests/src/test/snapshots/images/ui_S_t[f.roomdetails.impl.rolesandpermissions.changeroles_ChangeRolesView_null_ChangeRolesView-Day-9_10_null_5,NEXUS_5,1.0,en].png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:9e07c6ee5a1e9ebedc98ed8daca1c7e81c877102e24d9cc7a21834ce24df7d1d
-size 16758
+oid sha256:5c78aba6e190dd73671503b4fa725c04c9bf23ffc3b7ca953670663e16fda7b7
+size 14607
diff --git a/tests/uitests/src/test/snapshots/images/ui_S_t[f.roomdetails.impl.rolesandpermissions.changeroles_ChangeRolesView_null_ChangeRolesView-Night-9_11_null_5,NEXUS_5,1.0,en].png b/tests/uitests/src/test/snapshots/images/ui_S_t[f.roomdetails.impl.rolesandpermissions.changeroles_ChangeRolesView_null_ChangeRolesView-Night-9_11_null_5,NEXUS_5,1.0,en].png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:b8188aab8aaa9d7685e6936883e635f097bc3b9b8fdd5bb778bc7baae3f97ea1
-size 16308
+oid sha256:b96e9765dc77cb7a16da3d241b9ee90a7039a5184bf90002b2856aa9a695b446
+size 14304

Original file line number	Diff line number	Diff line change
`@@ -284,7 +284,7 @@ private fun SearchResultsList(`
`284`	`284`	`)`
`285`	`285`	`}`
`286`	`286`	`}`
`287`		`- if (searchResults.admins.isNotEmpty()) {`
	`287`	`+ if (searchResults.members.isNotEmpty()) {`
`288`	`288`	`stickyHeader { ListSectionHeader(text = stringResource(R.string.screen_room_member_list_mode_members)) }`
`289`	`289`	`items(searchResults.members, key = { it.userId }) { roomMember ->`
`290`	`290`	`ListMemberItem(`