Skip to content

Commit 65d682f

Browse files
committed
Rename method storeData to addSession.
1 parent 95ce404 commit 65d682f

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/auth/RustMatrixAuthenticationService.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ class RustMatrixAuthenticationService(
158158
)
159159
val matrixClient = rustMatrixClientFactory.create(client)
160160
newMatrixClientObservers.forEach { it.invoke(matrixClient) }
161-
sessionStore.storeData(sessionData)
161+
sessionStore.addSession(sessionData)
162162

163163
// Clean up the strong reference held here since it's no longer necessary
164164
currentClient = null
@@ -182,7 +182,7 @@ class RustMatrixAuthenticationService(
182182
sessionPaths = currentSessionPaths,
183183
)
184184
clear()
185-
sessionStore.storeData(sessionData)
185+
sessionStore.addSession(sessionData)
186186
SessionId(sessionData.userId)
187187
}
188188
}
@@ -250,7 +250,7 @@ class RustMatrixAuthenticationService(
250250

251251
val matrixClient = rustMatrixClientFactory.create(client)
252252
newMatrixClientObservers.forEach { it.invoke(matrixClient) }
253-
sessionStore.storeData(sessionData)
253+
sessionStore.addSession(sessionData)
254254

255255
// Clean up the strong reference held here since it's no longer necessary
256256
currentClient = null
@@ -295,7 +295,7 @@ class RustMatrixAuthenticationService(
295295
)
296296
val matrixClient = rustMatrixClientFactory.create(client)
297297
newMatrixClientObservers.forEach { it.invoke(matrixClient) }
298-
sessionStore.storeData(sessionData)
298+
sessionStore.addSession(sessionData)
299299

300300
// Clean up the strong reference held here since it's no longer necessary
301301
currentClient = null

libraries/session-storage/api/src/main/kotlin/io/element/android/libraries/sessionstorage/api/SessionStore.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import kotlinx.coroutines.flow.map
1313
interface SessionStore {
1414
fun isLoggedIn(): Flow<LoggedInState>
1515
fun sessionsFlow(): Flow<List<SessionData>>
16-
suspend fun storeData(sessionData: SessionData)
16+
suspend fun addSession(sessionData: SessionData)
1717

1818
/**
1919
* Will update the session data matching the userId, except the value of loginTimestamp.

libraries/session-storage/impl/src/main/kotlin/io/element/android/libraries/sessionstorage/impl/DatabaseSessionStore.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class DatabaseSessionStore(
4949
}
5050
}
5151

52-
override suspend fun storeData(sessionData: SessionData) {
52+
override suspend fun addSession(sessionData: SessionData) {
5353
sessionDataMutex.withLock {
5454
database.sessionDataQueries.insertSessionData(sessionData.toDbModel())
5555
}

libraries/session-storage/impl/src/test/kotlin/io/element/android/libraries/sessionstorage/impl/DatabaseSessionStoreTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@ class DatabaseSessionStoreTest {
4444
}
4545

4646
@Test
47-
fun `storeData persists the SessionData into the DB`() = runTest {
47+
fun `addSession persists the SessionData into the DB`() = runTest {
4848
assertThat(database.sessionDataQueries.selectFirst().executeAsOneOrNull()).isNull()
4949

50-
databaseSessionStore.storeData(aSessionData.toApiModel())
50+
databaseSessionStore.addSession(aSessionData.toApiModel())
5151

5252
assertThat(database.sessionDataQueries.selectFirst().executeAsOneOrNull()).isEqualTo(aSessionData)
5353
assertThat(database.sessionDataQueries.selectAll().executeAsList().size).isEqualTo(1)

libraries/session-storage/impl/src/test/kotlin/io/element/android/libraries/sessionstorage/impl/observer/DefaultSessionObserverTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ import org.junit.Test
5151
runCurrent()
5252
val listener = TestSessionListener()
5353
sut.addListener(listener)
54-
databaseSessionStore.storeData(sessionData.toApiModel())
54+
databaseSessionStore.addSession(sessionData.toApiModel())
5555
listener.assertEvents(TestSessionListener.Event.Created(sessionData.userId))
5656
sut.removeListener(listener)
5757
coroutineContext.cancelChildren()
@@ -64,7 +64,7 @@ import org.junit.Test
6464
runCurrent()
6565
val listener = TestSessionListener()
6666
sut.addListener(listener)
67-
databaseSessionStore.storeData(sessionData.toApiModel())
67+
databaseSessionStore.addSession(sessionData.toApiModel())
6868
listener.assertEvents(TestSessionListener.Event.Created(sessionData.userId))
6969
databaseSessionStore.removeSession(sessionData.userId)
7070
listener.assertEvents(

libraries/session-storage/test/src/main/kotlin/io/element/android/libraries/sessionstorage/test/InMemorySessionStore.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class InMemorySessionStore(
3737

3838
override fun sessionsFlow(): Flow<List<SessionData>> = sessionDataListFlow.asStateFlow()
3939

40-
override suspend fun storeData(sessionData: SessionData) {
40+
override suspend fun addSession(sessionData: SessionData) {
4141
val currentList = sessionDataListFlow.value.toMutableList()
4242
currentList.removeAll { it.userId == sessionData.userId }
4343
currentList.add(sessionData)

0 commit comments

Comments
 (0)