Skip to content

Commit 6e6722a

Browse files
committed
Rename method storeData to addSession.
1 parent b7df6ad commit 6e6722a

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/auth/RustMatrixAuthenticationService.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ class RustMatrixAuthenticationService(
161161
)
162162
val matrixClient = rustMatrixClientFactory.create(client)
163163
newMatrixClientObservers.forEach { it.invoke(matrixClient) }
164-
sessionStore.storeData(sessionData)
164+
sessionStore.addSession(sessionData)
165165

166166
// Clean up the strong reference held here since it's no longer necessary
167167
currentClient = null
@@ -185,7 +185,7 @@ class RustMatrixAuthenticationService(
185185
sessionPaths = currentSessionPaths,
186186
)
187187
clear()
188-
sessionStore.storeData(sessionData)
188+
sessionStore.addSession(sessionData)
189189
SessionId(sessionData.userId)
190190
}
191191
}
@@ -255,7 +255,7 @@ class RustMatrixAuthenticationService(
255255
)
256256
val matrixClient = rustMatrixClientFactory.create(client)
257257
newMatrixClientObservers.forEach { it.invoke(matrixClient) }
258-
sessionStore.storeData(sessionData)
258+
sessionStore.addSession(sessionData)
259259

260260
// Clean up the strong reference held here since it's no longer necessary
261261
currentClient = null
@@ -316,7 +316,7 @@ class RustMatrixAuthenticationService(
316316
)
317317
val matrixClient = rustMatrixClientFactory.create(client)
318318
newMatrixClientObservers.forEach { it.invoke(matrixClient) }
319-
sessionStore.storeData(sessionData)
319+
sessionStore.addSession(sessionData)
320320

321321
// Clean up the strong reference held here since it's no longer necessary
322322
currentClient = null

libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/auth/RustMatrixAuthenticationServiceTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class RustMatrixAuthenticationServiceTest {
3030
sessionStore = sessionStore,
3131
)
3232
assertThat(sut.getLatestSessionId()).isNull()
33-
sessionStore.storeData(aSessionData(sessionId = "@alice:server.org"))
33+
sessionStore.addSession(aSessionData(sessionId = "@alice:server.org"))
3434
assertThat(sut.getLatestSessionId()).isEqualTo(SessionId("@alice:server.org"))
3535
}
3636

libraries/session-storage/api/src/main/kotlin/io/element/android/libraries/sessionstorage/api/SessionStore.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import kotlinx.coroutines.flow.map
1313
interface SessionStore {
1414
fun isLoggedIn(): Flow<LoggedInState>
1515
fun sessionsFlow(): Flow<List<SessionData>>
16-
suspend fun storeData(sessionData: SessionData)
16+
suspend fun addSession(sessionData: SessionData)
1717

1818
/**
1919
* Will update the session data matching the userId, except the value of loginTimestamp.

libraries/session-storage/impl/src/main/kotlin/io/element/android/libraries/sessionstorage/impl/DatabaseSessionStore.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class DatabaseSessionStore(
5252
}
5353
}
5454

55-
override suspend fun storeData(sessionData: SessionData) {
55+
override suspend fun addSession(sessionData: SessionData) {
5656
sessionDataMutex.withLock {
5757
val lastUsageIndex = getLastUsageIndex()
5858
database.sessionDataQueries.insertSessionData(

libraries/session-storage/impl/src/test/kotlin/io/element/android/libraries/sessionstorage/impl/DatabaseSessionStoreTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@ class DatabaseSessionStoreTest {
4444
}
4545

4646
@Test
47-
fun `storeData persists the SessionData into the DB`() = runTest {
47+
fun `addSession persists the SessionData into the DB`() = runTest {
4848
assertThat(database.sessionDataQueries.selectLatest().executeAsOneOrNull()).isNull()
4949

50-
databaseSessionStore.storeData(aSessionData.toApiModel())
50+
databaseSessionStore.addSession(aSessionData.toApiModel())
5151

5252
assertThat(database.sessionDataQueries.selectLatest().executeAsOneOrNull()).isEqualTo(aSessionData)
5353
assertThat(database.sessionDataQueries.selectAll().executeAsList().size).isEqualTo(1)

libraries/session-storage/impl/src/test/kotlin/io/element/android/libraries/sessionstorage/impl/observer/DefaultSessionObserverTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ import org.junit.Test
5151
runCurrent()
5252
val listener = TestSessionListener()
5353
sut.addListener(listener)
54-
databaseSessionStore.storeData(sessionData.toApiModel())
54+
databaseSessionStore.addSession(sessionData.toApiModel())
5555
listener.assertEvents(TestSessionListener.Event.Created(sessionData.userId))
5656
sut.removeListener(listener)
5757
coroutineContext.cancelChildren()
@@ -64,7 +64,7 @@ import org.junit.Test
6464
runCurrent()
6565
val listener = TestSessionListener()
6666
sut.addListener(listener)
67-
databaseSessionStore.storeData(sessionData.toApiModel())
67+
databaseSessionStore.addSession(sessionData.toApiModel())
6868
listener.assertEvents(TestSessionListener.Event.Created(sessionData.userId))
6969
databaseSessionStore.removeSession(sessionData.userId)
7070
listener.assertEvents(

0 commit comments

Comments
 (0)