Avoid usage of not() and add unit tests.

Author: bmarty

features/login/impl/src/main/kotlin/io/element/android/features/login/impl/changeserver/ChangeServerPresenter.kt

@@ -61,7 +61,7 @@ class ChangeServerPresenter(
                 accountProviderUrl = data.url,
             )
             val details = authenticationService.setHomeserver(data.url).getOrThrow()
-            if (details.supportsOidcLogin.not() && details.supportsPasswordLogin.not()) {
+            if (details.isSupported) {
                 throw ChangeServerError.UnsupportedServer
             }
             // Homeserver is valid, remember user choice

features/login/impl/src/test/kotlin/io/element/android/features/login/impl/changeserver/ChangeServerPresenterTest.kt

@@ -10,7 +10,6 @@ package io.element.android.features.login.impl.changeserver
 import com.google.common.truth.Truth.assertThat
 import io.element.android.features.enterprise.api.EnterpriseService
 import io.element.android.features.enterprise.test.FakeEnterpriseService
-import io.element.android.features.login.impl.aMatrixHomeServerDetails
 import io.element.android.features.login.impl.accesscontrol.DefaultAccountProviderAccessControl
 import io.element.android.features.login.impl.accountprovider.AccountProvider
 import io.element.android.features.login.impl.accountprovider.AccountProviderDataSource
@@ -22,6 +21,7 @@ import io.element.android.libraries.core.uri.ensureProtocol
 import io.element.android.libraries.matrix.test.AN_EXCEPTION
 import io.element.android.libraries.matrix.test.A_HOMESERVER_URL
 import io.element.android.libraries.matrix.test.auth.FakeMatrixAuthenticationService
+import io.element.android.libraries.matrix.test.auth.aMatrixHomeServerDetails
 import io.element.android.libraries.wellknown.api.ElementWellKnown
 import io.element.android.libraries.wellknown.api.WellknownRetriever
 import io.element.android.libraries.wellknown.api.WellknownRetrieverResult

features/login/impl/src/test/kotlin/io/element/android/features/login/impl/screens/confirmaccountprovider/ConfirmAccountProviderPresenterTest.kt

@@ -10,7 +10,6 @@ package io.element.android.features.login.impl.screens.confirmaccountprovider
 import com.google.common.truth.Truth.assertThat
 import io.element.android.appconfig.AuthenticationConfig
 import io.element.android.features.enterprise.test.FakeEnterpriseService
-import io.element.android.features.login.impl.aMatrixHomeServerDetails
 import io.element.android.features.login.impl.accountprovider.AccountProviderDataSource
 import io.element.android.features.login.impl.login.LoginMode
 import io.element.android.features.login.impl.screens.createaccount.AccountCreationNotSupported
@@ -21,6 +20,7 @@ import io.element.android.libraries.architecture.AsyncData
 import io.element.android.libraries.matrix.api.auth.MatrixAuthenticationService
 import io.element.android.libraries.matrix.test.AN_EXCEPTION
 import io.element.android.libraries.matrix.test.auth.FakeMatrixAuthenticationService
+import io.element.android.libraries.matrix.test.auth.aMatrixHomeServerDetails
 import io.element.android.libraries.oidc.api.OidcAction
 import io.element.android.libraries.oidc.api.OidcActionFlow
 import io.element.android.libraries.oidc.test.customtab.FakeOidcActionFlow

features/login/impl/src/test/kotlin/io/element/android/features/login/impl/screens/loginpassword/LoginPasswordPresenterTest.kt

@@ -10,7 +10,6 @@ package io.element.android.features.login.impl.screens.loginpassword
 import com.google.common.truth.Truth.assertThat
 import io.element.android.appconfig.AuthenticationConfig
 import io.element.android.features.enterprise.test.FakeEnterpriseService
-import io.element.android.features.login.impl.aMatrixHomeServerDetails
 import io.element.android.features.login.impl.accountprovider.AccountProviderDataSource
 import io.element.android.libraries.architecture.AsyncData
 import io.element.android.libraries.matrix.api.core.SessionId
@@ -19,6 +18,7 @@ import io.element.android.libraries.matrix.test.A_PASSWORD
 import io.element.android.libraries.matrix.test.A_SESSION_ID
 import io.element.android.libraries.matrix.test.A_USER_NAME
 import io.element.android.libraries.matrix.test.auth.FakeMatrixAuthenticationService
+import io.element.android.libraries.matrix.test.auth.aMatrixHomeServerDetails
 import io.element.android.tests.testutils.WarmUpRule
 import io.element.android.tests.testutils.test
 import kotlinx.coroutines.test.runTest

libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/auth/MatrixHomeServerDetails.kt

@@ -11,4 +11,6 @@ data class MatrixHomeServerDetails(
     val url: String,
     val supportsPasswordLogin: Boolean,
     val supportsOidcLogin: Boolean,
-)
+) {
+    val isSupported = supportsPasswordLogin || supportsOidcLogin
+}

libraries/matrix/api/src/test/kotlin/io/element/android/libraries/matrix/api/auth/MatrixHomeServerDetailsTest.kt

@@ -0,0 +1,50 @@
+/*
+ * Copyright 2025 New Vector Ltd.
+ *
+ * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
+ * Please see LICENSE files in the repository root for full details.
+ */
+
+package io.element.android.libraries.matrix.api.auth
+
+import com.google.common.truth.Truth.assertThat
+import io.element.android.libraries.matrix.test.auth.aMatrixHomeServerDetails
+import org.junit.Test
+
+class MatrixHomeServerDetailsTest {
+    @Test
+    fun `if homeserver supports oidc, then it is supported`() {
+        val sut = aMatrixHomeServerDetails(
+            supportsOidcLogin = true,
+            supportsPasswordLogin = false,
+        )
+        assertThat(sut.isSupported).isTrue()
+    }
+
+    @Test
+    fun `if homeserver supports password, then it is supported`() {
+        val sut = aMatrixHomeServerDetails(
+            supportsOidcLogin = false,
+            supportsPasswordLogin = true,
+        )
+        assertThat(sut.isSupported).isTrue()
+    }
+
+    @Test
+    fun `if homeserver supports both, then it is supported`() {
+        val sut = aMatrixHomeServerDetails(
+            supportsOidcLogin = true,
+            supportsPasswordLogin = true,
+        )
+        assertThat(sut.isSupported).isTrue()
+    }
+
+    @Test
+    fun `if homeserver supports none, then it is not supported`() {
+        val sut = aMatrixHomeServerDetails(
+            supportsOidcLogin = false,
+            supportsPasswordLogin = false,
+        )
+        assertThat(sut.isSupported).isFalse()
+    }
+}

features/login/impl/src/test/kotlin/io/element/android/features/login/impl/MatrixHomeServerDetails.kt renamed to libraries/matrix/test/src/main/kotlin/io/element/android/libraries/matrix/test/auth/MatrixHomeServerDetails.kt

@@ -5,7 +5,7 @@
  * Please see LICENSE files in the repository root for full details.
  */
 
-package io.element.android.features.login.impl
+package io.element.android.libraries.matrix.test.auth
 
 import io.element.android.libraries.matrix.api.auth.MatrixHomeServerDetails
 import io.element.android.libraries.matrix.test.A_HOMESERVER_URL