test (event action): clean test

ganfra · ganfra · commit 713bae06b01b · 2025-06-18T16:45:48.000+02:00
diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/actionlist/ActionListPresenterTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/actionlist/ActionListPresenterTest.kt
@@ -81,8 +81,6 @@ class ActionListPresenterTest {
                     )
                 )
             )
-            // val loadingState = awaitItem()
-            // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))
             val successState = awaitItem()
             assertThat(successState.target).isEqualTo(
                 ActionListState.Target.Success(
@@ -124,8 +122,6 @@ class ActionListPresenterTest {
                     )
                 )
             )
-            // val loadingState = awaitItem()
-            // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))
             val successState = awaitItem()
             assertThat(successState.target).isEqualTo(
                 ActionListState.Target.Success(
@@ -167,8 +163,6 @@ class ActionListPresenterTest {
                     )
                 )
             )
-            // val loadingState = awaitItem()
-            // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))
             val successState = awaitItem()
             assertThat(successState.target).isEqualTo(
                 ActionListState.Target.Success(
@@ -262,8 +256,6 @@ class ActionListPresenterTest {
                     )
                 )
             )
-            // val loadingState = awaitItem()
-            // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))
             val successState = awaitItem()
             assertThat(successState.target).isEqualTo(
                 ActionListState.Target.Success(
@@ -405,8 +397,6 @@ class ActionListPresenterTest {
                     )
                 )
             )
-            // val loadingState = awaitItem()
-            // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))
             val successState = awaitItem()
             assertThat(successState.target).isEqualTo(
                 ActionListState.Target.Success(
@@ -500,8 +490,6 @@ class ActionListPresenterTest {
                     )
                 )
             )
-            // val loadingState = awaitItem()
-            // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))
             val successState = awaitItem()
             assertThat(successState.target).isEqualTo(
                 ActionListState.Target.Success(
@@ -526,7 +514,7 @@ class ActionListPresenterTest {
     }
 
     @Test
-    fun `present - compute for my message no permission `() = runTest {
+    fun `present - compute for my message no permission`() = runTest {
         val presenter = createActionListPresenter(isDeveloperModeEnabled = true, isPinFeatureEnabled = true)
         moleculeFlow(RecompositionMode.Immediate) {
             presenter.present()
@@ -548,8 +536,6 @@ class ActionListPresenterTest {
                     )
                 )
             )
-            // val loadingState = awaitItem()
-            // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))
             val successState = awaitItem()
             assertThat(successState.target).isEqualTo(
                 ActionListState.Target.Success(
@@ -792,8 +778,6 @@ class ActionListPresenterTest {
                     )
                 )
             )
-            // val loadingState = awaitItem()
-            // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))
             val successState = awaitItem()
             assertThat(successState.target).isEqualTo(
                 ActionListState.Target.Success(
@@ -834,8 +818,6 @@ class ActionListPresenterTest {
                     )
                 )
             )
-            // val loadingState = awaitItem()
-            // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))
             assertThat(awaitItem().target).isEqualTo(ActionListState.Target.None)
         }
     }
@@ -863,8 +845,6 @@ class ActionListPresenterTest {
                     )
                 )
             )
-            // val loadingState = awaitItem()
-            // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))
             val successState = awaitItem()
             assertThat(successState.target).isEqualTo(
                 ActionListState.Target.Success(
@@ -911,8 +891,6 @@ class ActionListPresenterTest {
                     )
                 )
             )
-            // val loadingState = awaitItem()
-            // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))
             val successState = awaitItem()
             assertThat(successState.target).isEqualTo(
                 ActionListState.Target.Success(
@@ -966,8 +944,6 @@ class ActionListPresenterTest {
                     )
                 )
             )
-            // val loadingState = awaitItem()
-            // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))
             val successState = awaitItem()
             assertThat(successState.target).isEqualTo(
                 ActionListState.Target.Success(

Original file line number	Diff line number	Diff line change
`@@ -81,8 +81,6 @@ class ActionListPresenterTest {`
`81`	`81`	`)`
`82`	`82`	`)`
`83`	`83`	`)`
`84`		`- // val loadingState = awaitItem()`
`85`		`- // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))`
`86`	`84`	`val successState = awaitItem()`
`87`	`85`	`assertThat(successState.target).isEqualTo(`
`88`	`86`	`ActionListState.Target.Success(`
`@@ -124,8 +122,6 @@ class ActionListPresenterTest {`
`124`	`122`	`)`
`125`	`123`	`)`
`126`	`124`	`)`
`127`		`- // val loadingState = awaitItem()`
`128`		`- // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))`
`129`	`125`	`val successState = awaitItem()`
`130`	`126`	`assertThat(successState.target).isEqualTo(`
`131`	`127`	`ActionListState.Target.Success(`
`@@ -167,8 +163,6 @@ class ActionListPresenterTest {`
`167`	`163`	`)`
`168`	`164`	`)`
`169`	`165`	`)`
`170`		`- // val loadingState = awaitItem()`
`171`		`- // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))`
`172`	`166`	`val successState = awaitItem()`
`173`	`167`	`assertThat(successState.target).isEqualTo(`
`174`	`168`	`ActionListState.Target.Success(`
`@@ -262,8 +256,6 @@ class ActionListPresenterTest {`
`262`	`256`	`)`
`263`	`257`	`)`
`264`	`258`	`)`
`265`		`- // val loadingState = awaitItem()`
`266`		`- // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))`
`267`	`259`	`val successState = awaitItem()`
`268`	`260`	`assertThat(successState.target).isEqualTo(`
`269`	`261`	`ActionListState.Target.Success(`
`@@ -405,8 +397,6 @@ class ActionListPresenterTest {`
`405`	`397`	`)`
`406`	`398`	`)`
`407`	`399`	`)`
`408`		`- // val loadingState = awaitItem()`
`409`		`- // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))`
`410`	`400`	`val successState = awaitItem()`
`411`	`401`	`assertThat(successState.target).isEqualTo(`
`412`	`402`	`ActionListState.Target.Success(`
`@@ -500,8 +490,6 @@ class ActionListPresenterTest {`
`500`	`490`	`)`
`501`	`491`	`)`
`502`	`492`	`)`
`503`		`- // val loadingState = awaitItem()`
`504`		`- // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))`
`505`	`493`	`val successState = awaitItem()`
`506`	`494`	`assertThat(successState.target).isEqualTo(`
`507`	`495`	`ActionListState.Target.Success(`
`@@ -526,7 +514,7 @@ class ActionListPresenterTest {`
`526`	`514`	`}`
`527`	`515`
`528`	`516`	`@Test`
`529`		- fun `present - compute for my message no permission `() = runTest {
	`517`	+ fun `present - compute for my message no permission`() = runTest {
`530`	`518`	`val presenter = createActionListPresenter(isDeveloperModeEnabled = true, isPinFeatureEnabled = true)`
`531`	`519`	`moleculeFlow(RecompositionMode.Immediate) {`
`532`	`520`	`presenter.present()`
`@@ -548,8 +536,6 @@ class ActionListPresenterTest {`
`548`	`536`	`)`
`549`	`537`	`)`
`550`	`538`	`)`
`551`		`- // val loadingState = awaitItem()`
`552`		`- // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))`
`553`	`539`	`val successState = awaitItem()`
`554`	`540`	`assertThat(successState.target).isEqualTo(`
`555`	`541`	`ActionListState.Target.Success(`
`@@ -792,8 +778,6 @@ class ActionListPresenterTest {`
`792`	`778`	`)`
`793`	`779`	`)`
`794`	`780`	`)`
`795`		`- // val loadingState = awaitItem()`
`796`		`- // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))`
`797`	`781`	`val successState = awaitItem()`
`798`	`782`	`assertThat(successState.target).isEqualTo(`
`799`	`783`	`ActionListState.Target.Success(`
`@@ -834,8 +818,6 @@ class ActionListPresenterTest {`
`834`	`818`	`)`
`835`	`819`	`)`
`836`	`820`	`)`
`837`		`- // val loadingState = awaitItem()`
`838`		`- // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))`
`839`	`821`	`assertThat(awaitItem().target).isEqualTo(ActionListState.Target.None)`
`840`	`822`	`}`
`841`	`823`	`}`
`@@ -863,8 +845,6 @@ class ActionListPresenterTest {`
`863`	`845`	`)`
`864`	`846`	`)`
`865`	`847`	`)`
`866`		`- // val loadingState = awaitItem()`
`867`		`- // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))`
`868`	`848`	`val successState = awaitItem()`
`869`	`849`	`assertThat(successState.target).isEqualTo(`
`870`	`850`	`ActionListState.Target.Success(`
`@@ -911,8 +891,6 @@ class ActionListPresenterTest {`
`911`	`891`	`)`
`912`	`892`	`)`
`913`	`893`	`)`
`914`		`- // val loadingState = awaitItem()`
`915`		`- // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))`
`916`	`894`	`val successState = awaitItem()`
`917`	`895`	`assertThat(successState.target).isEqualTo(`
`918`	`896`	`ActionListState.Target.Success(`
`@@ -966,8 +944,6 @@ class ActionListPresenterTest {`
`966`	`944`	`)`
`967`	`945`	`)`
`968`	`946`	`)`
`969`		`- // val loadingState = awaitItem()`
`970`		`- // assertThat(loadingState.target).isEqualTo(ActionListState.Target.Loading(messageEvent))`
`971`	`947`	`val successState = awaitItem()`
`972`	`948`	`assertThat(successState.target).isEqualTo(`
`973`	`949`	`ActionListState.Target.Success(`