Skip to content

Commit 751f7e7

Browse files
committed
Rename DoAction to more specific RequestDisableOptimizations
1 parent cce2f33 commit 751f7e7

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

features/roomlist/impl/src/main/kotlin/io/element/android/features/roomlist/impl/components/BatteryOptimizationBanner.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ internal fun BatteryOptimizationBanner(
3030
description = stringResource(R.string.banner_battery_optimization_content_android),
3131
type = AnnouncementType.Actionable(
3232
actionText = stringResource(R.string.banner_battery_optimization_submit_android),
33-
onActionClick = { state.eventSink(BatteryOptimizationEvents.DoAction) },
33+
onActionClick = { state.eventSink(BatteryOptimizationEvents.RequestDisableOptimizations) },
3434
onDismissClick = { state.eventSink(BatteryOptimizationEvents.Dismiss) },
3535
),
3636
)

libraries/push/api/src/main/kotlin/io/element/android/libraries/push/api/battery/BatteryOptimizationEvents.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ package io.element.android.libraries.push.api.battery
99

1010
sealed interface BatteryOptimizationEvents {
1111
data object Dismiss : BatteryOptimizationEvents
12-
data object DoAction : BatteryOptimizationEvents
12+
data object RequestDisableOptimizations : BatteryOptimizationEvents
1313
}

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/battery/BatteryOptimizationPresenter.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class BatteryOptimizationPresenter @Inject constructor(
5151
BatteryOptimizationEvents.Dismiss -> coroutineScope.launch {
5252
mutableBatteryOptimizationStore.onOptimizationBannerDismissed()
5353
}
54-
BatteryOptimizationEvents.DoAction -> {
54+
BatteryOptimizationEvents.RequestDisableOptimizations -> {
5555
isRequestSent = true
5656
if (batteryOptimization.requestDisablingBatteryOptimization().not()) {
5757
// If not able to perform the request, ensure that we do not display the banner again

libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/battery/BatteryOptimizationPresenterTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ class BatteryOptimizationPresenterTest {
123123
assertThat(initialState.shouldDisplayBanner).isFalse()
124124
val displayedItem = awaitItem()
125125
assertThat(displayedItem.shouldDisplayBanner).isTrue()
126-
displayedItem.eventSink(BatteryOptimizationEvents.DoAction)
126+
displayedItem.eventSink(BatteryOptimizationEvents.RequestDisableOptimizations)
127127
requestDisablingBatteryOptimizationResult.assertions().isCalledOnce()
128128
onOptimizationBannerDismissedResult.assertions().isCalledOnce()
129129
}
@@ -149,7 +149,7 @@ class BatteryOptimizationPresenterTest {
149149
assertThat(initialState.shouldDisplayBanner).isFalse()
150150
val displayedItem = awaitItem()
151151
assertThat(displayedItem.shouldDisplayBanner).isTrue()
152-
displayedItem.eventSink(BatteryOptimizationEvents.DoAction)
152+
displayedItem.eventSink(BatteryOptimizationEvents.RequestDisableOptimizations)
153153
requestDisablingBatteryOptimizationResult.assertions().isCalledOnce()
154154
batteryOptimization.isIgnoringBatteryOptimizationsResult = true
155155
lifeCycleOwner.givenState(Lifecycle.State.RESUMED)

0 commit comments

Comments
 (0)