Skip to content

Commit 818af20

Browse files
committed
feat(join by alias) : use localazy strings
1 parent b42825c commit 818af20

File tree

4 files changed

+16
-8
lines changed

4 files changed

+16
-8
lines changed

features/createroom/impl/src/main/kotlin/io/element/android/features/createroom/impl/joinbyaddress/JoinRoomByAddressView.kt

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import androidx.compose.ui.text.input.KeyboardCapitalization
2929
import androidx.compose.ui.text.input.KeyboardType
3030
import androidx.compose.ui.tooling.preview.PreviewParameter
3131
import androidx.compose.ui.unit.dp
32+
import io.element.android.features.createroom.impl.R
3233
import io.element.android.libraries.designsystem.preview.ElementPreview
3334
import io.element.android.libraries.designsystem.preview.PreviewsDayNight
3435
import io.element.android.libraries.designsystem.theme.components.Button
@@ -97,13 +98,13 @@ private fun RoomAddressField(
9798
TextField(
9899
modifier = modifier.focusRequester(focusRequester),
99100
value = address,
100-
label = "Join room by address",
101-
placeholder = "Enter...",
101+
label = stringResource(R.string.screen_start_chat_join_room_by_address_action),
102+
placeholder = stringResource(R.string.screen_start_chat_join_room_by_address_placeholder),
102103
supportingText = when (addressState) {
103-
RoomAddressState.Invalid -> "Not a valid address"
104-
is RoomAddressState.RoomFound -> "Matching room found"
105-
RoomAddressState.RoomNotFound -> "Room not found"
106-
RoomAddressState.Unknown, RoomAddressState.Resolving -> "e.g. #room-name:matrix.org"
104+
RoomAddressState.Invalid -> stringResource(R.string.screen_start_chat_join_room_by_address_invalid_address)
105+
is RoomAddressState.RoomFound -> stringResource(R.string.screen_start_chat_join_room_by_address_room_found)
106+
RoomAddressState.RoomNotFound -> stringResource(R.string.screen_start_chat_join_room_by_address_room_not_found)
107+
RoomAddressState.Unknown, RoomAddressState.Resolving -> stringResource(R.string.screen_start_chat_join_room_by_address_supporting_text)
107108
},
108109
validity = when (addressState) {
109110
RoomAddressState.Unknown, RoomAddressState.Resolving -> null

features/createroom/impl/src/main/kotlin/io/element/android/features/createroom/impl/root/CreateRoomRootView.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ private fun CreateRoomActionButtonsList(
176176
item {
177177
CreateRoomActionButton(
178178
iconRes = CompoundDrawables.ic_compound_room,
179-
text = "Join room by address",
179+
text = stringResource(R.string.screen_start_chat_join_room_by_address_action),
180180
onClick = onJoinByAddressClick,
181181
)
182182
}

features/createroom/impl/src/main/res/values/localazy.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,10 @@ You can change this anytime in room settings."</string>
2020
<string name="screen_create_room_title">"Create a room"</string>
2121
<string name="screen_create_room_topic_label">"Topic (optional)"</string>
2222
<string name="screen_start_chat_error_starting_chat">"An error occurred when trying to start a chat"</string>
23+
<string name="screen_start_chat_join_room_by_address_action">"Join room by address"</string>
24+
<string name="screen_start_chat_join_room_by_address_invalid_address">"Not a valid address"</string>
25+
<string name="screen_start_chat_join_room_by_address_placeholder">"Enter…"</string>
26+
<string name="screen_start_chat_join_room_by_address_room_found">"Matching room found"</string>
27+
<string name="screen_start_chat_join_room_by_address_room_not_found">"Room not found"</string>
28+
<string name="screen_start_chat_join_room_by_address_supporting_text">"e.g. #room-name:matrix.org"</string>
2329
</resources>

tools/localazy/config.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@
6464
"includeRegex" : [
6565
"screen_create_room_.*",
6666
"screen\\.create_room\\..*",
67-
"screen_start_chat_.*"
67+
"screen_start_chat_.*",
68+
"screen\\.start_chat\\..*"
6869
]
6970
},
7071
{

0 commit comments

Comments
 (0)