Merge pull request #1160 from vector-im/feature/bma/fixOpeningRoomCrash

bmarty · web-flow · commit 86ad01cbd8d2 · 2023-08-28T17:16:09.000+02:00
Add missing plugin forward between `LoggedInAppScopeFlowNode` and `LoggedInFlowNode`
diff --git a/appnav/src/main/kotlin/io/element/android/appnav/LoggedInAppScopeFlowNode.kt b/appnav/src/main/kotlin/io/element/android/appnav/LoggedInAppScopeFlowNode.kt
@@ -102,7 +102,8 @@ class LoggedInAppScopeFlowNode @AssistedInject constructor(
                         plugins<Callback>().forEach { it.onOpenBugReport() }
                     }
                 }
-                createNode<LoggedInFlowNode>(buildContext, listOf(callback))
+                val nodeLifecycleCallbacks = plugins<NodeLifecycleCallback>()
+                createNode<LoggedInFlowNode>(buildContext, nodeLifecycleCallbacks + callback)
             }
         }
     }
diff --git a/changelog.d/1160.bugfix b/changelog.d/1160.bugfix
@@ -0,0 +1 @@
+Fix crash when opening any room.

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,8 @@ class LoggedInAppScopeFlowNode @AssistedInject constructor(`
`102`	`102`	`plugins<Callback>().forEach { it.onOpenBugReport() }`
`103`	`103`	`}`
`104`	`104`	`}`
`105`		`- createNode<LoggedInFlowNode>(buildContext, listOf(callback))`
	`105`	`+ val nodeLifecycleCallbacks = plugins<NodeLifecycleCallback>()`
	`106`	`+ createNode<LoggedInFlowNode>(buildContext, nodeLifecycleCallbacks + callback)`
`106`	`107`	`}`
`107`	`108`	`}`
`108`	`109`	`}`