Skip to content

Commit 9536afe

Browse files
authored
Try fixing Maestro tests (again) (#6149)
* Try fixing Maestro tests again: they fail when creating a room because the texts have changed * Try using a retry on the webview before the login so we skip Chrome's setup * Try handling edge case when leaving a room does not remove the screen
1 parent f4a61ec commit 9536afe

File tree

3 files changed

+38
-22
lines changed

3 files changed

+38
-22
lines changed

.maestro/tests/account/login.yaml

Lines changed: 26 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -9,29 +9,35 @@ appId: ${MAESTRO_APP_ID}
99
id: "login-continue"
1010
## MAS page
1111
## Conditional workflow to pass the Chrome first launch welcome page.
12-
- runFlow:
13-
when:
14-
visible: 'Use without an account'
12+
- retry:
13+
maxRetries: 3
1514
commands:
16-
- tapOn: "Use without an account"
17-
## For older chrome versions
18-
- runFlow:
19-
when:
20-
visible: 'Accept & continue'
21-
commands:
22-
- tapOn: "Accept & continue"
23-
- runFlow:
24-
when:
25-
visible: 'No thanks'
26-
commands:
27-
- tapOn: "No thanks"
15+
- runFlow:
16+
when:
17+
visible: 'Use without an account'
18+
commands:
19+
- tapOn: "Use without an account"
20+
## For older chrome versions
21+
- runFlow:
22+
when:
23+
visible: 'Accept & continue'
24+
commands:
25+
- tapOn: "Accept & continue"
26+
- runFlow:
27+
when:
28+
visible: 'No thanks'
29+
commands:
30+
- tapOn: "No thanks"
2831
## Working when running Maestro locally, but not on the CI yet.
29-
- extendedWaitUntil:
30-
visible:
31-
id: "form-1"
32-
timeout: 10000
32+
- retry:
33+
maxRetries: 3
34+
commands:
35+
- extendedWaitUntil:
36+
visible:
37+
id: "form-1"
38+
timeout: 10000
3339
- tapOn:
34-
id: "form-1"
40+
id: "form-1"
3541
- inputText: ${MAESTRO_USERNAME}
3642
- pressKey: Enter
3743
- tapOn:

.maestro/tests/roomList/createAndDeleteDM.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,8 @@ appId: ${MAESTRO_APP_ID}
1313
- scroll
1414
- tapOn: "Leave room"
1515
- tapOn: "Leave"
16+
- runFlow:
17+
when:
18+
visible: 'You need an invite in order to join'
19+
commands:
20+
- tapOn: "Back"

.maestro/tests/roomList/createAndDeleteRoom.yaml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ appId: ${MAESTRO_APP_ID}
33
# Purpose: Test the creation and deletion of a room
44
- tapOn: "Create a new conversation or room"
55
- tapOn: "New room"
6-
- tapOn: "e.g. your project name"
6+
- tapOn: "Add name"
77
- inputText: "aRoomName"
8-
- tapOn: "What is this room about?"
8+
- tapOn: "Add description…"
99
- inputText: "aRoomTopic"
1010
- tapOn: "Create"
1111
- takeScreenshot: build/maestro/320-createAndDeleteRoom
@@ -37,3 +37,8 @@ appId: ${MAESTRO_APP_ID}
3737
- scroll
3838
- tapOn: "Leave room"
3939
- tapOn: "Leave"
40+
- runFlow:
41+
when:
42+
visible: 'You need an invite in order to join'
43+
commands:
44+
- tapOn: "Back"

0 commit comments

Comments
 (0)