Skip to content

Commit 9fbe110

Browse files
authored
Fix flaky incoming verification tests (#4479)
1 parent 48c7e46 commit 9fbe110

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

features/verifysession/impl/src/main/kotlin/io/element/android/features/verifysession/impl/incoming/IncomingVerificationPresenter.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import io.element.android.libraries.matrix.api.verification.SessionVerificationS
3030
import io.element.android.libraries.matrix.api.verification.VerificationFlowState
3131
import io.element.android.libraries.matrix.api.verification.VerificationRequest
3232
import kotlinx.coroutines.CoroutineScope
33-
import kotlinx.coroutines.Dispatchers
3433
import kotlinx.coroutines.ExperimentalCoroutinesApi
3534
import kotlinx.coroutines.flow.launchIn
3635
import kotlinx.coroutines.flow.onEach
@@ -57,7 +56,7 @@ class IncomingVerificationPresenter @AssistedInject constructor(
5756

5857
@Composable
5958
override fun present(): IncomingVerificationState {
60-
val coroutineScope = rememberCoroutineScope { Dispatchers.IO }
59+
val coroutineScope = rememberCoroutineScope()
6160

6261
val stateAndDispatch = stateMachine.rememberStateAndDispatch()
6362

features/verifysession/impl/src/test/kotlin/io/element/android/features/verifysession/impl/incoming/IncomingVerificationPresenterTest.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,9 @@ class IncomingVerificationPresenterTest {
131131
isWaiting = false,
132132
)
133133
)
134+
135+
advanceTimeBy(1.seconds)
136+
134137
resetLambda.assertions().isCalledOnce().with(value(false))
135138
acknowledgeVerificationRequestLambda.assertions().isCalledOnce().with(value(anIncomingSessionVerificationRequest))
136139
acceptVerificationRequestLambda.assertions().isNeverCalled()
@@ -139,7 +142,9 @@ class IncomingVerificationPresenterTest {
139142
skipItems(1)
140143
val initialWaitingState = awaitItem()
141144
assertThat((initialWaitingState.step as IncomingVerificationState.Step.Initial).isWaiting).isTrue()
142-
advanceUntilIdle()
145+
146+
advanceTimeBy(1.seconds)
147+
143148
acceptVerificationRequestLambda.assertions().isCalledOnce()
144149
// Remote sent the data
145150
fakeSessionVerificationService.emitVerificationFlowState(VerificationFlowState.DidAcceptVerificationRequest)

0 commit comments

Comments
 (0)