Add default value for Failure.hasQuickFix

bmarty · bmarty · commit a83fc2aa1d2e · 2025-09-23T09:13:45.000+02:00
diff --git a/libraries/permissions/impl/src/test/kotlin/io/element/android/libraries/permissions/impl/troubleshoot/NotificationTroubleshootCheckPermissionTestTest.kt b/libraries/permissions/impl/src/test/kotlin/io/element/android/libraries/permissions/impl/troubleshoot/NotificationTroubleshootCheckPermissionTestTest.kt
@@ -82,7 +82,7 @@ class NotificationTroubleshootCheckPermissionTestTest {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
             val lastItem = awaitItem()
-            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(true))
+            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(hasQuickFix = true))
             // Quick fix
             launch {
                 sut.quickFix(this, FakeNotificationTroubleshootNavigator())
@@ -116,7 +116,7 @@ class NotificationTroubleshootCheckPermissionTestTest {
         sut.state.test {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
-            assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(true))
+            assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(hasQuickFix = true))
             sut.reset()
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))
         }
diff --git a/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/troubleshoot/CurrentPushProviderTest.kt b/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/troubleshoot/CurrentPushProviderTest.kt
@@ -44,7 +44,7 @@ class CurrentPushProviderTest(
         } else {
             delegate.updateState(
                 description = stringProvider.getString(R.string.troubleshoot_notifications_test_current_push_provider_failure),
-                status = NotificationTroubleshootTestState.Status.Failure(false)
+                status = NotificationTroubleshootTestState.Status.Failure()
             )
         }
     }
diff --git a/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/troubleshoot/NotificationTest.kt b/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/troubleshoot/NotificationTest.kt
@@ -54,7 +54,7 @@ class NotificationTest(
         } else {
             delegate.updateState(
                 description = stringProvider.getString(R.string.troubleshoot_notifications_test_display_notification_permission_failure),
-                status = NotificationTroubleshootTestState.Status.Failure(false)
+                status = NotificationTroubleshootTestState.Status.Failure()
             )
         }
     }
@@ -81,7 +81,7 @@ class NotificationTest(
                 notificationDisplayer.dismissDiagnosticNotification()
                 delegate.updateState(
                     description = stringProvider.getString(R.string.troubleshoot_notifications_test_display_notification_failure),
-                    status = NotificationTroubleshootTestState.Status.Failure(false)
+                    status = NotificationTroubleshootTestState.Status.Failure()
                 )
             }
         )
diff --git a/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/troubleshoot/PushLoopbackTest.kt b/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/troubleshoot/PushLoopbackTest.kt
@@ -57,23 +57,23 @@ class PushLoopbackTest(
             val hasQuickFix = pushService.getCurrentPushProvider()?.canRotateToken() == true
             delegate.updateState(
                 description = stringProvider.getString(R.string.troubleshoot_notifications_test_push_loop_back_failure_1),
-                status = NotificationTroubleshootTestState.Status.Failure(hasQuickFix)
+                status = NotificationTroubleshootTestState.Status.Failure(hasQuickFix = hasQuickFix)
             )
             job.cancel()
             return
         } catch (e: Exception) {
             Timber.e(e, "Failed to test push")
             delegate.updateState(
                 description = stringProvider.getString(R.string.troubleshoot_notifications_test_push_loop_back_failure_2, e.message),
-                status = NotificationTroubleshootTestState.Status.Failure(false)
+                status = NotificationTroubleshootTestState.Status.Failure()
             )
             job.cancel()
             return
         }
         if (!testPushResult) {
             delegate.updateState(
                 description = stringProvider.getString(R.string.troubleshoot_notifications_test_push_loop_back_failure_3),
-                status = NotificationTroubleshootTestState.Status.Failure(false)
+                status = NotificationTroubleshootTestState.Status.Failure()
             )
             job.cancel()
             return
@@ -94,7 +94,7 @@ class PushLoopbackTest(
                 job.cancel()
                 delegate.updateState(
                     description = stringProvider.getString(R.string.troubleshoot_notifications_test_push_loop_back_failure_4),
-                    status = NotificationTroubleshootTestState.Status.Failure(false)
+                    status = NotificationTroubleshootTestState.Status.Failure()
                 )
             }
         )
diff --git a/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/troubleshoot/PushProvidersTest.kt b/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/troubleshoot/PushProvidersTest.kt
@@ -48,7 +48,7 @@ class PushProvidersTest(
         } else {
             delegate.updateState(
                 description = stringProvider.getString(R.string.troubleshoot_notifications_test_detect_push_provider_failure),
-                status = NotificationTroubleshootTestState.Status.Failure(false)
+                status = NotificationTroubleshootTestState.Status.Failure()
             )
         }
     }
diff --git a/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/troubleshoot/CurrentPushProviderTestTest.kt b/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/troubleshoot/CurrentPushProviderTestTest.kt
@@ -48,7 +48,7 @@ class CurrentPushProviderTestTest {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
             val lastItem = awaitItem()
-            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))
+            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure())
             sut.reset()
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))
         }
diff --git a/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/troubleshoot/PushLoopbackTestTest.kt b/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/troubleshoot/PushLoopbackTestTest.kt
@@ -40,7 +40,7 @@ class PushLoopbackTestTest {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
             val lastItem = awaitItem()
-            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))
+            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure())
         }
     }
 
@@ -64,7 +64,7 @@ class PushLoopbackTestTest {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
             val lastItem = awaitItem()
-            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))
+            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure())
             sut.reset()
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))
         }
@@ -97,10 +97,10 @@ class PushLoopbackTestTest {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
             val lastItem = awaitItem()
-            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(true))
+            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(hasQuickFix = true))
             sut.quickFix(this, FakeNotificationTroubleshootNavigator())
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
-            assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(true))
+            assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(hasQuickFix = true))
             rotateTokenLambda.assertions().isCalledOnce()
         }
     }
@@ -123,7 +123,7 @@ class PushLoopbackTestTest {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
             val lastItem = awaitItem()
-            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))
+            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure())
         }
     }
 
@@ -147,7 +147,7 @@ class PushLoopbackTestTest {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
             val lastItem = awaitItem()
-            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))
+            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure())
             assertThat(lastItem.description).contains(A_FAILURE_REASON)
         }
     }
diff --git a/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/troubleshoot/PushProvidersTestTest.kt b/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/troubleshoot/PushProvidersTestTest.kt
@@ -30,7 +30,7 @@ class PushProvidersTestTest {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
             val lastItem = awaitItem()
-            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))
+            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure())
             sut.reset()
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))
         }
diff --git a/libraries/pushproviders/firebase/src/main/kotlin/io/element/android/libraries/pushproviders/firebase/troubleshoot/FirebaseAvailabilityTest.kt b/libraries/pushproviders/firebase/src/main/kotlin/io/element/android/libraries/pushproviders/firebase/troubleshoot/FirebaseAvailabilityTest.kt
@@ -51,7 +51,7 @@ class FirebaseAvailabilityTest(
         } else {
             delegate.updateState(
                 description = stringProvider.getString(R.string.troubleshoot_notifications_test_firebase_availability_failure),
-                status = NotificationTroubleshootTestState.Status.Failure(false)
+                status = NotificationTroubleshootTestState.Status.Failure()
             )
         }
     }
diff --git a/libraries/pushproviders/firebase/src/main/kotlin/io/element/android/libraries/pushproviders/firebase/troubleshoot/FirebaseTokenTest.kt b/libraries/pushproviders/firebase/src/main/kotlin/io/element/android/libraries/pushproviders/firebase/troubleshoot/FirebaseTokenTest.kt
@@ -63,7 +63,7 @@ class FirebaseTokenTest(
                 } else {
                     delegate.updateState(
                         description = stringProvider.getString(R.string.troubleshoot_notifications_test_firebase_token_failure),
-                        status = NotificationTroubleshootTestState.Status.Failure(true)
+                        status = NotificationTroubleshootTestState.Status.Failure(hasQuickFix = true)
                     )
                 }
             }
diff --git a/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/troubleshoot/FirebaseAvailabilityTestTest.kt b/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/troubleshoot/FirebaseAvailabilityTestTest.kt
@@ -49,7 +49,7 @@ class FirebaseAvailabilityTestTest {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(false))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
             val lastItem = awaitItem()
-            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))
+            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure())
             sut.reset()
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(false))
         }
diff --git a/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/troubleshoot/FirebaseTokenTestTest.kt b/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/troubleshoot/FirebaseTokenTestTest.kt
@@ -61,7 +61,7 @@ class FirebaseTokenTestTest {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(false))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
             val lastItem = awaitItem()
-            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(true))
+            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(hasQuickFix = true))
             // Quick fix
             sut.quickFix(this, FakeNotificationTroubleshootNavigator())
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
@@ -88,7 +88,7 @@ class FirebaseTokenTestTest {
         sut.state.test {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(false))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
-            assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(true))
+            assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(hasQuickFix = true))
             sut.reset()
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(false))
         }
diff --git a/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushMatrixGatewayTest.kt b/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushMatrixGatewayTest.kt
@@ -48,7 +48,7 @@ class UnifiedPushMatrixGatewayTest(
         if (config == null) {
             delegate.updateState(
                 description = "No current push provider",
-                status = NotificationTroubleshootTestState.Status.Failure(false)
+                status = NotificationTroubleshootTestState.Status.Failure()
             )
         } else {
             val gatewayBaseUrl = config.url.removeSuffix("/_matrix/push/v1/notify")
@@ -65,13 +65,13 @@ class UnifiedPushMatrixGatewayTest(
                     } else {
                         delegate.updateState(
                             description = "${config.url} is not a Matrix gateway.",
-                            status = NotificationTroubleshootTestState.Status.Failure(false)
+                            status = NotificationTroubleshootTestState.Status.Failure()
                         )
                     }
                 } catch (throwable: Throwable) {
                     delegate.updateState(
                         description = "Fail to check the gateway ${config.url}: ${throwable.localizedMessage}",
-                        status = NotificationTroubleshootTestState.Status.Failure(false)
+                        status = NotificationTroubleshootTestState.Status.Failure()
                     )
                 }
             }
diff --git a/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushTest.kt b/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushTest.kt
@@ -58,7 +58,7 @@ class UnifiedPushTest(
         } else {
             delegate.updateState(
                 description = stringProvider.getString(R.string.troubleshoot_notifications_test_unified_push_failure),
-                status = NotificationTroubleshootTestState.Status.Failure(true)
+                status = NotificationTroubleshootTestState.Status.Failure(hasQuickFix = true)
             )
         }
     }
diff --git a/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushMatrixGatewayTestTest.kt b/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushMatrixGatewayTestTest.kt
@@ -55,7 +55,7 @@ class UnifiedPushMatrixGatewayTestTest {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(false))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
             val lastItem = awaitItem()
-            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))
+            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure())
         }
     }
 
@@ -72,7 +72,7 @@ class UnifiedPushMatrixGatewayTestTest {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(false))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
             val lastItem = awaitItem()
-            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))
+            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure())
             // Reset the error
             sut.reset()
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(false))
@@ -92,7 +92,7 @@ class UnifiedPushMatrixGatewayTestTest {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(false))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
             val lastItem = awaitItem()
-            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))
+            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure())
         }
     }
 
diff --git a/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushTestTest.kt b/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushTestTest.kt
@@ -65,7 +65,7 @@ class UnifiedPushTestTest {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(false))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
             val lastItem = awaitItem()
-            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(true))
+            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(hasQuickFix = true))
             // Quick fix
             launch {
                 sut.quickFix(this, FakeNotificationTroubleshootNavigator())
@@ -99,7 +99,7 @@ class UnifiedPushTestTest {
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(false))
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)
             val lastItem = awaitItem()
-            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(true))
+            assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(hasQuickFix = true))
             sut.reset()
             assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(false))
         }
diff --git a/libraries/troubleshoot/api/src/main/kotlin/io/element/android/libraries/troubleshoot/api/test/NotificationTroubleshootTestDelegate.kt b/libraries/troubleshoot/api/src/main/kotlin/io/element/android/libraries/troubleshoot/api/test/NotificationTroubleshootTestDelegate.kt
@@ -60,7 +60,7 @@ class NotificationTroubleshootTestDelegate(
             if (isSuccess) {
                 NotificationTroubleshootTestState.Status.Success
             } else {
-                NotificationTroubleshootTestState.Status.Failure(hasQuickFix)
+                NotificationTroubleshootTestState.Status.Failure(hasQuickFix = hasQuickFix)
             }
         )
     }
diff --git a/libraries/troubleshoot/api/src/main/kotlin/io/element/android/libraries/troubleshoot/api/test/NotificationTroubleshootTestState.kt b/libraries/troubleshoot/api/src/main/kotlin/io/element/android/libraries/troubleshoot/api/test/NotificationTroubleshootTestState.kt
@@ -18,7 +18,7 @@ data class NotificationTroubleshootTestState(
         data object WaitingForUser : Status
         data object Success : Status
         data class Failure(
-            val hasQuickFix: Boolean,
+            val hasQuickFix: Boolean = false,
             val isCritical: Boolean = true,
             val quickFixButtonString: String? = null,
         ) : Status

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ class CurrentPushProviderTest(`
`44`	`44`	`} else {`
`45`	`45`	`delegate.updateState(`
`46`	`46`	`description = stringProvider.getString(R.string.troubleshoot_notifications_test_current_push_provider_failure),`
`47`		`- status = NotificationTroubleshootTestState.Status.Failure(false)`
	`47`	`+ status = NotificationTroubleshootTestState.Status.Failure()`
`48`	`48`	`)`
`49`	`49`	`}`
`50`	`50`	`}`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ class NotificationTest(`
`54`	`54`	`} else {`
`55`	`55`	`delegate.updateState(`
`56`	`56`	`description = stringProvider.getString(R.string.troubleshoot_notifications_test_display_notification_permission_failure),`
`57`		`- status = NotificationTroubleshootTestState.Status.Failure(false)`
	`57`	`+ status = NotificationTroubleshootTestState.Status.Failure()`
`58`	`58`	`)`
`59`	`59`	`}`
`60`	`60`	`}`
`@@ -81,7 +81,7 @@ class NotificationTest(`
`81`	`81`	`notificationDisplayer.dismissDiagnosticNotification()`
`82`	`82`	`delegate.updateState(`
`83`	`83`	`description = stringProvider.getString(R.string.troubleshoot_notifications_test_display_notification_failure),`
`84`		`- status = NotificationTroubleshootTestState.Status.Failure(false)`
	`84`	`+ status = NotificationTroubleshootTestState.Status.Failure()`
`85`	`85`	`)`
`86`	`86`	`}`
`87`	`87`	`)`
Original file line number	Diff line number	Diff line change
`@@ -57,23 +57,23 @@ class PushLoopbackTest(`
`57`	`57`	`val hasQuickFix = pushService.getCurrentPushProvider()?.canRotateToken() == true`
`58`	`58`	`delegate.updateState(`
`59`	`59`	`description = stringProvider.getString(R.string.troubleshoot_notifications_test_push_loop_back_failure_1),`
`60`		`- status = NotificationTroubleshootTestState.Status.Failure(hasQuickFix)`
	`60`	`+ status = NotificationTroubleshootTestState.Status.Failure(hasQuickFix = hasQuickFix)`
`61`	`61`	`)`
`62`	`62`	`job.cancel()`
`63`	`63`	`return`
`64`	`64`	`} catch (e: Exception) {`
`65`	`65`	`Timber.e(e, "Failed to test push")`
`66`	`66`	`delegate.updateState(`
`67`	`67`	`description = stringProvider.getString(R.string.troubleshoot_notifications_test_push_loop_back_failure_2, e.message),`
`68`		`- status = NotificationTroubleshootTestState.Status.Failure(false)`
	`68`	`+ status = NotificationTroubleshootTestState.Status.Failure()`
`69`	`69`	`)`
`70`	`70`	`job.cancel()`
`71`	`71`	`return`
`72`	`72`	`}`
`73`	`73`	`if (!testPushResult) {`
`74`	`74`	`delegate.updateState(`
`75`	`75`	`description = stringProvider.getString(R.string.troubleshoot_notifications_test_push_loop_back_failure_3),`
`76`		`- status = NotificationTroubleshootTestState.Status.Failure(false)`
	`76`	`+ status = NotificationTroubleshootTestState.Status.Failure()`
`77`	`77`	`)`
`78`	`78`	`job.cancel()`
`79`	`79`	`return`
`@@ -94,7 +94,7 @@ class PushLoopbackTest(`
`94`	`94`	`job.cancel()`
`95`	`95`	`delegate.updateState(`
`96`	`96`	`description = stringProvider.getString(R.string.troubleshoot_notifications_test_push_loop_back_failure_4),`
`97`		`- status = NotificationTroubleshootTestState.Status.Failure(false)`
	`97`	`+ status = NotificationTroubleshootTestState.Status.Failure()`
`98`	`98`	`)`
`99`	`99`	`}`
`100`	`100`	`)`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ class PushProvidersTest(`
`48`	`48`	`} else {`
`49`	`49`	`delegate.updateState(`
`50`	`50`	`description = stringProvider.getString(R.string.troubleshoot_notifications_test_detect_push_provider_failure),`
`51`		`- status = NotificationTroubleshootTestState.Status.Failure(false)`
	`51`	`+ status = NotificationTroubleshootTestState.Status.Failure()`
`52`	`52`	`)`
`53`	`53`	`}`
`54`	`54`	`}`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ class CurrentPushProviderTestTest {`
`48`	`48`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))`
`49`	`49`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)`
`50`	`50`	`val lastItem = awaitItem()`
`51`		`- assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))`
	`51`	`+ assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure())`
`52`	`52`	`sut.reset()`
`53`	`53`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))`
`54`	`54`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ class PushLoopbackTestTest {`
`40`	`40`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))`
`41`	`41`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)`
`42`	`42`	`val lastItem = awaitItem()`
`43`		`- assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))`
	`43`	`+ assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure())`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`
`@@ -64,7 +64,7 @@ class PushLoopbackTestTest {`
`64`	`64`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))`
`65`	`65`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)`
`66`	`66`	`val lastItem = awaitItem()`
`67`		`- assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))`
	`67`	`+ assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure())`
`68`	`68`	`sut.reset()`
`69`	`69`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))`
`70`	`70`	`}`
`@@ -97,10 +97,10 @@ class PushLoopbackTestTest {`
`97`	`97`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))`
`98`	`98`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)`
`99`	`99`	`val lastItem = awaitItem()`
`100`		`- assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(true))`
	`100`	`+ assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(hasQuickFix = true))`
`101`	`101`	`sut.quickFix(this, FakeNotificationTroubleshootNavigator())`
`102`	`102`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)`
`103`		`- assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(true))`
	`103`	`+ assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(hasQuickFix = true))`
`104`	`104`	`rotateTokenLambda.assertions().isCalledOnce()`
`105`	`105`	`}`
`106`	`106`	`}`
`@@ -123,7 +123,7 @@ class PushLoopbackTestTest {`
`123`	`123`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))`
`124`	`124`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)`
`125`	`125`	`val lastItem = awaitItem()`
`126`		`- assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))`
	`126`	`+ assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure())`
`127`	`127`	`}`
`128`	`128`	`}`
`129`	`129`
`@@ -147,7 +147,7 @@ class PushLoopbackTestTest {`
`147`	`147`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))`
`148`	`148`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)`
`149`	`149`	`val lastItem = awaitItem()`
`150`		`- assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))`
	`150`	`+ assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure())`
`151`	`151`	`assertThat(lastItem.description).contains(A_FAILURE_REASON)`
`152`	`152`	`}`
`153`	`153`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class PushProvidersTestTest {`
`30`	`30`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))`
`31`	`31`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.InProgress)`
`32`	`32`	`val lastItem = awaitItem()`
`33`		`- assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure(false))`
	`33`	`+ assertThat(lastItem.status).isEqualTo(NotificationTroubleshootTestState.Status.Failure())`
`34`	`34`	`sut.reset()`
`35`	`35`	`assertThat(awaitItem().status).isEqualTo(NotificationTroubleshootTestState.Status.Idle(true))`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ class FirebaseAvailabilityTest(`
`51`	`51`	`} else {`
`52`	`52`	`delegate.updateState(`
`53`	`53`	`description = stringProvider.getString(R.string.troubleshoot_notifications_test_firebase_availability_failure),`
`54`		`- status = NotificationTroubleshootTestState.Status.Failure(false)`
	`54`	`+ status = NotificationTroubleshootTestState.Status.Failure()`
`55`	`55`	`)`
`56`	`56`	`}`
`57`	`57`	`}`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ class FirebaseTokenTest(`
`63`	`63`	`} else {`
`64`	`64`	`delegate.updateState(`
`65`	`65`	`description = stringProvider.getString(R.string.troubleshoot_notifications_test_firebase_token_failure),`
`66`		`- status = NotificationTroubleshootTestState.Status.Failure(true)`
	`66`	`+ status = NotificationTroubleshootTestState.Status.Failure(hasQuickFix = true)`
`67`	`67`	`)`
`68`	`68`	`}`
`69`	`69`	`}`