Skip to content

Commit bdc6cdd

Browse files
author
Marco Romano
authored
Optimize WarmUpRule #1310
This PR is made of 2 commits. The first is just a mass rename in order to spare 1 line of code every time `WarmUpRule` is used. The second tweaks `WarmUpRule` so that the warmup code is only run once per test class.
2 parents b426084 + 8881f97 commit bdc6cdd

File tree

54 files changed

+69
-117
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+69
-117
lines changed

appnav/src/test/kotlin/io/element/android/appnav/RootPresenterTest.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ import org.junit.Rule
3737
import org.junit.Test
3838

3939
class RootPresenterTest {
40-
@Rule
41-
@JvmField
40+
@get:Rule
4241
val warmUpRule = WarmUpRule()
4342

4443
@Test

appnav/src/test/kotlin/io/element/android/appnav/loggedin/LoggedInPresenterTest.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ import org.junit.Test
3737

3838
class LoggedInPresenterTest {
3939

40-
@Rule
41-
@JvmField
40+
@get:Rule
4241
val warmUpRule = WarmUpRule()
4342

4443
@Test

features/analytics/impl/src/test/kotlin/io/element/android/features/analytics/impl/AnalyticsOptInPresenterTest.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ import org.junit.Test
3131

3232
class AnalyticsOptInPresenterTest {
3333

34-
@Rule
35-
@JvmField
34+
@get:Rule
3635
val warmUpRule = WarmUpRule()
3736

3837
@Test

features/analytics/impl/src/test/kotlin/io/element/android/features/analytics/impl/preferences/AnalyticsPreferencesPresenterTest.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ import org.junit.Test
3030

3131
class AnalyticsPreferencesPresenterTest {
3232

33-
@Rule
34-
@JvmField
33+
@get:Rule
3534
val warmUpRule = WarmUpRule()
3635

3736
@Test

features/createroom/impl/src/test/kotlin/io/element/android/features/createroom/impl/addpeople/AddPeoplePresenterTests.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ import org.junit.Test
3232

3333
class AddPeoplePresenterTests {
3434

35-
@Rule
36-
@JvmField
35+
@get:Rule
3736
val warmUpRule = WarmUpRule()
3837

3938
private lateinit var presenter: AddPeoplePresenter

features/createroom/impl/src/test/kotlin/io/element/android/features/createroom/impl/configureroom/ConfigureRoomPresenterTests.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,7 @@ private const val AN_URI_FROM_GALLERY = "content://uri_from_gallery"
6060
@RunWith(RobolectricTestRunner::class)
6161
class ConfigureRoomPresenterTests {
6262

63-
@Rule
64-
@JvmField
63+
@get:Rule
6564
val warmUpRule = WarmUpRule()
6665

6766
private lateinit var presenter: ConfigureRoomPresenter

features/createroom/impl/src/test/kotlin/io/element/android/features/createroom/impl/root/CreateRoomRootPresenterTests.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@ import org.junit.Test
4444

4545
class CreateRoomRootPresenterTests {
4646

47-
@Rule
48-
@JvmField
47+
@get:Rule
4948
val warmUpRule = WarmUpRule()
5049

5150
private lateinit var userRepository: FakeUserRepository

features/createroom/impl/src/test/kotlin/io/element/android/features/createroom/impl/userlist/DefaultUserListPresenterTests.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ import org.junit.Test
3333

3434
class DefaultUserListPresenterTests {
3535

36-
@Rule
37-
@JvmField
36+
@get:Rule
3837
val warmUpRule = WarmUpRule()
3938

4039
private val userRepository = FakeUserRepository()

features/ftue/impl/src/test/kotlin/io/element/android/features/ftue/impl/migration/MigrationScreenPresenterTest.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ import org.junit.Test
3232

3333
class MigrationScreenPresenterTest {
3434

35-
@Rule
36-
@JvmField
35+
@get:Rule
3736
val warmUpRule = WarmUpRule()
3837

3938
@Test

features/ftue/impl/src/test/kotlin/io/element/android/features/ftue/impl/notifications/NotificationsOptInPresenterTests.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ import org.junit.Test
3939

4040
class NotificationsOptInPresenterTests {
4141

42-
@Rule
43-
@JvmField
42+
@get:Rule
4443
val warmUpRule = WarmUpRule()
4544

4645
private var isFinished = false

0 commit comments

Comments
 (0)