knock requests : fix test on room details view

Author: ganfra

features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsView.kt

@@ -241,7 +241,7 @@ fun RoomDetailsView(
 @Composable
 private fun KnockRequestsItem(knockRequestsCount: Int?, onKnockRequestsClick: () -> Unit) {
     ListItem(
-        headlineContent = { Text(stringResource(CommonStrings.screen_room_details_requests_to_join_title)) },
+        headlineContent = { Text(stringResource(R.string.screen_room_details_requests_to_join_title)) },
         leadingContent = ListItemContent.Icon(IconSource.Vector(CompoundIcons.Notifications())),
         trailingContent = if (knockRequestsCount == null || knockRequestsCount == 0) {
             null
@@ -546,7 +546,7 @@ private fun PinnedMessagesItem(
 ) {
     val analyticsService = LocalAnalyticsService.current
     ListItem(
-        headlineContent = { Text(stringResource(CommonStrings.screen_room_details_pinned_events_row_title)) },
+        headlineContent = { Text(stringResource(R.string.screen_room_details_pinned_events_row_title)) },
         leadingContent = ListItemContent.Icon(IconSource.Vector(CompoundIcons.Pin())),
         trailingContent =
         if (pinnedMessagesCount == null) {

features/roomdetails/impl/src/main/res/values/localazy.xml

@@ -49,9 +49,12 @@
   <string name="screen_room_details_invite_people_title">"Invite people"</string>
   <string name="screen_room_details_leave_conversation_title">"Leave conversation"</string>
   <string name="screen_room_details_leave_room_title">"Leave room"</string>
+  <string name="screen_room_details_media_gallery_title">"Media and files"</string>
   <string name="screen_room_details_notification_mode_custom">"Custom"</string>
   <string name="screen_room_details_notification_mode_default">"Default"</string>
   <string name="screen_room_details_notification_title">"Notifications"</string>
+  <string name="screen_room_details_pinned_events_row_title">"Pinned messages"</string>
+  <string name="screen_room_details_requests_to_join_title">"Requests to join"</string>
   <string name="screen_room_details_roles_and_permissions">"Roles and permissions"</string>
   <string name="screen_room_details_room_name_label">"Room name"</string>
   <string name="screen_room_details_security_title">"Security"</string>

features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsViewTest.kt

@@ -129,7 +129,7 @@ class RoomDetailsViewTest {
                 ),
                 onPinnedMessagesClick = callback,
             )
-            rule.clickOn(CommonStrings.screen_room_details_pinned_events_row_title)
+            rule.clickOn(R.string.screen_room_details_pinned_events_row_title)
         }
     }
 
@@ -253,6 +253,21 @@ class RoomDetailsViewTest {
         rule.clickOn(R.string.screen_room_details_leave_room_title)
         eventsRecorder.assertSingle(RoomDetailsEvent.LeaveRoom)
     }
+
+    @Config(qualifiers = "h1024dp")
+    @Test
+    fun `click on knock requests invokes expected callback`() {
+        ensureCalledOnce { callback ->
+            rule.setRoomDetailView(
+                state = aRoomDetailsState(
+                    eventSink = EventsRecorder(expectEvents = false),
+                    canShowKnockRequests = true,
+                ),
+                onKnockRequestsClick = callback,
+            )
+            rule.clickOn(R.string.screen_room_details_requests_to_join_title)
+        }
+    }
 }
 
 private fun <R : TestRule> AndroidComposeTestRule<R, ComponentActivity>.setRoomDetailView(
@@ -270,6 +285,7 @@ private fun <R : TestRule> AndroidComposeTestRule<R, ComponentActivity>.setRoomD
     openAdminSettings: () -> Unit = EnsureNeverCalled(),
     onJoinCallClick: () -> Unit = EnsureNeverCalled(),
     onPinnedMessagesClick: () -> Unit = EnsureNeverCalled(),
+    onKnockRequestsClick: () -> Unit = EnsureNeverCalled(),
 ) {
     setContent {
         RoomDetailsView(
@@ -285,6 +301,7 @@ private fun <R : TestRule> AndroidComposeTestRule<R, ComponentActivity>.setRoomD
             openAdminSettings = openAdminSettings,
             onJoinCallClick = onJoinCallClick,
             onPinnedMessagesClick = onPinnedMessagesClick,
+            onKnockRequestsClick = onKnockRequestsClick,
         )
     }
 }

libraries/ui-strings/src/main/res/values/localazy.xml

@@ -320,8 +320,6 @@ Reason: %1$s."</string>
   <string name="screen_resolve_send_failure_unsigned_device_title">"Your message was not sent because %1$s has not verified all devices"</string>
   <string name="screen_resolve_send_failure_you_unsigned_device_subtitle">"One or more of your devices are unverified. You can send the message anyway, or you can cancel for now and try again later after you have verified all of your devices."</string>
   <string name="screen_resolve_send_failure_you_unsigned_device_title">"Your message was not sent because you have not verified one or more of your devices"</string>
-  <string name="screen_room_details_pinned_events_row_title">"Pinned messages"</string>
-  <string name="screen_room_details_requests_to_join_title">"Requests to join"</string>
   <string name="screen_room_error_failed_processing_media">"Failed processing media to upload, please try again."</string>
   <string name="screen_room_error_failed_retrieving_user_details">"Could not retrieve user details"</string>
   <plurals name="screen_room_multiple_knock_requests_title">

tools/localazy/config.json

@@ -165,6 +165,7 @@
       "name" : ":features:roomdetails:impl",
       "includeRegex" : [
         "screen_room_details_.*",
+        "screen\\.room_details\\..*",
         "screen_room_member_list_.*",
         "screen_room_notification_settings_.*",
         "screen_notification_settings_edit_failed_updating_default_mode",