Code quality

Author: bmarty

features/home/impl/src/main/kotlin/io/element/android/features/home/impl/spaces/HomeSpaceItemView.kt

@@ -120,7 +120,7 @@ internal fun HomeSpaceItemView(
 }
 
 @Composable
-fun NameAndIndicatorRow(
+private fun NameAndIndicatorRow(
     name: String?,
     showIndicator: Boolean,
     modifier: Modifier = Modifier,
@@ -152,8 +152,8 @@ private fun SpaceScaffoldRow(
     spaceRoom: SpaceRoom,
     onClick: () -> Unit,
     onLongClick: () -> Unit,
-    modifier: Modifier = Modifier,
     hideAvatars: Boolean,
+    modifier: Modifier = Modifier,
     content: @Composable ColumnScope.() -> Unit
 ) {
     val clickModifier = Modifier

features/home/impl/src/main/kotlin/io/element/android/features/home/impl/spaces/HomeSpacesEvents.kt

@@ -7,6 +7,4 @@
 
 package io.element.android.features.home.impl.spaces
 
-sealed interface HomeSpacesEvents {
-
-}
+sealed interface HomeSpacesEvents

features/home/impl/src/main/kotlin/io/element/android/features/home/impl/spaces/HomeSpacesPresenter.kt

@@ -39,7 +39,7 @@ class HomeSpacesPresenter @Inject constructor(
         }.collectAsState(persistentSetOf())
 
         fun handleEvents(event: HomeSpacesEvents) {
-            //when (event) { }
+            // when (event) { }
         }
 
         return HomeSpacesState(

libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/atomic/molecules/InviteButtonsRowMolecule.kt

@@ -44,4 +44,3 @@ fun InviteButtonsRowMolecule(
         )
     }
 }
-

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/RustMatrixClient.kt

@@ -191,11 +191,6 @@ class RustMatrixClient(
         innerSpaceService = innerSpaceService,
         sessionCoroutineScope = sessionCoroutineScope,
         sessionDispatcher = sessionDispatcher,
-        //roomListFactory = RoomListFactory(
-        //    innerRoomListService = innerRoomListService,
-        //    sessionCoroutineScope = sessionCoroutineScope,
-        //),
-        //roomSyncSubscriber = roomSyncSubscriber,
     )
 
     private val verificationService = RustSessionVerificationService(

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/spaces/RustSpaceService.kt

@@ -84,9 +84,7 @@ class RustSpaceService(
     private fun MutableList<SpaceRoom>.applyUpdate(update: SpaceListUpdate) {
         when (update) {
             is SpaceListUpdate.Append -> {
-                val newSpaces = update.values.map { it ->
-                    it.let(mapper::map)
-                }
+                val newSpaces = update.values.map(mapper::map)
                 addAll(newSpaces)
             }
             SpaceListUpdate.Clear -> clear()

libraries/matrixui/src/main/kotlin/io/element/android/libraries/matrix/ui/components/SpaceHeaderView.kt

@@ -66,11 +66,12 @@ fun SpaceHeaderView(
                 textAlign = TextAlign.Center,
             )
         }
-        if (joinRule != null)
+        if (joinRule != null) {
             SpaceInfoRow(
                 joinRule = joinRule,
                 numberOfRooms = numberOfRooms,
             )
+        }
         SpaceMembersView(
             heroes = heroes,
             numberOfMembers = numberOfMembers,