Update the strings for the device verification flow

Part of element-hq/element-meta#2898

Author: andybalaam

features/verifysession/impl/src/main/kotlin/io/element/android/features/verifysession/impl/incoming/IncomingVerificationView.kt

@@ -238,7 +238,7 @@ private fun IncomingVerificationBottomMenu(
                 VerificationBottomMenu {
                     Button(
                         modifier = Modifier.fillMaxWidth(),
-                        text = stringResource(CommonStrings.action_start),
+                        text = stringResource(CommonStrings.action_start_verification),
                         onClick = { eventSink(IncomingVerificationViewEvents.StartVerification) },
                     )
                     TextButton(

features/verifysession/impl/src/main/kotlin/io/element/android/features/verifysession/impl/outgoing/OutgoingVerificationView.kt

@@ -157,7 +157,10 @@ private fun OutgoingVerificationHeader(step: Step, request: VerificationRequest.
         }
         Step.Canceled -> CommonStrings.common_verification_failed
         Step.Ready -> R.string.screen_session_verification_compare_emojis_title
-        Step.Completed -> CommonStrings.common_verification_complete
+        Step.Completed -> when (request) {
+            is VerificationRequest.Outgoing.CurrentSession -> R.string.screen_session_verification_device_verified
+            is VerificationRequest.Outgoing.User -> CommonStrings.common_verification_complete
+        }
         is Step.Verifying -> when (step.data) {
             is SessionVerificationData.Decimals -> R.string.screen_session_verification_compare_numbers_title
             is SessionVerificationData.Emojis -> R.string.screen_session_verification_compare_emojis_title

features/verifysession/impl/src/main/res/values/localazy.xml

@@ -11,13 +11,14 @@
   <string name="screen_identity_use_another_device">"Use another device"</string>
   <string name="screen_identity_waiting_on_other_device">"Waiting on other device…"</string>
   <string name="screen_session_verification_cancelled_subtitle">"Something doesn’t seem right. Either the request timed out or the request was denied."</string>
-  <string name="screen_session_verification_compare_emojis_subtitle">"Confirm that the emojis below match those shown on your other session."</string>
+  <string name="screen_session_verification_compare_emojis_subtitle">"Confirm that the emojis below match those shown on your other device."</string>
   <string name="screen_session_verification_compare_emojis_title">"Compare emojis"</string>
   <string name="screen_session_verification_compare_emojis_user_subtitle">"Confirm that the emojis below match those shown on the other user’s device."</string>
   <string name="screen_session_verification_compare_numbers_subtitle">"Confirm that the numbers below match those shown on your other session."</string>
   <string name="screen_session_verification_compare_numbers_title">"Compare numbers"</string>
-  <string name="screen_session_verification_complete_subtitle">"Your new session is now verified. It has access to your encrypted messages, and other users will see it as trusted."</string>
+  <string name="screen_session_verification_complete_subtitle">"Now you can read or send messages securely on your other device."</string>
   <string name="screen_session_verification_complete_user_subtitle">"Now you can trust the identity of this user when sending or receiving messages."</string>
+  <string name="screen_session_verification_device_verified">"Device verified"</string>
   <string name="screen_session_verification_enter_recovery_key">"Enter recovery key"</string>
   <string name="screen_session_verification_failed_subtitle">"Either the request timed out, the request was denied, or there was a verification mismatch."</string>
   <string name="screen_session_verification_open_existing_session_subtitle">"Prove it’s you in order to access your encrypted message history."</string>
@@ -44,7 +45,7 @@
   <string name="screen_session_verification_user_responder_subtitle">"For extra security, another user wants to verify your identity. You’ll be shown a set of emojis to compare."</string>
   <string name="screen_session_verification_waiting_another_device_subtitle">"You should see a popup on the other device. Start the verification from there now."</string>
   <string name="screen_session_verification_waiting_another_device_title">"Start verification on the other device"</string>
-  <string name="screen_session_verification_waiting_other_device_title">"Waiting for the other device"</string>
+  <string name="screen_session_verification_waiting_other_device_title">"Start verification on the other device"</string>
   <string name="screen_session_verification_waiting_other_user_title">"Waiting for the other user"</string>
   <string name="screen_session_verification_waiting_subtitle">"Once accepted you’ll be able to continue with the verification."</string>
   <string name="screen_session_verification_waiting_to_accept_subtitle">"Accept the request to start the verification process in your other session to continue."</string>