Merge pull request #3450 from element-hq/feature/bma/improveCoverageMetrics

Improve code coverage metrics

Author: bmarty

features/migration/impl/src/test/kotlin/io/element/android/features/migration/impl/migrations/AppMigration05Test.kt

@@ -21,7 +21,7 @@ class AppMigration05Test {
         val sessionStore = InMemorySessionStore().apply {
             updateData(
                 aSessionData(
-                    sessionId = A_SESSION_ID,
+                    sessionId = A_SESSION_ID.value,
                     sessionPath = "",
                 )
             )
@@ -37,7 +37,7 @@ class AppMigration05Test {
         val sessionStore = InMemorySessionStore().apply {
             updateData(
                 aSessionData(
-                    sessionId = A_SESSION_ID,
+                    sessionId = A_SESSION_ID.value,
                     sessionPath = "/a/path/existing",
                 )
             )

features/migration/impl/src/test/kotlin/io/element/android/features/migration/impl/migrations/AppMigration06Test.kt

@@ -21,7 +21,7 @@ class AppMigration06Test {
         val sessionStore = InMemorySessionStore().apply {
             updateData(
                 aSessionData(
-                    sessionId = A_SESSION_ID,
+                    sessionId = A_SESSION_ID.value,
                     sessionPath = "/a/path/to/a/session/AN_ID",
                     cachePath = "",
                 )
@@ -38,7 +38,7 @@ class AppMigration06Test {
         val sessionStore = InMemorySessionStore().apply {
             updateData(
                 aSessionData(
-                    sessionId = A_SESSION_ID,
+                    sessionId = A_SESSION_ID.value,
                     cachePath = "/a/path/existing",
                 )
             )

features/rageshake/impl/build.gradle.kts

@@ -55,6 +55,7 @@ dependencies {
     testImplementation(libs.test.mockk)
     testImplementation(projects.libraries.matrix.test)
     testImplementation(projects.libraries.sessionStorage.implMemory)
+    testImplementation(projects.libraries.sessionStorage.test)
     testImplementation(projects.features.rageshake.test)
     testImplementation(projects.tests.testutils)
     testImplementation(projects.services.toolbox.test)

features/rageshake/impl/src/test/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporterTest.kt

@@ -17,9 +17,8 @@ import io.element.android.libraries.matrix.test.FakeSdkMetadata
 import io.element.android.libraries.matrix.test.core.aBuildMeta
 import io.element.android.libraries.matrix.test.encryption.FakeEncryptionService
 import io.element.android.libraries.network.useragent.DefaultUserAgentProvider
-import io.element.android.libraries.sessionstorage.api.LoginType
-import io.element.android.libraries.sessionstorage.api.SessionData
 import io.element.android.libraries.sessionstorage.impl.memory.InMemorySessionStore
+import io.element.android.libraries.sessionstorage.test.aSessionData
 import io.element.android.tests.testutils.testCoroutineDispatchers
 import kotlinx.coroutines.test.TestScope
 import kotlinx.coroutines.test.runTest
@@ -94,7 +93,7 @@ class DefaultBugReporterTest {
         server.start()
 
         val mockSessionStore = InMemorySessionStore().apply {
-            storeData(mockSessionData("@foo:eample.com", "ABCDEFGH"))
+            storeData(aSessionData(sessionId = "@foo:example.com", deviceId = "ABCDEFGH"))
         }
 
         val buildMeta = aBuildMeta()
@@ -143,7 +142,7 @@ class DefaultBugReporterTest {
         assertThat(foundValues["can_contact"]).isEqualTo("true")
         assertThat(foundValues["device_id"]).isEqualTo("ABCDEFGH")
         assertThat(foundValues["sdk_sha"]).isEqualTo("123456789")
-        assertThat(foundValues["user_id"]).isEqualTo("@foo:eample.com")
+        assertThat(foundValues["user_id"]).isEqualTo("@foo:example.com")
         assertThat(foundValues["text"]).isEqualTo("a bug occurred")
         assertThat(foundValues["device_keys"]).isEqualTo("curve25519:CURVECURVECURVE, ed25519:EDKEYEDKEYEDKY")
 
@@ -163,7 +162,7 @@ class DefaultBugReporterTest {
         server.start()
 
         val mockSessionStore = InMemorySessionStore().apply {
-            storeData(mockSessionData("@foo:eample.com", "ABCDEFGH"))
+            storeData(aSessionData("@foo:example.com", "ABCDEFGH"))
         }
 
         val buildMeta = aBuildMeta()
@@ -267,21 +266,6 @@ class DefaultBugReporterTest {
         return foundValues
     }
 
-    private fun mockSessionData(userId: String, deviceId: String) = SessionData(
-        userId = userId,
-        deviceId = deviceId,
-        homeserverUrl = "example.com",
-        accessToken = "AA",
-        isTokenValid = true,
-        loginType = LoginType.DIRECT,
-        loginTimestamp = null,
-        oidcData = null,
-        refreshToken = null,
-        slidingSyncProxy = null,
-        passphrase = null,
-        sessionPath = "session",
-        cachePath = "cache",
-    )
     @Test
     fun `test sendBugReport error`() = runTest {
         val server = MockWebServer()

features/signedout/impl/build.gradle.kts

@@ -37,5 +37,6 @@ dependencies {
     testImplementation(libs.test.turbine)
     testImplementation(projects.libraries.matrix.test)
     testImplementation(projects.libraries.sessionStorage.implMemory)
+    testImplementation(projects.libraries.sessionStorage.test)
     testImplementation(projects.tests.testutils)
 }

features/signedout/impl/src/main/kotlin/io/element/android/features/signedout/impl/SignedOutStateProvider.kt

@@ -8,7 +8,6 @@
 package io.element.android.features.signedout.impl
 
 import androidx.compose.ui.tooling.preview.PreviewParameterProvider
-import io.element.android.libraries.matrix.api.core.SessionId
 import io.element.android.libraries.sessionstorage.api.LoginType
 import io.element.android.libraries.sessionstorage.api.SessionData
 
@@ -20,18 +19,18 @@ open class SignedOutStateProvider : PreviewParameterProvider<SignedOutState> {
         )
 }
 
-fun aSignedOutState() = SignedOutState(
+private fun aSignedOutState() = SignedOutState(
     appName = "AppName",
     signedOutSession = aSessionData(),
     eventSink = {},
 )
 
-fun aSessionData(
-    sessionId: SessionId = SessionId("@alice:server.org"),
+private fun aSessionData(
+    sessionId: String = "@alice:server.org",
     isTokenValid: Boolean = false,
 ): SessionData {
     return SessionData(
-        userId = sessionId.value,
+        userId = sessionId,
         deviceId = "aDeviceId",
         accessToken = "anAccessToken",
         refreshToken = "aRefreshToken",

features/signedout/impl/src/test/kotlin/io/element/android/features/signedout/impl/SignedOutPresenterTest.kt

@@ -16,6 +16,7 @@ import io.element.android.libraries.matrix.test.A_SESSION_ID
 import io.element.android.libraries.matrix.test.core.aBuildMeta
 import io.element.android.libraries.sessionstorage.api.SessionStore
 import io.element.android.libraries.sessionstorage.impl.memory.InMemorySessionStore
+import io.element.android.libraries.sessionstorage.test.aSessionData
 import io.element.android.tests.testutils.WarmUpRule
 import kotlinx.coroutines.test.runTest
 import org.junit.Rule

libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/room/MatrixRoomInfo.kt

@@ -31,7 +31,7 @@ data class MatrixRoomInfo(
     val isTombstoned: Boolean,
     val isFavorite: Boolean,
     val canonicalAlias: RoomAlias?,
-    val alternativeAliases: ImmutableList<String>,
+    val alternativeAliases: ImmutableList<RoomAlias>,
     val currentUserMembership: CurrentUserMembership,
     val inviter: RoomMember?,
     val activeMembersCount: Long,
@@ -42,7 +42,7 @@ data class MatrixRoomInfo(
     val notificationCount: Long,
     val userDefinedNotificationMode: RoomNotificationMode?,
     val hasRoomCall: Boolean,
-    val activeRoomCallParticipants: ImmutableList<String>,
+    val activeRoomCallParticipants: ImmutableList<UserId>,
     val heroes: ImmutableList<MatrixUser>,
     val pinnedEventIds: ImmutableList<EventId>,
     val creator: UserId?,

libraries/matrix/impl/build.gradle.kts

@@ -47,7 +47,10 @@ dependencies {
     testImplementation(libs.test.truth)
     testImplementation(libs.test.robolectric)
     testImplementation(projects.libraries.matrix.test)
+    testImplementation(projects.libraries.sessionStorage.implMemory)
+    testImplementation(projects.libraries.sessionStorage.test)
     testImplementation(projects.services.analytics.test)
+    testImplementation(projects.services.toolbox.test)
     testImplementation(projects.tests.testutils)
     testImplementation(libs.coroutines.test)
     testImplementation(libs.test.turbine)

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/analytics/JoinedRoomExt.kt

@@ -10,9 +10,10 @@ package io.element.android.libraries.matrix.impl.analytics
 import im.vector.app.features.analytics.plan.JoinedRoom
 import io.element.android.libraries.matrix.api.room.MatrixRoom
 
-private fun Long?.toAnalyticsRoomSize(): JoinedRoom.RoomSize {
+private fun Long.toAnalyticsRoomSize(): JoinedRoom.RoomSize {
     return when (this) {
-        null,
+        0L,
+        1L -> JoinedRoom.RoomSize.One
         2L -> JoinedRoom.RoomSize.Two
         in 3..10 -> JoinedRoom.RoomSize.ThreeToTen
         in 11..100 -> JoinedRoom.RoomSize.ElevenToOneHundred