Merge pull request #3337 from SpiritCroc/stuck-login

bmarty · web-flow · commit c5461b669ff1 · 2024-08-28T09:56:44.000+02:00
Fix login navigation getting stuck when the app was compiled with no-op analytics provider
diff --git a/features/ftue/impl/src/main/kotlin/io/element/android/features/ftue/impl/state/DefaultFtueService.kt b/features/ftue/impl/src/main/kotlin/io/element/android/features/ftue/impl/state/DefaultFtueService.kt
@@ -98,7 +98,10 @@ class DefaultFtueService @Inject constructor(
             } else {
                 getNextStep(FtueStep.AnalyticsOptIn)
             }
-            FtueStep.AnalyticsOptIn -> null
+            FtueStep.AnalyticsOptIn -> {
+                updateState()
+                null
+            }
         }
 
     private suspend fun isAnyStepIncomplete(): Boolean {

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,10 @@ class DefaultFtueService @Inject constructor(`
`98`	`98`	`} else {`
`99`	`99`	`getNextStep(FtueStep.AnalyticsOptIn)`
`100`	`100`	`}`
`101`		`- FtueStep.AnalyticsOptIn -> null`
	`101`	`+ FtueStep.AnalyticsOptIn -> {`
	`102`	`+ updateState()`
	`103`	`+ null`
	`104`	`+ }`
`102`	`105`	`}`
`103`	`106`
`104`	`107`	`private suspend fun isAnyStepIncomplete(): Boolean {`