Skip to content

Commit c6dfc14

Browse files
committed
There is no need to compute the number of column manually.
1 parent 0498564 commit c6dfc14

File tree

1 file changed

+3
-13
lines changed
  • libraries/mediaviewer/impl/src/main/kotlin/io/element/android/libraries/mediaviewer/impl/gallery

1 file changed

+3
-13
lines changed

libraries/mediaviewer/impl/src/main/kotlin/io/element/android/libraries/mediaviewer/impl/gallery/MediaGalleryView.kt

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import androidx.compose.runtime.rememberUpdatedState
3434
import androidx.compose.ui.Alignment
3535
import androidx.compose.ui.Modifier
3636
import androidx.compose.ui.graphics.vector.ImageVector
37-
import androidx.compose.ui.platform.LocalConfiguration
3837
import androidx.compose.ui.res.stringResource
3938
import androidx.compose.ui.tooling.preview.PreviewParameter
4039
import androidx.compose.ui.unit.dp
@@ -73,7 +72,6 @@ import io.element.android.libraries.mediaviewer.impl.gallery.ui.VideoItemView
7372
import io.element.android.libraries.mediaviewer.impl.gallery.ui.VoiceItemView
7473
import io.element.android.libraries.voiceplayer.api.VoiceMessageState
7574
import kotlinx.collections.immutable.ImmutableList
76-
import kotlin.math.max
7775

7876
@OptIn(ExperimentalMaterial3Api::class)
7977
@Composable
@@ -315,19 +313,11 @@ private fun MediaGalleryImageGrid(
315313
eventSink: (MediaGalleryEvents) -> Unit,
316314
onItemClick: (MediaItem.Event) -> Unit,
317315
) {
318-
val configuration = LocalConfiguration.current
319-
val screenWidth = configuration.screenWidthDp.dp
320-
val horizontalPadding = 16.dp
321-
val itemSpacing = 4.dp
322-
val availableWidth = screenWidth - horizontalPadding * 2
323-
val minCellWidth = 80.dp
324-
// Calculate the number of columns
325-
val columns = max(1, (availableWidth / (minCellWidth + itemSpacing)).toInt())
326316
LazyVerticalGrid(
327317
modifier = Modifier
328318
.fillMaxSize()
329-
.padding(horizontal = horizontalPadding),
330-
columns = GridCells.Fixed(columns),
319+
.padding(horizontal = 16.dp),
320+
columns = GridCells.Adaptive(80.dp),
331321
horizontalArrangement = Arrangement.spacedBy(4.dp),
332322
verticalArrangement = Arrangement.spacedBy(4.dp),
333323
) {
@@ -336,7 +326,7 @@ private fun MediaGalleryImageGrid(
336326
span = { item ->
337327
when (item) {
338328
is MediaItem.LoadingIndicator,
339-
is MediaItem.DateSeparator -> GridItemSpan(columns)
329+
is MediaItem.DateSeparator -> GridItemSpan(maxLineSpan)
340330
is MediaItem.Event -> GridItemSpan(1)
341331
}
342332
},

0 commit comments

Comments
 (0)