rust sdk : handle api breaks for 0.2.59

Author: ganfra

features/roomaliasresolver/impl/src/main/kotlin/io/element/android/features/roomaliasresolver/impl/RoomAliasResolverPresenter.kt

@@ -23,6 +23,7 @@ import io.element.android.libraries.matrix.api.core.RoomAlias
 import io.element.android.libraries.matrix.api.room.alias.ResolvedRoomAlias
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.launch
+import kotlin.jvm.optionals.getOrElse
 
 class RoomAliasResolverPresenter @AssistedInject constructor(
     @Assisted private val roomAlias: RoomAlias,
@@ -57,7 +58,9 @@ class RoomAliasResolverPresenter @AssistedInject constructor(
 
     private fun CoroutineScope.resolveAlias(resolveState: MutableState<AsyncData<ResolvedRoomAlias>>) = launch {
         suspend {
-            matrixClient.resolveRoomAlias(roomAlias).getOrThrow()
+            matrixClient.resolveRoomAlias(roomAlias)
+                .getOrThrow()
+                .getOrElse { error("Failed to resolve room alias $roomAlias") }
         }.runCatchingUpdatingState(resolveState)
     }
 }

features/roomaliasresolver/impl/src/test/kotlin/io/element/android/features/roomaliasresolver/impl/RoomAliasResolverPresenterTest.kt

@@ -24,6 +24,7 @@ import io.element.android.tests.testutils.WarmUpRule
 import kotlinx.coroutines.test.runTest
 import org.junit.Rule
 import org.junit.Test
+import java.util.Optional
 
 class RoomAliasResolverPresenterTest {
     @get:Rule
@@ -42,7 +43,7 @@ class RoomAliasResolverPresenterTest {
 
     @Test
     fun `present - resolve alias to roomId`() = runTest {
-        val result = aResolvedRoomAlias()
+        val result = Optional.of(aResolvedRoomAlias())
         val client = FakeMatrixClient(
             resolveRoomAliasResult = { Result.success(result) }
         )
@@ -54,7 +55,7 @@ class RoomAliasResolverPresenterTest {
             assertThat(awaitItem().resolveState.isLoading()).isTrue()
             val resultState = awaitItem()
             assertThat(resultState.roomAlias).isEqualTo(A_ROOM_ALIAS)
-            assertThat(resultState.resolveState.dataOrNull()).isEqualTo(result)
+            assertThat(resultState.resolveState.dataOrNull()).isEqualTo(result.get())
         }
     }
 

features/roomdirectory/impl/src/main/kotlin/io/element/android/features/roomdirectory/impl/root/RoomDirectoryPresenter.kt

@@ -28,6 +28,8 @@ import kotlinx.coroutines.flow.flowOn
 import kotlinx.coroutines.flow.map
 import javax.inject.Inject
 
+private const val SEARCH_BATCH_SIZE = 20
+
 class RoomDirectoryPresenter @Inject constructor(
     private val dispatchers: CoroutineDispatchers,
     private val roomDirectoryService: RoomDirectoryService,
@@ -51,7 +53,7 @@ class RoomDirectoryPresenter @Inject constructor(
             loadingMore = false
             // debounce search query
             delay(300)
-            roomDirectoryList.filter(searchQuery, 20)
+            roomDirectoryList.filter(filter = searchQuery, batchSize = SEARCH_BATCH_SIZE, viaServerName = null)
         }
         LaunchedEffect(loadingMore) {
             if (loadingMore) {

features/roomdirectory/impl/src/test/kotlin/io/element/android/features/roomdirectory/impl/root/RoomDirectoryPresenterTest.kt

@@ -81,7 +81,7 @@ import org.junit.Test
 
     @Test
     fun `present - emit search event`() = runTest {
-        val filterLambda = lambdaRecorder { _: String?, _: Int ->
+        val filterLambda = lambdaRecorder { _: String?, _: Int, _: String? ->
             Result.success(Unit)
         }
         val roomDirectoryList = FakeRoomDirectoryList(filterLambda = filterLambda)
@@ -99,7 +99,7 @@ import org.junit.Test
         }
         assert(filterLambda)
             .isCalledOnce()
-            .with(value("test"), any())
+            .with(value("test"), any(), value(null))
     }
 
     @Test

libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/MatrixClient.kt

@@ -108,7 +108,14 @@ interface MatrixClient : Closeable {
 
     suspend fun trackRecentlyVisitedRoom(roomId: RoomId): Result<Unit>
     suspend fun getRecentlyVisitedRooms(): Result<List<RoomId>>
-    suspend fun resolveRoomAlias(roomAlias: RoomAlias): Result<ResolvedRoomAlias>
+
+    /**
+     * Resolves the given room alias to a roomID (and a list of servers), if possible.
+     * @param roomAlias the room alias to resolve
+     * @return the resolved room alias if any, an empty result if not found,or an error if the resolution failed.
+     *
+     */
+    suspend fun resolveRoomAlias(roomAlias: RoomAlias): Result<Optional<ResolvedRoomAlias>>
 
     /**
      * Enables or disables the sending queue, according to the given parameter.

libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/roomdirectory/RoomDirectoryList.kt

@@ -10,8 +10,22 @@ package io.element.android.libraries.matrix.api.roomdirectory
 import kotlinx.coroutines.flow.Flow
 
 interface RoomDirectoryList {
-    suspend fun filter(filter: String?, batchSize: Int): Result<Unit>
+    /**
+     * Starts a filtered search for the server.
+     * If the filter is not provided it will search for all the rooms. You can specify a batch_size to control the number of rooms to fetch per request.
+     * If the via_server is not provided it will search in the current homeserver by default.
+     * This method will clear the current search results and start a new one
+     */
+    suspend fun filter(filter: String?, batchSize: Int, viaServerName: String?): Result<Unit>
+
+    /**
+     * Load more rooms from the current search results.
+     */
     suspend fun loadMore(): Result<Unit>
+
+    /**
+     * The current search results as a state flow.
+     */
     val state: Flow<State>
 
     data class State(

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/RustMatrixClient.kt

@@ -71,7 +71,6 @@ import kotlinx.collections.immutable.ImmutableList
 import kotlinx.collections.immutable.persistentListOf
 import kotlinx.collections.immutable.toPersistentList
 import kotlinx.coroutines.CoroutineScope
-import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.TimeoutCancellationException
 import kotlinx.coroutines.cancel
 import kotlinx.coroutines.channels.Channel
@@ -112,7 +111,6 @@ import org.matrix.rustcomponents.sdk.RoomPreset as RustRoomPreset
 import org.matrix.rustcomponents.sdk.RoomVisibility as RustRoomVisibility
 import org.matrix.rustcomponents.sdk.SyncService as ClientSyncService
 
-@OptIn(ExperimentalCoroutinesApi::class)
 class RustMatrixClient(
     private val client: Client,
     private val baseDirectory: File,
@@ -420,13 +418,15 @@ class RustMatrixClient(
         }
     }
 
-    override suspend fun resolveRoomAlias(roomAlias: RoomAlias): Result<ResolvedRoomAlias> = withContext(sessionDispatcher) {
+    override suspend fun resolveRoomAlias(roomAlias: RoomAlias): Result<Optional<ResolvedRoomAlias>> = withContext(sessionDispatcher) {
         runCatching {
-            val result = client.resolveRoomAlias(roomAlias.value)
-            ResolvedRoomAlias(
-                roomId = RoomId(result.roomId),
-                servers = result.servers,
-            )
+            val result = client.resolveRoomAlias(roomAlias.value)?.let {
+                ResolvedRoomAlias(
+                    roomId = RoomId(it.roomId),
+                    servers = it.servers,
+                )
+            }
+            Optional.ofNullable(result)
         }
     }
 

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/roomdirectory/RustRoomDirectoryList.kt

@@ -41,9 +41,9 @@ class RustRoomDirectoryList(
             .launchIn(coroutineScope)
     }
 
-    override suspend fun filter(filter: String?, batchSize: Int): Result<Unit> {
+    override suspend fun filter(filter: String?, batchSize: Int, viaServerName: String?): Result<Unit> {
         return execute {
-            inner.search(filter = filter, batchSize = batchSize.toUInt())
+            inner.search(filter = filter, batchSize = batchSize.toUInt(), viaServerName = viaServerName)
         }
     }
 

libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/fixtures/fakes/FakeRustRoomDirectorySearch.kt

@@ -21,7 +21,7 @@ class FakeRustRoomDirectorySearch(
         return isAtLastPage
     }
 
-    override suspend fun search(filter: String?, batchSize: UInt) = simulateLongTask { }
+    override suspend fun search(filter: String?, batchSize: UInt, viaServerName: String?) = simulateLongTask { }
     override suspend fun nextPage() = simulateLongTask { }
 
     private var listener: RoomDirectorySearchEntriesListener? = null

libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/roomdirectory/RustRoomDirectoryListTest.kt

@@ -36,7 +36,7 @@ class RustRoomDirectoryListTest {
         // Let the mxCallback be ready
         runCurrent()
         sut.state.test {
-            sut.filter("", 20)
+            sut.filter(filter = "", batchSize = 20, viaServerName = null)
             roomDirectorySearch.emitResult(
                 listOf(
                     RoomDirectorySearchEntryUpdate.Append(listOf(aRustRoomDescription()))